change tests to use mock data templates

Author: weswc

src/api/routes/issues.rs

@@ -314,14 +314,13 @@ pub async fn get_blocked_issues<G: GitProvider + 'static>(
             format_error_list(&created_threads.thread_errors)
         )));
     }
-    let statuses = created_threads
-        .entries
-        .into_values()
-        .map(|entry| BlockedIssueStatus {
-            issue: entry.issue,
-            qc_status: entry.qc_status,
-        })
-        .collect();
+
+    // Merge cached statuses with newly fetched ones
+    let mut statuses = blocked_statuses;
+    statuses.extend(created_threads.entries.into_values().map(|entry| BlockedIssueStatus {
+        issue: entry.issue,
+        qc_status: entry.qc_status,
+    }));
 
     Ok(Json(statuses))
 }

src/api/tests/cases/assignees/list_assignees_success.yaml

@@ -3,7 +3,13 @@ description: "Retrieve repository assignees with login and name"
 
 fixtures:
   users:
-    - repository_users.json
+    - type: mock
+      login: "octocat"
+      name: "The Octocat"
+    - type: mock
+      login: "reviewer1"
+
+
 
 git_state: {}
 

src/api/tests/cases/comments/post_approve_blocked.yaml

@@ -3,8 +3,36 @@ description: "Fail to approve when gating QC is not approved"
 
 fixtures:
   issues:
-    - test_file_issue.json      # Issue #1 - open (not approved)
-    - issue_with_blocking.json  # Issue #2 - has #1 as Gating QC
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
+    - type: mock
+      number: 2
+      title: "src/config.rs"
+      body: |
+        Quality check issue for src/config.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: feature/config-update
+        author: Jane Developer <developer@example.com>
+        
+        ## Relevant Files
+        
+        ### Gating QC
+        - [src/test.rs](https://github.com/owner/repo/issues/1) - Must be approved before this file
+        
+        ### Previous QC
+        None
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/comments/post_approve_force.yaml

@@ -3,8 +3,36 @@ description: "Successfully approve with force=true even when gating QC is not ap
 
 fixtures:
   issues:
-    - test_file_issue.json      # Issue #1 - open (not approved)
-    - issue_with_blocking.json  # Issue #2 - has #1 as Gating QC
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
+    - type: mock
+      number: 2
+      title: "src/config.rs"
+      body: |
+        Quality check issue for src/config.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: feature/config-update
+        author: Jane Developer <developer@example.com>
+        
+        ## Relevant Files
+        
+        ### Gating QC
+        - [src/test.rs](https://github.com/owner/repo/issues/1) - Must be approved before this file
+        
+        ### Previous QC
+        None
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/comments/post_approve_success.yaml

@@ -3,7 +3,17 @@ description: "Successfully approve an issue and close it"
 
 fixtures:
   issues:
-    - test_file_issue.json
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/comments/post_comment_success.yaml

@@ -3,7 +3,17 @@ description: "Successfully create a comment on an existing issue"
 
 fixtures:
   issues:
-    - test_file_issue.json
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/comments/post_review_success.yaml

@@ -4,7 +4,17 @@ description: "Successfully create a comment on an existing issue"
 fixtures:
   milestones: []
   issues:
-    - test_file_issue.json
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/comments/post_unapprove_success.yaml

@@ -3,7 +3,17 @@ description: "Successfully unapprove an issue and re-open it"
 
 fixtures:
   issues:
-    - test_file_issue.json
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
 
 git_state: {}
 

src/api/tests/cases/configuration/get_configuration_status_success.yaml

@@ -2,8 +2,6 @@ name: "GET /api/configuration/status"
 description: "Successfully fetch configuration repository status"
 
 fixtures:
-  milestones:
-    - v1.0.json
 
 git_state:
   commit: "abc123"

src/api/tests/cases/issues/batch_get_issue_status_blocking.yaml

@@ -3,8 +3,36 @@ description: "Verify blocking_qc_status is populated by parsing issue body for b
 
 fixtures:
   issues:
-    - test_file_issue.json       # Issue #1 (blocking)
-    - issue_with_blocking.json   # Issue #2 (has Gating QC: #1 in body)
+    - type: mock
+      number: 1
+      title: "src/test.rs"
+      body: |
+        Quality check issue for src/test.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: main
+        author: The Octocat <octocat@example.com>
+      milestone: 1
+    - type: mock
+      number: 2
+      title: "src/config.rs"
+      body: |
+        Quality check issue for src/config.rs
+        
+        ## Metadata
+        initial qc commit: 456def789abc012345678901234567890123cdef
+        git branch: feature/config-update
+        author: Jane Developer <developer@example.com>
+        
+        ## Relevant Files
+        
+        ### Gating QC
+        - [src/test.rs](https://github.com/owner/repo/issues/1) - Must be approved before this file
+        
+        ### Previous QC
+        None
+      milestone: 1
 
 git_state:
   commit: "abc123"