Found reliance on default encoding in org.aavso.tools.vstar.auth.AAVSOPostUserPassXMLAuthenticationSource.authenticate(String, String): String.getBytes()

Found reliance on default encoding in org.aavso.tools.vstar.auth.Auth0JSONAutheticationSource.authenticate(String, String): new java.io.InputStreamReader(InputStream)

new org.aavso.tools.vstar.data.CommentCodes(String) invokes inefficient new String() constructor

org.aavso.tools.vstar.data.CommentCodes.getCommentcodes() may expose internal representation by returning CommentCodes.commentcodes

The class name org.aavso.tools.vstar.data.Property$propType doesn't start with an upper case letter

Public static org.aavso.tools.vstar.data.SeriesType.getSeriesColorChangeNotifier() may expose internal representation by returning SeriesType.seriesColorChangeNotifier

Public static org.aavso.tools.vstar.data.SeriesType.getSeriesSizeChangeNotifier() may expose internal representation by returning SeriesType.seriesSizeChangeNotifier

Public static org.aavso.tools.vstar.data.SeriesType.values() may expose internal representation by returning SeriesType.values

org.aavso.tools.vstar.data.SeriesType.updateSeriesColorMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.data.SeriesType.updateSeriesSizeMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.data.ValidObservation.getDetails() may expose internal representation by returning ValidObservation.details

org.aavso.tools.vstar.data.ValidObservation.getMagnitude() may expose internal representation by returning ValidObservation.magnitude

org.aavso.tools.vstar.data.ValidObservation.setMagnitude(Magnitude) may expose internal representation by storing an externally mutable object into ValidObservation.magnitude

Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTitles() may expose internal representation by returning ValidObservation.detailTitles

Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTypes() may expose internal representation by returning ValidObservation.detailTypes

Public static org.aavso.tools.vstar.data.ValidObservation.getStandardDetailKeys() may expose internal representation by returning ValidObservation.standardDetailKeys

Write to static field org.aavso.tools.vstar.data.ValidObservation.detailIndex from instance method org.aavso.tools.vstar.data.ValidObservation.addDetail(String, Property, String)

org.aavso.tools.vstar.data.ValidObservation.toString() makes inefficient use of keySet iterator instead of entrySet iterator

Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getMatcherOps() may expose internal representation by returning AbstractObservationFieldMatcher.ops

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getObservationSelectionMessage() may expose internal representation by returning AbstractObservationFieldMatcher.observationSelectionMessage

new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.ops

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.observationSelectionMessage

Switch statement found in org.aavso.tools.vstar.data.filter.BooleanFieldMatcher.matches(ValidObservation) where default case is missing

org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.ops should be package protected

Switch statement found in org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.matches(ValidObservation) where default case is missing

org.aavso.tools.vstar.data.filter.ObservationFilter.getMatchers() may expose internal representation by returning ObservationFilter.matchers

org.aavso.tools.vstar.data.filter.ObservationFilter.MATCHERS is a mutable collection

org.aavso.tools.vstar.data.filter.ObservationMatcherOp.toString() may return null

org.aavso.tools.vstar.data.filter.PhaseFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) may expose internal representation by storing an externally mutable object into PhaseFieldMatcher.observationSelectionMessage

Switch statement found in org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher.matches(ValidObservation) where default case is missing

Switch statement found in org.aavso.tools.vstar.data.filter.StringFieldMatcher.matches(ValidObservation) where default case is missing

org.aavso.tools.vstar.data.validation.AAVSOFormatFieldInfoSource.getFieldIndexMap() may expose internal representation by returning AAVSOFormatFieldInfoSource.fieldIndexMap

Exception thrown in class org.aavso.tools.vstar.data.validation.CKMagValidator at new org.aavso.tools.vstar.data.validation.CKMagValidator(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

new org.aavso.tools.vstar.data.validation.CommonTextFormatValidator(String, CsvReader, int, int, String, IFieldInfoSource) may expose internal representation by storing an externally mutable object into CommonTextFormatValidator.lineReader

Unread field: org.aavso.tools.vstar.data.validation.JulianDayValidator.pattern; should this field be static?

Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_INDEX; should this field be static?

Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_MODIFIER_INDEX; should this field be static?

Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.UNCERTAINTY_INDEX; should this field be static?

org.aavso.tools.vstar.data.validation.SimpleFormatFieldInfoSource.getFieldIndexMap() may expose internal representation by returning SimpleFormatFieldInfoSource.fieldIndexMap

org.aavso.tools.vstar.exception.ObservationValidationWarning.getObservation() may expose internal representation by returning ObservationValidationWarning.ob

new org.aavso.tools.vstar.exception.ObservationValidationWarning(String, ValidObservation) may expose internal representation by storing an externally mutable object into ObservationValidationWarning.ob

new org.aavso.tools.vstar.exception.ObservationValidationWarning(ValidObservation) may expose internal representation by storing an externally mutable object into ObservationValidationWarning.ob

Found reliance on default encoding in org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String): new String(byte[], int, int)

Found reliance on default encoding in org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String): String.getBytes()

org.aavso.tools.vstar.input.AbstractObservationRetriever.getInvalidObservations() may expose internal representation by returning AbstractObservationRetriever.invalidObservations

org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservationCategoryMap() may expose internal representation by returning AbstractObservationRetriever.validObservationCategoryMap

org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservations() may expose internal representation by returning AbstractObservationRetriever.validObservations

new org.aavso.tools.vstar.input.database.AuthenticationTask(List, String, String) may expose internal representation by storing an externally mutable object into AuthenticationTask.authenticators

org.aavso.tools.vstar.input.database.Authenticator.authenticate() invokes inefficient new String(String) constructor

new org.aavso.tools.vstar.input.text.ObservationFieldSplitter(CsvReader, int, int) may expose internal representation by storing an externally mutable object into ObservationFieldSplitter.lineReader

new org.aavso.tools.vstar.input.text.ObservationSourceAnalyser(LineNumberReader, String) may expose internal representation by storing an externally mutable object into ObservationSourceAnalyser.obsSource

new org.aavso.tools.vstar.input.text.TextFormatObservationReader(LineNumberReader, ObservationSourceAnalyser, String) may expose internal representation by storing an externally mutable object into TextFormatObservationReader.reader

org.aavso.tools.vstar.plugin.CustomFilterPluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.GeneralToolPluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.ModelCreatorPluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.ObservationSinkPluginBase.test() has Boolean return type and returns explicit null

Found reliance on default encoding in org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getTestRetriever(String[], String): String.getBytes()

org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getInputStreams() may expose internal representation by returning ObservationSourcePluginBase.inputStreams

org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.setInputInfo(List, String) may expose internal representation by storing an externally mutable object into ObservationSourcePluginBase.inputStreams

org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.ObservationToolPluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.ObservationTransformerPluginBase.test() has Boolean return type and returns explicit null

org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterNameValuePairs() may expose internal representation by returning CommonTextFormatSinkPluginBase.DELIMS

org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterSuffixValuePairs() may expose internal representation by returning CommonTextFormatSinkPluginBase.SUFFIXES

org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.DELIMS is a mutable collection which should be package protected

org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.SUFFIXES is a mutable collection which should be package protected

Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDescription()

Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDisplayName()

org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getInputName() concatenates strings using + in a loop

org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getURLs() makes inefficient use of keySet iterator instead of entrySet iterator

Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.retrieveAAVSOPhotometryURLObs(InputStream, SeriesType): new java.io.InputStreamReader(InputStream)

Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.getSourceType()

Switch statement found in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLSearchParameterDialog$2.actionPerformed(ActionEvent) where default case is missing

Redundant nullcheck of id, which is known to be non-null in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceCSVObservationSourcePlugin$VSXCSVObservationRetriever.retrieveNextObservation(CsvReader)

Exception thrown in class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase at new org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Dead store to starName in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getURLs()

org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.setInfo(StarInfo) may expose internal representation by storing an externally mutable object into AIDWebServiceObservationSourcePluginBase.info

Comparison of String parameter using == or != in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)

Comparison of String parameter using == or != in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)

Load of known null value in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)

Redundant nullcheck of id, which is known to be non-null in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceXMLAttributeObservationSourcePlugin$VSXAIDAttributeObservationRetriever.retrieveObservation(INodeSequence)

new org.aavso.tools.vstar.plugin.ob.src.impl.NamedNodeMapSequence(NamedNodeMap) may expose internal representation by storing an externally mutable object into NamedNodeMapSequence.nodeMap

Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever(): new java.io.InputStreamReader(InputStream)

Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever(): String.getBytes()

org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever() may fail to close stream

org.aavso.tools.vstar.plugin.period.PeriodAnalysisPluginBase.test() has Boolean return type and returns explicit null

Found reliance on default encoding in org.aavso.tools.vstar.scripting.ScriptRunner.runScript(File): new java.io.FileReader(File)

Public static org.aavso.tools.vstar.scripting.ScriptRunner.getInstance() may expose internal representation by returning ScriptRunner.instance

Class (org.aavso.tools.vstar.scripting.ScriptRunner) using singleton design pattern has non-private constructor.

Incorrect lazy initialization of static field org.aavso.tools.vstar.scripting.VStarScriptingAPI.instance in org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance()

Public static org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance() may expose internal representation by returning VStarScriptingAPI.instance

Possible null pointer dereference of dcdft in org.aavso.tools.vstar.scripting.VStarScriptingAPI.dcdftCommon(String, DcDftAnalysisType, double, double, double) on exception path

org.aavso.tools.vstar.scripting.VStarScriptingAPI.getSeries() concatenates strings using + in a loop

org.aavso.tools.vstar.scripting.VStarScriptingAPI.pause(long) calls Thread.sleep() with a lock held

org.aavso.tools.vstar.ui.MainFrame.getStatusPane() may expose internal representation by returning MainFrame.statusPane

Dead store to lastGroup in org.aavso.tools.vstar.ui.MenuBar.createAnalysisMenu()

new org.aavso.tools.vstar.ui.MenuBar(IMainUI, UIType) may expose internal representation by storing an externally mutable object into MenuBar.parent

org.aavso.tools.vstar.ui.MenuBar.minimalUIExclusions is a mutable collection which should be package protected

org.aavso.tools.vstar.ui.NamedComponent.getComponent() may expose internal representation by returning NamedComponent.component

new org.aavso.tools.vstar.ui.NamedComponent(String, Component) may expose internal representation by storing an externally mutable object into NamedComponent.component

new org.aavso.tools.vstar.ui.NamedComponent(String, Component, String) may expose internal representation by storing an externally mutable object into NamedComponent.component

Exception thrown in class org.aavso.tools.vstar.ui.NumberSelectionPane at new org.aavso.tools.vstar.ui.NumberSelectionPane(String, double, double, double, double, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons() invokes System.exit(...), which shuts down the entire virtual machine

new org.aavso.tools.vstar.ui.ToolBar(MenuBar) may expose internal representation by storing an externally mutable object into ToolBar.menuBar

Redundant nullcheck of org.aavso.tools.vstar.ui.ToolBar.newStarFromDatabaseIcon, which is known to be non-null in org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons()

Repeated conditional test in org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons()

org.aavso.tools.vstar.ui.VStar.LOGGER isn't final but should be

Exception is caught when Exception is not thrown in org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>()

Exceptional return value of java.io.File.mkdir() ignored in org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>()

org.aavso.tools.vstar.ui.VStar$4.run() invokes System.exit(...), which shuts down the entire virtual machine

Shared primitive variable "obsTextProvided" in one thread may not yield the value of the most recent write from another thread

org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.getDefaultFileExtensions() may expose internal representation by returning AdditiveLoadFileOrUrlChooser.extensions

Switch statement found in org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.createPluginsList() where default case is missing

org.aavso.tools.vstar.ui.dialog.Checkbox.getUIComponent() may expose internal representation by returning Checkbox.checkbox

Exception thrown in class org.aavso.tools.vstar.ui.dialog.DateToJdDialog at new org.aavso.tools.vstar.ui.dialog.DateToJdDialog(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Should org.aavso.tools.vstar.ui.dialog.DateToJdDialog$DoubleFieldSeconds be a _static_ inner class?

Nullcheck of delimiter2suffixes at line 100 of value previously dereferenced in org.aavso.tools.vstar.ui.dialog.DelimitedFieldFileSaveChooser.getSelectedFile()

new org.aavso.tools.vstar.ui.dialog.FileExtensionFilter(List) may expose internal representation by storing an externally mutable object into FileExtensionFilter.extensions

Dead store to statsTextArea in org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List)

org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List) makes inefficient use of keySet iterator instead of entrySet iterator

Exception thrown in class org.aavso.tools.vstar.ui.dialog.LogDialog at new org.aavso.tools.vstar.ui.dialog.LogDialog() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Found reliance on default encoding in org.aavso.tools.vstar.ui.dialog.LogDialog.createLogPanel(): new java.io.FileReader(String)

org.aavso.tools.vstar.ui.dialog.MultiEntryComponentDialog.okAction() concatenates strings using + in a loop

org.aavso.tools.vstar.ui.dialog.NumberFieldBase.getUIComponent() may expose internal representation by returning NumberFieldBase.textField

new org.aavso.tools.vstar.ui.dialog.ObservationDetailsDialog(ValidObservation) may expose internal representation by storing an externally mutable object into ObservationDetailsDialog.ob

org.aavso.tools.vstar.util.stats.epoch.AlphaOmegaMeanJDEpochStrategy stored into non-transient field PhaseParameterDialog.epochStrategy

new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) may expose internal representation by storing an externally mutable object into PlotControlDialog.plotPane

new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) may expose internal representation by storing an externally mutable object into PlotControlDialog.timeElementsInBinSettingPane

org.aavso.tools.vstar.ui.dialog.SelectableTextField.getUIComponent() may expose internal representation by returning SelectableTextField.textChooser

new org.aavso.tools.vstar.ui.dialog.SeriesTypeCreationDialog(List) may expose internal representation by storing an externally mutable object into SeriesTypeCreationDialog.obs

org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane.getStarGroups() may expose internal representation by returning StarGroupSelectionPane.starGroups

new org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane(JTextField, boolean) may expose internal representation by storing an externally mutable object into StarGroupSelectionPane.starField

Exception thrown in class org.aavso.tools.vstar.ui.dialog.StarSelectorDialog at new org.aavso.tools.vstar.ui.dialog.StarSelectorDialog() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Public static org.aavso.tools.vstar.ui.dialog.StarSelectorDialog.getInstance() may expose internal representation by returning StarSelectorDialog.instance

Class (org.aavso.tools.vstar.ui.dialog.StarSelectorDialog) using singleton design pattern directly or indirectly implements Serializable interface.

org.aavso.tools.vstar.ui.dialog.TextArea.getUIComponent() may expose internal representation by returning TextArea.textArea

Exception thrown in class org.aavso.tools.vstar.ui.dialog.TextAreaTabs at new org.aavso.tools.vstar.ui.dialog.TextAreaTabs(List, List, int, int, boolean, boolean, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.dialog.TextAreaTabs.getUIComponent() may expose internal representation by returning TextAreaTabs.tabs

org.aavso.tools.vstar.ui.dialog.TextDialog.getTextFields() may expose internal representation by returning TextDialog.textFields

org.aavso.tools.vstar.ui.dialog.TextField.getUIComponent() may expose internal representation by returning TextField.textField

new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) may expose internal representation by storing an externally mutable object into HarmonicInfoDialog.interfaceComponent

new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) may expose internal representation by storing an externally mutable object into HarmonicInfoDialog.msg

org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog$3.actionPerformed(ActionEvent) concatenates strings using + in a loop

org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog.getHarmonics() may expose internal representation by returning HarmonicInputDialog.harmonicsPerSelectedPeriod

new org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog(Component, List, Map, String) may expose internal representation by storing an externally mutable object into HarmonicInputDialog.freqToHarmonics

org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getChart() may expose internal representation by returning PeriodAnalysis2DChartPane.chart

org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getModel() may expose internal representation by returning PeriodAnalysis2DChartPane.model

new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DChartPane.chart

new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DChartPane.model

Method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.datasetChanged(DatasetChangeEvent) seems to be useless

Doomed test for equality to NaN in org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane$3.update(PeriodAnalysisSelectionMessage)

Exception thrown in class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog at new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog(String, String, IPeriodAnalysisAlgorithm, PeriodAnalysisCoordinateType[], PeriodAnalysisCoordinateType) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane.getTable() may expose internal representation by returning PeriodAnalysisDataTablePane.table

new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane(PeriodAnalysisDataTableModel, IPeriodAnalysisAlgorithm, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTablePane.model

org.aavso.tools.vstar.ui.dialog.period.refinement.PeriodGatheringPane.getPeriods() may expose internal representation by returning PeriodGatheringPane.periods

new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZDataTablePane(WWZDataTableModel) may expose internal representation by storing an externally mutable object into WWZDataTablePane.model

org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getChart() may expose internal representation by returning WWZPlotPane.chart

org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getModel() may expose internal representation by returning WWZPlotPane.model

new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) may expose internal representation by storing an externally mutable object into WWZPlotPane.chart

new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) may expose internal representation by storing an externally mutable object into WWZPlotPane.model

new org.aavso.tools.vstar.ui.dialog.period.wwz.WeightedWaveletZTransformResultDialog(String, String, WeightedWaveletZTransform, WWZCoordinateType) may expose internal representation by storing an externally mutable object into WeightedWaveletZTransformResultDialog.wwt

new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog(PluginManager) may expose internal representation by storing an externally mutable object into PluginManagementDialog.manager

Unread field: org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE; should this field be static?

Unread field: org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE_MOD; should this field be static?

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation.getManager() may expose internal representation by returning PluginManagementOperation.manager

new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation(PluginManager, String) may expose internal representation by storing an externally mutable object into PluginManagementOperation.manager

Found reliance on default encoding in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveRemotePluginInfo(String): new java.io.InputStreamReader(InputStream)

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLibs() may expose internal representation by returning PluginManager.libs

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalDescriptionsToJarName() may expose internal representation by returning PluginManager.localDescriptions

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalPluginsByJarName() may expose internal representation by returning PluginManager.localPlugins

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemoteDescriptionsToJarName() may expose internal representation by returning PluginManager.remoteDescriptions

org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemotePluginsByJarName() may expose internal representation by returning PluginManager.remotePlugins

Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() due to return value of called method

Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() due to return value of called method

Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() due to return value of called method

Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() due to return value of called method

Exceptional return value of java.io.File.mkdir() ignored in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.installPlugin(String, PluginManager$Operation)

Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ChartFontLabel be a _static_ inner class?

Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ColorRectComponent be a _static_ inner class?

Potentially ambiguous invocation of either an outer or inherited method org.aavso.tools.vstar.ui.dialog.AbstractOkCancelDialog.createButtonPane() in new org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog(ChartPropertiesSelectionPane, Font)

Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog be a _static_ inner class?

new org.aavso.tools.vstar.ui.dialog.prefs.LocaleSelectionPane() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.dialog.prefs.NewGroupWithStarsDialog.getStarList() may expose internal representation by returning NewGroupWithStarsDialog.starList

Public static org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog.getInstance() may expose internal representation by returning PreferencesDialog.instance

Class (org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog) using singleton design pattern directly or indirectly implements Serializable interface.

org.aavso.tools.vstar.ui.dialog.prefs.SeriesColorSelectionPane.getChangedSeriesColorMap() may expose internal representation by returning SeriesColorSelectionPane.changedSeriesColorMap

org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane.getChangedSeriesSizeMap() may expose internal representation by returning SeriesSizeSelectionPane.changedSeriesSizeMap

Should org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane$DotComponent be a _static_ inner class?

org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.getNextPane() may expose internal representation by returning AbstractSeriesVisibilityDialog.nextPane

new org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog(ISeriesInfoProvider, String, JPanel) may expose internal representation by storing an externally mutable object into AbstractSeriesVisibilityDialog.nextPane

Unwritten public or protected field: org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.seriesVisibilityPane

new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) may expose internal representation by storing an externally mutable object into MeanSourcePane.obsPlotModel

new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) may expose internal representation by storing an externally mutable object into MeanSourcePane.obsPlotPane

new org.aavso.tools.vstar.ui.dialog.series.MultipleSeriesSelectionDialog(SeriesVisibilityPane) may expose internal representation by storing an externally mutable object into MultipleSeriesSelectionDialog.seriesVisibilityPane

org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.getVisibilityDeltaMap() may expose internal representation by returning SeriesVisibilityPane.visibilityDeltaMap

new org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane(ObservationAndMeanPlotModel, AnalysisType, boolean, boolean, boolean) may expose internal representation by storing an externally mutable object into SeriesVisibilityPane.obsPlotModel

org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.seriesVisibilityChange(Map) makes inefficient use of keySet iterator instead of entrySet iterator

new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionDialog(ObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into SingleSeriesSelectionDialog.obsPlotModel

new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionPane(ObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into SingleSeriesSelectionPane.obsPlotModel

org.aavso.tools.vstar.ui.mediator.DocumentManager.getStatsInfo() may expose internal representation by returning DocumentManager.statsInfo

Write to static field org.aavso.tools.vstar.ui.mediator.DocumentManager.filterNum from instance method org.aavso.tools.vstar.ui.mediator.DocumentManager.getNextUntitledFilterName()

org.aavso.tools.vstar.ui.mediator.Mediator.quit() invokes System.exit(...), which shuts down the entire virtual machine

org.aavso.tools.vstar.ui.mediator.Mediator.createNewStarObservationArtefacts(NewStarType, StarInfo, int, boolean) forces garbage collection; extremely dubious except in benchmarking code

org.aavso.tools.vstar.ui.mediator.Mediator.getAnalysisTypeChangeNotifier() may expose internal representation by returning Mediator.analysisTypeChangeNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getDiscrepantObservationNotifier() may expose internal representation by returning Mediator.discrepantObservationNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getDocumentManager() may expose internal representation by returning Mediator.documentManager

org.aavso.tools.vstar.ui.mediator.Mediator.getExcludedObservationNotifier() may expose internal representation by returning Mediator.excludedObservationNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getFilteredObservationNotifier() may expose internal representation by returning Mediator.filteredObservationNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getHarmonicSearchNotifier() may expose internal representation by returning Mediator.harmonicSearchNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getMeanSourceSeriesChangeNotifier() may expose internal representation by returning Mediator.meanSourceSeriesChangeNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getModelCreationNotifier() may expose internal representation by returning Mediator.modelCreationNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getModelDialog() may expose internal representation by returning Mediator.modelDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionMessage() may expose internal representation by returning Mediator.modelSelectionMessage

org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionNofitier() may expose internal representation by returning Mediator.modelSelectionNofitier

org.aavso.tools.vstar.ui.mediator.Mediator.getMultipleObservationSelectionNotifier() may expose internal representation by returning Mediator.multipleObservationSelectionNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarMessageList() may expose internal representation by returning Mediator.newStarMessageList

org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarNotifier() may expose internal representation by returning Mediator.newStarNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getObsFilterDialog() may expose internal representation by returning Mediator.obsFilterDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getObservationFiltersDialog() may expose internal representation by returning Mediator.observationFiltersDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getObservationSelectionNotifier() may expose internal representation by returning Mediator.observationSelectionNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPanRequestNotifier() may expose internal representation by returning Mediator.panRequestNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisRefinementNotifier() may expose internal representation by returning Mediator.periodAnalysisRefinementNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisSelectionNotifier() may expose internal representation by returning Mediator.periodAnalysisSelectionNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodChangeNotifier() may expose internal representation by returning Mediator.periodChangeNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseChangeNotifier() may expose internal representation by returning Mediator.phaseChangeNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseDialog() may expose internal representation by returning Mediator.phaseDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseParameterDialog() may expose internal representation by returning Mediator.phaseParameterDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseSelectionNotifier() may expose internal representation by returning Mediator.phaseSelectionNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getProgressNotifier() may expose internal representation by returning Mediator.progressNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesCreationNotifier() may expose internal representation by returning Mediator.seriesCreationNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesVisibilityChangeNotifier() may expose internal representation by returning Mediator.seriesVisibilityChangeNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getStopRequestNotifier() may expose internal representation by returning Mediator.stopRequestNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getUndoActionNotifier() may expose internal representation by returning Mediator.undoActionNotifier

org.aavso.tools.vstar.ui.mediator.Mediator.getUndoableActionManager() may expose internal representation by returning Mediator.undoableActionManager

org.aavso.tools.vstar.ui.mediator.Mediator.getValidObsList() may expose internal representation by returning Mediator.validObsList

org.aavso.tools.vstar.ui.mediator.Mediator.getValidObservationCategoryMap() may expose internal representation by returning Mediator.validObservationCategoryMap

org.aavso.tools.vstar.ui.mediator.Mediator.getVelaFileSaveDialog() may expose internal representation by returning Mediator.velaFileSaveDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getVelaXMLsaveDialog() may expose internal representation by returning Mediator.velaXMLsaveDialog

org.aavso.tools.vstar.ui.mediator.Mediator.getZoomRequestNotifier() may expose internal representation by returning Mediator.zoomRequestNotifier

Public static org.aavso.tools.vstar.ui.mediator.Mediator.getInstance() may expose internal representation by returning Mediator.mediator

Public static org.aavso.tools.vstar.ui.mediator.Mediator.getUI() may expose internal representation by returning Mediator.ui

Possible null pointer dereference of obs in org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String)

Switch statement found in org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String) where one case falls through to the next case

Write to static field org.aavso.tools.vstar.ui.mediator.Mediator.ui from instance method org.aavso.tools.vstar.ui.mediator.Mediator.setUI(IMainUI)

Write to static field org.aavso.tools.vstar.ui.mediator.Mediator.ui from instance method new org.aavso.tools.vstar.ui.mediator.Mediator()

org.aavso.tools.vstar.ui.mediator.Mediator.createPhasePlotArtefacts(double, double, Map) makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.mediator.StarInfo.getRetriever() may expose internal representation by returning StarInfo.retriever

new org.aavso.tools.vstar.ui.mediator.StarInfo(AbstractObservationRetriever, String, String, Double, Double, String, String, String, RAInfo, DecInfo, Integer) may expose internal representation by storing an externally mutable object into StarInfo.retriever

org.aavso.tools.vstar.ui.mediator.StarInfo.setRetriever(AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into StarInfo.retriever

org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getMeansListPane() may expose internal representation by returning AnalysisTypeChangeMessage.meansListPane

org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsAndMeanChartPane() may expose internal representation by returning AnalysisTypeChangeMessage.obsAndMeanChartPane

org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsListPane() may expose internal representation by returning AnalysisTypeChangeMessage.obsListPane

new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.meansListPane

new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.obsAndMeanChartPane

new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.obsListPane

org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage.getObservation() may expose internal representation by returning DiscrepantObservationMessage.observation

new org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage(ValidObservation, Object) may expose internal representation by storing an externally mutable object into DiscrepantObservationMessage.observation

org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage.getObservations() may expose internal representation by returning ExcludedObservationMessage.observations

new org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage(List, Object) may expose internal representation by storing an externally mutable object into ExcludedObservationMessage.observations

org.aavso.tools.vstar.ui.mediator.message.FilteredObservationMessage.getFilteredObs() may expose internal representation by returning FilteredObservationMessage.filteredObs

org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage.getHarmonics() may expose internal representation by returning HarmonicSearchResultMessage.harmonics

new org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage(Object, List, IPeriodAnalysisDatum, double) may expose internal representation by storing an externally mutable object into HarmonicSearchResultMessage.harmonics

org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage.getObservations() may expose internal representation by returning MultipleObservationSelectionMessage.observations

new org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage(List, Object) may expose internal representation by storing an externally mutable object into MultipleObservationSelectionMessage.observations

org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getLoadDate() may expose internal representation by returning NewStarMessage.loadDate

org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObsCategoryMap() may expose internal representation by returning NewStarMessage.obsCategoryMap

org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObservations() may expose internal representation by returning NewStarMessage.obs

org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getStarInfo() may expose internal representation by returning NewStarMessage.starInfo

new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.obs

new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.obsCategoryMap

new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.starInfo

org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage.getObservation() may expose internal representation by returning ObservationSelectionMessage.observation

new org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage(ValidObservation, Object) may expose internal representation by storing an externally mutable object into ObservationSelectionMessage.observation

org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getNewTopHits() may expose internal representation by returning PeriodAnalysisRefinementMessage.newTopHits

org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedData() may expose internal representation by returning PeriodAnalysisRefinementMessage.refinedData

org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedTopHits() may expose internal representation by returning PeriodAnalysisRefinementMessage.refinedTopHits

new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.newTopHits

new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.refinedData

new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.refinedTopHits

org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.getSeriesVisibilityMap() may expose internal representation by returning PhaseChangeMessage.seriesVisibilityMap

new org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage(Object, double, double, Map) may expose internal representation by storing an externally mutable object into PhaseChangeMessage.seriesVisibilityMap

org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.toString() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage.getSeriesVisibilityMap() may expose internal representation by returning PhaseSelectionMessage.seriesVisibilityMap

new org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage(Object, double, double, Map) may expose internal representation by storing an externally mutable object into PhaseSelectionMessage.seriesVisibilityMap

org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.BUSY_PROGRESS isn't final but should be

org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.CLEAR_PROGRESS isn't final but should be

org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.COMPLETE_PROGRESS isn't final but should be

org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.INCREMENT_PROGRESS isn't final but should be

org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.START_PROGRESS isn't final but should be

org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage.getObs() may expose internal representation by returning SeriesCreationMessage.obs

new org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage(Object, SeriesType, List) may expose internal representation by storing an externally mutable object into SeriesCreationMessage.obs

org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage.getVisibleSeries() may expose internal representation by returning SeriesVisibilityChangeMessage.visibleSeries

new org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage(Object, Set) may expose internal representation by storing an externally mutable object into SeriesVisibilityChangeMessage.visibleSeries

org.aavso.tools.vstar.ui.mediator.message.UndoableActionType.toString() may return null

org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected

Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnTitle(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) where default case is missing

Exception thrown in class org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel at new org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel(List, SeriesType) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel.getObs() may expose internal representation by returning AbstractSyntheticObservationTableModel.obs

new org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel(List) may expose internal representation by storing an externally mutable object into AbstractSyntheticObservationTableModel.obs

org.aavso.tools.vstar.ui.model.list.ArbitraryFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected

new org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel(List) may expose internal representation by storing an externally mutable object into InvalidObservationTableModel.invalidObservations

Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnName(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getValueAt(int, int) where default case is missing

org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.getData() may expose internal representation by returning PeriodAnalysisDataTableModel.data

new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.columnTypes

new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.data

org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.setData(Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.data

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnName(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getValueAt(int, int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnName(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getValueAt(int, int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnName(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getValueAt(int, int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnName(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getValueAt(int, int) where default case is missing

org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected

Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnClass(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnTitle(int) where default case is missing

Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) where default case is missing

org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsInserter() may expose internal representation by returning ValidObservationTableModel.obsInserter

org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsSourceListMap() may expose internal representation by returning ValidObservationTableModel.obsSourceListMap

org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObservations() may expose internal representation by returning ValidObservationTableModel.validObservations

new org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel(Map, List, ITableColumnInfoSource) may expose internal representation by storing an externally mutable object into ValidObservationTableModel.obsSourceListMap

org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getStats() may expose internal representation by returning WWZDataTableModel.stats

org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getWwt() may expose internal representation by returning WWZDataTableModel.wwt

new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) may expose internal representation by storing an externally mutable object into WWZDataTableModel.stats

new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) may expose internal representation by storing an externally mutable object into WWZDataTableModel.wwt

org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getFit() may expose internal representation by returning ContinuousModelFunction.fit

org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getPpModel() may expose internal representation by returning ContinuousModelFunction.ppModel

new org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction(UnivariateRealFunction, List, double, ICoordSource) may expose internal representation by storing an externally mutable object into ContinuousModelFunction.fit

org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.setPpModel(PhasedObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into ContinuousModelFunction.ppModel

new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction) may expose internal representation by storing an externally mutable object into ContinuousModelPlotModel.modelFunction

Integral division result cast to double or float in new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction)

org.aavso.tools.vstar.ui.model.plot.JDCoordSource.instance isn't final but should be

Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeanObsList() may expose internal representation by returning ObservationAndMeanPlotModel.meanObsList

org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeansChangeNotifier() may expose internal representation by returning ObservationAndMeanPlotModel.meansChangeNotifier

org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getTimeElementEntity() may expose internal representation by returning ObservationAndMeanPlotModel.timeElementEntity

new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) may expose internal representation by storing an externally mutable object into ObservationAndMeanPlotModel.timeElementEntity

org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.determineMeanSeriesSource() makes inefficient use of keySet iterator instead of entrySet iterator

Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToObSrcListMap() may expose internal representation by returning ObservationPlotModel.seriesNumToObSrcListMap

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToSrcTypeMap() may expose internal representation by returning ObservationPlotModel.seriesNumToSrcTypeMap

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesVisibilityMap() may expose internal representation by returning ObservationPlotModel.seriesVisibilityMap

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesWhoseElementsShouldBeJoinedVisually() may expose internal representation by returning ObservationPlotModel.seriesToBeJoinedVisually

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSrcTypeToSeriesNumMap() may expose internal representation by returning ObservationPlotModel.srcTypeToSeriesNumMap

new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) makes inefficient use of keySet iterator instead of entrySet iterator

new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getVisibleSeries() makes inefficient use of keySet iterator instead of entrySet iterator

Exception thrown in class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel at new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getAnalysisValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.analysisValues

org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getDomainValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.domainValues

org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getRangeValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.rangeValues

new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DPlotModel.analysisValues

new org.aavso.tools.vstar.ui.model.plot.PhasedObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map, ContinuousModelFunction, int) may expose internal representation by storing an externally mutable object into PhasedObservationAndMeanPlotModel.modelFunction

org.aavso.tools.vstar.ui.model.plot.PreviousCyclePhaseCoordSource.instance isn't final but should be

org.aavso.tools.vstar.ui.model.plot.StandardPhaseCoordSource.instance isn't final but should be

org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel.getStats() may expose internal representation by returning WWZ2DPlotModel.stats

new org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel(List, WWZCoordinateType, WWZCoordinateType) may expose internal representation by storing an externally mutable object into WWZ2DPlotModel.stats

new org.aavso.tools.vstar.ui.pane.list.ListSearchPane(AbstractTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into ListSearchPane.rowSorter

org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getInvalidDataTable() may expose internal representation by returning ObservationListPane.invalidDataTable

org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getLastObSelected() may expose internal representation by returning ObservationListPane.lastObSelected

org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getValidDataTable() may expose internal representation by returning ObservationListPane.validDataTable

new org.aavso.tools.vstar.ui.pane.list.ObservationListPane(String, ValidObservationTableModel, InvalidObservationTableModel, boolean, Set, AnalysisType) may expose internal representation by storing an externally mutable object into ObservationListPane.validDataModel

org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getLastObSelected() may expose internal representation by returning SyntheticObservationListPane.lastObSelected

org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTable() may expose internal representation by returning SyntheticObservationListPane.obsTable

org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTableModel() may expose internal representation by returning SyntheticObservationListPane.obsTableModel

new org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane(AbstractSyntheticObservationTableModel, String) may expose internal representation by storing an externally mutable object into SyntheticObservationListPane.obsTableModel

new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into VeLaListSearchPane.model

new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into VeLaListSearchPane.rowSorter

new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) may expose internal representation by storing an externally mutable object into VisibleSeriesRowFilter.tableModel

new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) may expose internal representation by storing an externally mutable object into VisibleSeriesRowFilter.visibleSeries

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.updateChartProperties() might ignore java.lang.Exception

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartControlPanel() may expose internal representation by returning AbstractObservationPlotPane.chartControlPanel

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartPanel() may expose internal representation by returning AbstractObservationPlotPane.chartPanel

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastObSelected() may expose internal representation by returning AbstractObservationPlotPane.lastObSelected

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastPointClicked() may expose internal representation by returning AbstractObservationPlotPane.lastPointClicked

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getObsInfo() may expose internal representation by returning AbstractObservationPlotPane.obsInfo

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getRenderer() may expose internal representation by returning AbstractObservationPlotPane.renderer

new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.bounds

new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.obsModel

new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.retriever

Test for floating point equality in org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale()

Unwritten public or protected field: org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.chartControlPanel

Unwritten public or protected field: org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsInfo

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.seriesVisibilityChange(Map) makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesColors() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesSizes() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesVisibility() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.pane.plot.ObservationAndMeanPlotPane.getObsModel() may expose internal representation by returning AbstractObservationPlotPane.obsModel

org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.getObsModels() may expose internal representation by returning PhaseAndMeanPlotPane.obsAndMeanModels

new org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane(String, String, Dimension, double, double, AbstractObservationRetriever, PhasedObservationAndMeanPlotModel[]) may expose internal representation by storing an externally mutable object into PhaseAndMeanPlotPane.obsAndMeanModels

org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.PHASE isn't final but should be

new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) may expose internal representation by storing an externally mutable object into TimeElementsInBinSettingPane.plotPane

new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) may expose internal representation by storing an externally mutable object into TimeElementsInBinSettingPane.timeElementEntity

Integral division result cast to double or float in org.aavso.tools.vstar.ui.pane.plot.VStarPlotDataRenderer.setSeriesSize(int, int)

org.aavso.tools.vstar.ui.resources.LoginType.toString() may return null

Possible null pointer dereference in org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() due to return value of called method

Possible null pointer dereference in org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() due to return value of called method

Public static org.aavso.tools.vstar.ui.resources.ResourceAccessor.getLoginInfo() may expose internal representation by returning ResourceAccessor.loginInfo

Exception thrown in class org.aavso.tools.vstar.ui.resources.StarGroups at new org.aavso.tools.vstar.ui.resources.StarGroups() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.ui.resources.StarGroups.getNotifier() may expose internal representation by returning StarGroups.notifier

Public static org.aavso.tools.vstar.ui.resources.StarGroups.getInstance() may expose internal representation by returning StarGroups.instance

Class (org.aavso.tools.vstar.ui.resources.StarGroups) using singleton design pattern has non-private constructor.

org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() makes inefficient use of keySet iterator instead of entrySet iterator

Found reliance on default encoding in org.aavso.tools.vstar.ui.task.NewStarFromFileTask.createFileBasedObservationArtefacts(File, ObservationSourceAnalyser): new java.io.FileReader(String)

Shared primitive variable "cancelled" in one thread may not yield the value of the most recent write from another thread

Shared primitive variable "obsCount" in one thread may not yield the value of the most recent write from another thread

Found reliance on default encoding in org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure(): String.getBytes()

new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask(ObservationSourcePluginBase) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginTask.obSourcePlugin

org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure() concatenates strings using + in a loop

new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask(ObservationSourcePluginBase, File, boolean) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginWithSuppliedFileTask.obSourcePlugin

org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.createObservationArtefacts() may fail to clean up java.io.InputStream

Return value of org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() ignored, but method has no side effect

new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask(ObservationSourcePluginBase, URL, boolean) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginWithSuppliedURLTask.obSourcePlugin

Return value of org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() ignored, but method has no side effect

Found reliance on default encoding in org.aavso.tools.vstar.ui.task.ObsListFileSaveTask.doInBackground(): new java.io.PrintWriter(File)

new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) may expose internal representation by storing an externally mutable object into ObsListFileSaveTask.observations

new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) may expose internal representation by storing an externally mutable object into ObsListFileSaveTask.plugin

Shared primitive variable "successful" in one thread may not yield the value of the most recent write from another thread

new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisTask.obs

new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisTask.periodAnalysisPlugin

new org.aavso.tools.vstar.ui.task.PhasePlotTask(double, double, Map) may expose internal representation by storing an externally mutable object into PhasePlotTask.seriesVisibilityMap

new org.aavso.tools.vstar.ui.undo.ObservationExclusionAction(List, boolean) may expose internal representation by storing an externally mutable object into ObservationExclusionAction.obs

Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.execute(): java.io.ByteArrayOutputStream.toString()

Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.execute(): new java.io.PrintStream(OutputStream)

Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.showOutput(ByteArrayOutputStream): java.io.ByteArrayOutputStream.toString()

Write to static field org.aavso.tools.vstar.ui.vela.VeLaDialog.code from instance method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String)

Write to static field org.aavso.tools.vstar.ui.vela.VeLaDialog.code from instance method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String, JComponent, Consumer)

Switch statement found in org.aavso.tools.vstar.ui.vela.VeLaDialog$2.keyTyped(KeyEvent) where default case is missing

new org.aavso.tools.vstar.util.AbstractExtremaFinder(List, UnivariateRealFunction, ICoordSource, double) may expose internal representation by storing an externally mutable object into AbstractExtremaFinder.obs

org.aavso.tools.vstar.util.AbstractExtremaFinder.toString() may return null

Dead store to jda in org.aavso.tools.vstar.util.TSBase.load_raw()

Dead store to jdb in org.aavso.tools.vstar.util.TSBase.load_raw()

org.aavso.tools.vstar.util.TSBase.getObservations() may expose internal representation by returning TSBase.observations

new org.aavso.tools.vstar.util.TSBase(List) may expose internal representation by storing an externally mutable object into TSBase.observations

Comparison of String objects using == or != in org.aavso.tools.vstar.util.TSBase.project()

Useless condition: it's known that this.interrupted == false at this point

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.dsig

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.dtsig

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.magspan

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.ndigt

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.obias

Unread public/protected field: org.aavso.tools.vstar.util.TSBase.tmark

org.aavso.tools.vstar.util.comparator.DoubleAsStringComparator implements Comparator but not Serializable

org.aavso.tools.vstar.util.comparator.DoubleComparator implements Comparator but not Serializable

org.aavso.tools.vstar.util.comparator.JDComparator.instance isn't final but should be

org.aavso.tools.vstar.util.comparator.RankedIndexPairComparator.compare(double[], double[]) negates the return value of Double.compare(double, double)

Exception thrown in class org.aavso.tools.vstar.util.discrepant.DiscrepantReport at new org.aavso.tools.vstar.util.discrepant.DiscrepantReport(String, String, int, String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Found reliance on default encoding in org.aavso.tools.vstar.util.discrepant.VSXWebServiceZapperLogger.lodge(DiscrepantReport): String.getBytes()

Double assignment of urlStr in org.aavso.tools.vstar.util.help.Help.openPluginHelp(String)

org.aavso.tools.vstar.util.model.AbstractModel.getFit() may expose internal representation by returning AbstractModel.fit

org.aavso.tools.vstar.util.model.AbstractModel.getFunctionStrings() may expose internal representation by returning AbstractModel.functionStrMap

org.aavso.tools.vstar.util.model.AbstractModel.getResiduals() may expose internal representation by returning AbstractModel.residuals

new org.aavso.tools.vstar.util.model.AbstractModel(List) may expose internal representation by storing an externally mutable object into AbstractModel.obs

Doomed test for equality to NaN in org.aavso.tools.vstar.util.model.AbstractModel.fitMetrics()

org.aavso.tools.vstar.util.model.Harmonic.compareTo(Harmonic) incorrectly handles double value

Exception thrown in class org.aavso.tools.vstar.util.model.Harmonic at new org.aavso.tools.vstar.util.model.Harmonic(double) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Exception thrown in class org.aavso.tools.vstar.util.model.Harmonic at new org.aavso.tools.vstar.util.model.Harmonic(double, int) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.util.model.Harmonic defines compareTo(Harmonic) and uses Object.equals()

Test for floating point equality in org.aavso.tools.vstar.util.model.Harmonic.isHarmonic(Harmonic)

org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFit() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.fit

org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFunctionStrings() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.functionStrMap

org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getHarmonics() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.harmonics

org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getParameters() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.parameters

org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getResiduals() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.residuals

new org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel(PeriodAnalysisDataPoint, List, IPeriodAnalysisAlgorithm) may expose internal representation by storing an externally mutable object into PeriodAnalysisDerivedMultiPeriodicModel.harmonics

Format string should use %n rather than \n in org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.toUncertaintyString()

Using floating-point loop counters can lead to unexpected behavior.

org.aavso.tools.vstar.util.model.PeriodFitParameters defines equals and uses Object.hashCode()

Exception thrown in class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator at new org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator(List) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getHarmonicMap() may expose internal representation by returning RelativeAmplitudeAndPhaseCreator.harmonicMap

org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getRelativeSequenceString(double, int, boolean) concatenates strings using + in a loop

org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.hasHarmonics() makes inefficient use of keySet iterator instead of entrySet iterator

org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFit() may expose internal representation by returning TSPolynomialFitter.fit

org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFunctionStrings() may expose internal representation by returning TSPolynomialFitter.functionStrMap

org.aavso.tools.vstar.util.model.TSPolynomialFitter.getResiduals() may expose internal representation by returning TSPolynomialFitter.residuals

Comparison of String objects using == or != in org.aavso.tools.vstar.util.model.TSPolynomialFitter.polymast(int)

Useless object stored in variable dzeta of method org.aavso.tools.vstar.util.model.TSPolynomialFitter.polyfit()

org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getFit() may expose internal representation by returning WWZMultiperiodicModel.fit

org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getResiduals() may expose internal representation by returning WWZMultiperiodicModel.residuals

new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) may expose internal representation by storing an externally mutable object into WWZMultiperiodicModel.periods

new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) may expose internal representation by storing an externally mutable object into WWZMultiperiodicModel.wwt

org.aavso.tools.vstar.util.notification.ListChangeMessage.getSource() may expose internal representation by returning ListChangeMessage.source

new org.aavso.tools.vstar.util.notification.ListChangeMessage(ListChangeType, List, int, Object) may expose internal representation by storing an externally mutable object into ListChangeMessage.source

org.aavso.tools.vstar.util.notification.ListChangeMessage.NONE isn't final but should be

new org.aavso.tools.vstar.util.notification.NotifyingArrayList(ArrayList) may expose internal representation by storing an externally mutable object into NotifyingArrayList.list

Unwritten public or protected field: org.aavso.tools.vstar.util.notification.NotifyingList.notifier

Exception thrown in class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint at new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(double[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

Exception thrown in class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint at new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoordTypes() may expose internal representation by returning PeriodAnalysisDataPoint.coordTypes

org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoords() may expose internal representation by returning PeriodAnalysisDataPoint.coords

new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataPoint.coordTypes

org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.DCDFT_COORD_TYPES should be package protected

org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.toString() makes inefficient use of keySet iterator instead of entrySet iterator

Dead store to damplit in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.dcdftCommon()

Dead store to hiper in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.frequency_range()

Dead store to nnn in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel)

Dead store to xlofre in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.period_range()

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getAdjustedJDs() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.tvec

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getMags() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.xvec

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getResultSeries() may expose internal representation by returning TSDcDft.resultSeries

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getTopHits() may expose internal representation by returning TSDcDft.topHits

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getWeights() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.wvec

org.aavso.tools.vstar.util.period.dcdft.TSDcDft.refineByFrequency(List, List, List) may expose internal representation by returning TSDcDft.deltaTopHits

Comparison of String objects using == or != in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel)

Should org.aavso.tools.vstar.util.period.dcdft.TSDcDft$ResolutionResult be a _static_ inner class?

org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.toString() may return null

Switch statement found in org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.getTypeFromId(int) where default case is missing

org.aavso.tools.vstar.util.period.wwz.WWZStatistic defines equals and uses Object.hashCode()

This write of the 64-bit primitive variable "maxAmp" may not atomic

This write of the 64-bit primitive variable "maxPeriod" may not atomic

This write of the 64-bit primitive variable "maxWWZ" may not atomic

This write of the 64-bit primitive variable "minAmp" may not atomic

This write of the 64-bit primitive variable "minPeriod" may not atomic

This write of the 64-bit primitive variable "minWWZ" may not atomic

This write of the 64-bit primitive variable "fhi" may not atomic

This write of the 64-bit primitive variable "flo" may not atomic

This write of the 64-bit primitive variable "fhi" may not atomic

This write of the 64-bit primitive variable "flo" may not atomic

This write of the 64-bit primitive variable "maxPeriod" may not atomic

This write of the 64-bit primitive variable "minPeriod" may not atomic

Operation on the "ntau" shared variable in "WeightedWaveletZTransform" class is not atomic

Shared primitive variable "numdat" in one thread may not yield the value of the most recent write from another thread

Shared primitive variable "nfreq" in one thread may not yield the value of the most recent write from another thread

Shared primitive variable "nfreq" in one thread may not yield the value of the most recent write from another thread

Shared primitive variable "ntau" in one thread may not yield the value of the most recent write from another thread

Shared primitive variable "threadCount" in one thread may not yield the value of the most recent write from another thread

org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getMaximalStats() may expose internal representation by returning WeightedWaveletZTransform.maximalStats

org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getObs() may expose internal representation by returning WeightedWaveletZTransform.obs

org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getStats() may expose internal representation by returning WeightedWaveletZTransform.stats

new org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform(List, double, double) may expose internal representation by storing an externally mutable object into WeightedWaveletZTransform.obs

org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MAX_PNG_SCALE_FACTOR isn't final but should be

org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MIN_PNG_SCALE_FACTOR isn't final but should be

Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getInputFormatString(int, NumericPrecisionPrefs$Type) on exception path

Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormat(int, NumericPrecisionPrefs$Type) on exception path

Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormatLocaleIndependent(int, NumericPrecisionPrefs$Type) on exception path

org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs$Type.toString() may return null

Exception thrown in class org.aavso.tools.vstar.util.property.ApplicationProperties at new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.

org.aavso.tools.vstar.util.property.ApplicationProperties.update() invokes System.exit(...), which shuts down the entire virtual machine

new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) may expose internal representation by storing an externally mutable object into ApplicationProperties.frame

org.aavso.tools.vstar.util.stats.Bin.getMagnitudes() may expose internal representation by returning Bin.magnitudes

org.aavso.tools.vstar.util.stats.Bin.getMeanObservation() may expose internal representation by returning Bin.meanObservation

new org.aavso.tools.vstar.util.stats.Bin(ValidObservation, double[]) may expose internal representation by storing an externally mutable object into Bin.magnitudes