Cherry-pick 0.4.0 release related changes into 1deg_iaf by anton-seaice · Pull Request #167 · ACCESS-NRI/access-om3-configs

anton-seaice · 2025-02-07T03:26:50Z

Cherry-pick changes from #344

The comparison between this branch and def-1deg_jra55do_ryf is useful to compare MOM_input:

https://github.com/ACCESS-NRI/access-om3-configs/compare/209-dev-1deg_jra55do_iaf..dev-1deg_jra55do_ryf

anton-seaice · 2025-02-07T03:28:48Z

!test repro

github-actions · 2025-02-07T03:35:35Z

✅ The Bitwise Reproducibility Check Succeeded ✅

When comparing:

209-dev-1deg_jra55do_iaf (checksums created using commit 581d4e8), against
dev-1deg_jra55do_iaf (checksums in commit 4259d19)

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/581d4e894d516411fdd1b7dcee55d4102bc19ef9, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/36828430881.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13192625539/artifacts/2551830304.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/4259d19457011d74586789b5f6b65a9ff06f404c/testing/checksum

See https://github.com/COSIMA/access-om3/issues/251 Co-authored-by: minghangli-uni <Minghang.Li1@anu.edu.au>

…ARAMS

payu-org/payu#496 Removed some checks in Payu which required unused components to be present in the nuopc.runconfig file. Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>

The new build uses openmpi4.1.7, which fixes some bugs preventing parallel reads over symlinks. This allows use of parallelio netcdf4 option, even though at this resolution for most components we will still only use one PE for IO.

Per https://github.com/COSIMA/access-om3/issues/201

…_at_endofrun per https://github.com/COSIMA/access-om3/issues/175

This only affects the logging, the actual value is hardcoded through a #ifdef CESMCOUPLED

dougiesquire · 2025-02-11T04:17:18Z

!test repro

dougiesquire · 2025-02-11T04:18:06Z

Note, I rebased everything onto the latest dev-1deg_jra55do_iaf so that the CI checks use the new reference checksums generated with the fixed model-config-tests

github-actions · 2025-02-11T04:25:07Z

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

209-dev-1deg_jra55do_iaf (checksums created using commit 240b86f), against
dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/240b86f4ea3fe59bcf73b4afd1909ffd42548b0d, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37002455974.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13255759311/artifacts/2569200532.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

See https://github.com/COSIMA/access-om3/issues/274

dougiesquire

@minghangli-uni, would be great to get your eyes on this also so I'm not approving my own changes

anton-seaice · 2025-02-18T03:57:07Z

I can't review my own PR but this needs update checksums committed. I think the pipeline is broken, don't merge just yet !

anton-seaice · 2025-02-18T04:50:26Z

!test repro commit

github-actions · 2025-02-18T04:57:17Z

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

209-dev-1deg_jra55do_iaf (checksums created using commit 9ebbf2e), against
dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/9ebbf2e305e530004258a93e764dd55ea179265f, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37376162110.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13383483690/artifacts/2606806900.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

dougiesquire · 2025-02-18T05:14:36Z

@minghangli-uni , Tommy has now fixed the workflow and the new checksums have been committed. Are you happy with this PR?

minghangli-uni

LGTM. But @dougiesquire you are @ a wrong person 😆

minghangli-uni · 2025-02-18T05:31:19Z

I think I should run a test repro before merging

minghangli-uni · 2025-02-18T05:31:30Z

!test repro

github-actions · 2025-02-18T05:38:20Z

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

209-dev-1deg_jra55do_iaf (checksums created using commit 07ff320), against
dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/07ff320ed20974b72362145c7717d17bc5d4eb68, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37377365658.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13383931096/artifacts/2606921477.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

dougiesquire · 2025-02-18T05:44:15Z

LGTM. But @dougiesquire you are @ a wrong person 😆

Sorry, not again!

dougiesquire · 2025-02-18T05:47:54Z

Hmmm, the workflow is committing the updated checksums to ./testing not ./testing/checksum. I've pinged Tommy about this

aekiss · 2025-02-18T23:52:37Z

General comment. I noticed that there are large diffs in MOM_input, but this is partly (mostly?) non-semantic formatting changes. While these could be compared semantically with https://github.com/aekiss/nmltab, it would be better to standardise the format so the diffs are smaller (see https://github.com/COSIMA/access-om3/issues/198). Is that what this PR is doing?

dougiesquire · 2025-02-18T23:57:00Z

Is that what this PR is doing?

Yup

anton-seaice · 2025-02-18T23:57:24Z

Yes this is implementing https://github.com/COSIMA/access-om3/issues/200 - i.e reordering MOM_input to follow MOM_parameter_docs

It will make it easier to compare any differences and sync across configs later if desired (i.e. https://github.com/COSIMA/access-om3/issues/198)

dougiesquire · 2025-02-19T02:09:15Z

!test repro commit

github-actions · 2025-02-19T02:15:07Z

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

209-dev-1deg_jra55do_iaf (checksums created using commit 9ebbf2e), against
dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/9ebbf2e305e530004258a93e764dd55ea179265f, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37440517127.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13403967450/artifacts/2613446193.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

…-configs/actions/runs/13403967450

anton-seaice requested a review from dougiesquire February 7, 2025 03:28

anton-seaice and others added 14 commits February 11, 2025 15:14

License file

5a8e5bd

Update incorrect note in MOM_override

1437598

See https://github.com/COSIMA/access-om3/issues/251 Co-authored-by: minghangli-uni <Minghang.Li1@anu.edu.au>

reorder MOM_input to follow MOM_parameter_doc, turn on FATAL_UNUSED_P…

621f59f

…ARAMS

Remove unused components

e0b23c2

payu-org/payu#496 Removed some checks in Payu which required unused components to be present in the nuopc.runconfig file. Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>

Update to ACCESS-NRI/ACCESS-OM3 deployment 25.01.0

624f552

Update field dictionary with latest from CMEPS

657adb6

add_gusts parameter needed for 0.4.0 build

5151e00

Update nuopc.runconfig to turn-off dates in restart_pointers

b97a9dd

Use .d and .m in CICE history output filenames

e1a100b

Per https://github.com/COSIMA/access-om3/issues/201

Turn off extra cice restarts and remove non functioning write_restart…

bcfefb2

…_at_endofrun per https://github.com/COSIMA/access-om3/issues/175

Use mom supergrid as cice grid file

1bc0c40

Set Earth radius the same as the UM

3cc885b

Add WIND_STAGGER to MOM_INPUT for clarity

240b86f

This only affects the logging, the actual value is hardcoded through a #ifdef CESMCOUPLED

dougiesquire force-pushed the 209-dev-1deg_jra55do_iaf branch from 581d4e8 to 240b86f Compare February 11, 2025 04:15

dougiesquire mentioned this pull request Feb 17, 2025

MOM6 parameter changes for 0.4.0 #451

Closed

Update MOM6 parameters and docs

9ebbf2e

See https://github.com/COSIMA/access-om3/issues/274

dougiesquire approved these changes Feb 18, 2025

View reviewed changes

minghangli-uni self-requested a review February 18, 2025 05:29

minghangli-uni approved these changes Feb 18, 2025

View reviewed changes

dougiesquire force-pushed the 209-dev-1deg_jra55do_iaf branch from 07ff320 to 9ebbf2e Compare February 18, 2025 23:33

Updated checksums as part of https://github.com/ACCESS-NRI/access-om3…

0859d8d

…-configs/actions/runs/13403967450

dougiesquire merged commit 23ca28d into dev-1deg_jra55do_iaf Feb 19, 2025
10 checks passed

dougiesquire deleted the 209-dev-1deg_jra55do_iaf branch February 19, 2025 02:19

Comments

Conversation

anton-seaice commented Feb 7, 2025

Uh oh!

anton-seaice commented Feb 7, 2025

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

dougiesquire commented Feb 11, 2025

Uh oh!

dougiesquire commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

dougiesquire left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anton-seaice commented Feb 18, 2025

Uh oh!

anton-seaice commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

dougiesquire commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minghangli-uni left a comment

Choose a reason for hiding this comment

Uh oh!

minghangli-uni commented Feb 18, 2025

Uh oh!

minghangli-uni commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

dougiesquire commented Feb 18, 2025

Uh oh!

dougiesquire commented Feb 18, 2025

Uh oh!

aekiss commented Feb 18, 2025

Uh oh!

dougiesquire commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anton-seaice commented Feb 18, 2025

Uh oh!

dougiesquire commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dougiesquire commented Feb 11, 2025 •

edited

Loading

dougiesquire left a comment •

edited

Loading

dougiesquire commented Feb 18, 2025 •

edited

Loading

dougiesquire commented Feb 18, 2025 •

edited

Loading