Refactor and simplify how private/public keys are tweaked for taproot spends #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spends - We should not expose a Script.pay2tr() methods that sends to a raw untweaked key. It's confusing and users should never need it anyway. - SchnorrTweak.NoTweak was not needed, it is simpler to just use an optional tweak when signing with the private key
sstone
force-pushed
the
refactor_p2tr_tweaks
branch
from
c7ded30 to
d817d31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script.pay2tr()methods that sends to a raw untweaked key. It's confusing and users should never need it anyway.SchnorrTweak.NoTweakwas not needed, it is simpler to just use an optional tweak when signing with the private key