Use text instead of blobs for Sqlite closed_channels table

We're using blobs for the `local_channels` table for backwards-compat
and performance reasons, but it's easier to use text for the new
`closed_channels` table to perform analysis on past data.

Author: t-bast

eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqliteChannelsDb.scala

@@ -64,7 +64,7 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
     statement.executeUpdate("CREATE INDEX htlc_infos_channel_id_idx ON htlc_infos(channel_id)")
     statement.executeUpdate("CREATE INDEX htlc_infos_commitment_number_idx ON htlc_infos(commitment_number)")
     // We can now move closed channels to a dedicated table.
-    statement.executeUpdate("CREATE TABLE closed_channels (channel_id BLOB NOT NULL PRIMARY KEY, remote_node_id BLOB NOT NULL, funding_txid BLOB NOT NULL, funding_output_index INTEGER NOT NULL, funding_tx_index INTEGER NOT NULL, funding_key_path TEXT NOT NULL, channel_features TEXT NOT NULL, is_channel_opener BOOLEAN NOT NULL, commitment_format TEXT NOT NULL, announced BOOLEAN NOT NULL, capacity_satoshis INTEGER NOT NULL, closing_txid BLOB NOT NULL, closing_type TEXT NOT NULL, closing_script BLOB NOT NULL, local_balance_msat INTEGER NOT NULL, remote_balance_msat INTEGER NOT NULL, closing_amount_satoshis INTEGER NOT NULL, created_at INTEGER NOT NULL, closed_at INTEGER NOT NULL)")
+    statement.executeUpdate("CREATE TABLE closed_channels (channel_id TEXT NOT NULL PRIMARY KEY, remote_node_id TEXT NOT NULL, funding_txid TEXT NOT NULL, funding_output_index INTEGER NOT NULL, funding_tx_index INTEGER NOT NULL, funding_key_path TEXT NOT NULL, channel_features TEXT NOT NULL, is_channel_opener BOOLEAN NOT NULL, commitment_format TEXT NOT NULL, announced BOOLEAN NOT NULL, capacity_satoshis INTEGER NOT NULL, closing_txid TEXT NOT NULL, closing_type TEXT NOT NULL, closing_script TEXT NOT NULL, local_balance_msat INTEGER NOT NULL, remote_balance_msat INTEGER NOT NULL, closing_amount_satoshis INTEGER NOT NULL, created_at INTEGER NOT NULL, closed_at INTEGER NOT NULL)")
     statement.executeUpdate("CREATE INDEX closed_channels_remote_node_id_idx ON closed_channels(remote_node_id)")
     // We migrate closed channels from the local_channels table to the new closed_channels table, whenever possible.
     val insertStatement = sqlite.prepareStatement("INSERT INTO closed_channels VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)")
@@ -97,9 +97,9 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
         }
         data_opt match {
           case Some(data) =>
-            insertStatement.setBytes(1, channelId.toArray)
-            insertStatement.setBytes(2, data.remoteNodeId.value.toArray)
-            insertStatement.setBytes(3, data.fundingTxId.value.toArray)
+            insertStatement.setString(1, channelId.toHex)
+            insertStatement.setString(2, data.remoteNodeId.toHex)
+            insertStatement.setString(3, data.fundingTxId.value.toHex)
             insertStatement.setLong(4, data.fundingOutputIndex)
             insertStatement.setLong(5, data.fundingTxIndex)
             insertStatement.setString(6, data.fundingKeyPath)
@@ -108,9 +108,9 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
             insertStatement.setString(9, data.commitmentFormat)
             insertStatement.setBoolean(10, data.announced)
             insertStatement.setLong(11, data.capacity.toLong)
-            insertStatement.setBytes(12, data.closingTxId.value.toArray)
+            insertStatement.setString(12, data.closingTxId.value.toHex)
             insertStatement.setString(13, data.closingType)
-            insertStatement.setBytes(14, data.closingScript.toArray)
+            insertStatement.setString(14, data.closingScript.toHex)
             insertStatement.setLong(15, data.localBalance.toLong)
             insertStatement.setLong(16, data.remoteBalance.toLong)
             insertStatement.setLong(17, data.closingAmount.toLong)
@@ -138,7 +138,7 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
     getVersion(statement, DB_NAME) match {
       case None =>
         statement.executeUpdate("CREATE TABLE local_channels (channel_id BLOB NOT NULL PRIMARY KEY, data BLOB NOT NULL, created_timestamp INTEGER, last_payment_sent_timestamp INTEGER, last_payment_received_timestamp INTEGER, last_connected_timestamp INTEGER)")
-        statement.executeUpdate("CREATE TABLE closed_channels (channel_id BLOB NOT NULL PRIMARY KEY, remote_node_id BLOB NOT NULL, funding_txid BLOB NOT NULL, funding_output_index INTEGER NOT NULL, funding_tx_index INTEGER NOT NULL, funding_key_path TEXT NOT NULL, channel_features TEXT NOT NULL, is_channel_opener BOOLEAN NOT NULL, commitment_format TEXT NOT NULL, announced BOOLEAN NOT NULL, capacity_satoshis INTEGER NOT NULL, closing_txid BLOB NOT NULL, closing_type TEXT NOT NULL, closing_script BLOB NOT NULL, local_balance_msat INTEGER NOT NULL, remote_balance_msat INTEGER NOT NULL, closing_amount_satoshis INTEGER NOT NULL, created_at INTEGER NOT NULL, closed_at INTEGER NOT NULL)")
+        statement.executeUpdate("CREATE TABLE closed_channels (channel_id TEXT NOT NULL PRIMARY KEY, remote_node_id TEXT NOT NULL, funding_txid TEXT NOT NULL, funding_output_index INTEGER NOT NULL, funding_tx_index INTEGER NOT NULL, funding_key_path TEXT NOT NULL, channel_features TEXT NOT NULL, is_channel_opener BOOLEAN NOT NULL, commitment_format TEXT NOT NULL, announced BOOLEAN NOT NULL, capacity_satoshis INTEGER NOT NULL, closing_txid TEXT NOT NULL, closing_type TEXT NOT NULL, closing_script TEXT NOT NULL, local_balance_msat INTEGER NOT NULL, remote_balance_msat INTEGER NOT NULL, closing_amount_satoshis INTEGER NOT NULL, created_at INTEGER NOT NULL, closed_at INTEGER NOT NULL)")
         statement.executeUpdate("CREATE TABLE htlc_infos (channel_id BLOB NOT NULL, commitment_number INTEGER NOT NULL, payment_hash BLOB NOT NULL, cltv_expiry INTEGER NOT NULL)")
         statement.executeUpdate("CREATE TABLE htlc_infos_to_remove (channel_id BLOB NOT NULL PRIMARY KEY, before_commitment_number INTEGER NOT NULL)")
         // Note that we use two distinct indices instead of a composite index on (channel_id, commitment_number).
@@ -218,9 +218,9 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
         statement.executeQuery().flatMap(rs => rs.getLongNullable("created_timestamp")).headOption
       }
       using(sqlite.prepareStatement("INSERT OR IGNORE INTO closed_channels VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)")) { statement =>
-        statement.setBytes(1, channelId.toArray)
-        statement.setBytes(2, data.remoteNodeId.value.toArray)
-        statement.setBytes(3, data.fundingTxId.value.toArray)
+        statement.setString(1, channelId.toHex)
+        statement.setString(2, data.remoteNodeId.toHex)
+        statement.setString(3, data.fundingTxId.value.toHex)
         statement.setLong(4, data.fundingOutputIndex)
         statement.setLong(5, data.fundingTxIndex)
         statement.setString(6, data.fundingKeyPath)
@@ -229,9 +229,9 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
         statement.setString(9, data.commitmentFormat)
         statement.setBoolean(10, data.announced)
         statement.setLong(11, data.capacity.toLong)
-        statement.setBytes(12, data.closingTxId.value.toArray)
+        statement.setString(12, data.closingTxId.value.toHex)
         statement.setString(13, data.closingType)
-        statement.setBytes(14, data.closingScript.toArray)
+        statement.setString(14, data.closingScript.toHex)
         statement.setLong(15, data.localBalance.toLong)
         statement.setLong(16, data.remoteBalance.toLong)
         statement.setLong(17, data.closingAmount.toLong)
@@ -303,12 +303,12 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
       case None => "SELECT * FROM closed_channels ORDER BY closed_at DESC"
     }
     using(sqlite.prepareStatement(limited(sql, paginated_opt))) { statement =>
-      remoteNodeId_opt.foreach(remoteNodeId => statement.setBytes(1, remoteNodeId.value.toArray))
+      remoteNodeId_opt.foreach(remoteNodeId => statement.setString(1, remoteNodeId.toHex))
       statement.executeQuery().map { rs =>
         DATA_CLOSED(
-          channelId = rs.getByteVector32("channel_id"),
-          remoteNodeId = PublicKey(rs.getByteVector("remote_node_id")),
-          fundingTxId = TxId(rs.getByteVector32("funding_txid")),
+          channelId = rs.getByteVector32FromHex("channel_id"),
+          remoteNodeId = PublicKey(rs.getByteVectorFromHex("remote_node_id")),
+          fundingTxId = TxId(rs.getByteVector32FromHex("funding_txid")),
           fundingOutputIndex = rs.getLong("funding_output_index"),
           fundingTxIndex = rs.getLong("funding_tx_index"),
           fundingKeyPath = rs.getString("funding_key_path"),
@@ -317,9 +317,9 @@ class SqliteChannelsDb(val sqlite: Connection) extends ChannelsDb with Logging {
           commitmentFormat = rs.getString("commitment_format"),
           announced = rs.getBoolean("announced"),
           capacity = Satoshi(rs.getLong("capacity_satoshis")),
-          closingTxId = TxId(rs.getByteVector32("closing_txid")),
+          closingTxId = TxId(rs.getByteVector32FromHex("closing_txid")),
           closingType = rs.getString("closing_type"),
-          closingScript = rs.getByteVector("closing_script"),
+          closingScript = rs.getByteVectorFromHex("closing_script"),
           localBalance = MilliSatoshi(rs.getLong("local_balance_msat")),
           remoteBalance = MilliSatoshi(rs.getLong("remote_balance_msat")),
           closingAmount = Satoshi(rs.getLong("closing_amount_satoshis"))