Merge pull request #210 from AFASSoftware/on-not-on-dom

do not store on on real DOM, may cause memory problems

Author: johan-gorter

package-lock.json

@@ -154,6 +154,7 @@ let nodeToRemove = (vNode: VNode) => {
 };
 
 const vnodeOnlyProps = [
+  "on",
   "afterCreate",
   "afterUpdate",
   "afterRemoved",
@@ -206,22 +207,6 @@ let setProperties = (
           projectionOptions.styleApplyer!(<HTMLElement>domNode, styleName, styleValue);
         }
       }
-    } else if (propName === "on" && propValue) {
-      // object with string keys and function values
-      for (let [key, handler] of Object.entries(properties.on!)) {
-        let listener: EventHandler | undefined =
-          typeof handler === "function" ? handler : handler.listener;
-        if (eventHandlerInterceptor) {
-          listener = eventHandlerInterceptor(key, listener, domNode, properties);
-        }
-        if (listener) {
-          domNode.addEventListener(
-            key,
-            listener,
-            typeof handler === "function" ? undefined : handler.options
-          );
-        }
-      }
     } else if (propName !== "key" && propValue !== null && propValue !== undefined) {
       let type = typeof propValue;
       if (type === "function") {
@@ -246,6 +231,23 @@ let setProperties = (
       }
     }
   }
+  if (properties.on) {
+    // object with string keys and function values
+    for (let [key, handler] of Object.entries(properties.on)) {
+      let listener: EventHandler | undefined =
+        typeof handler === "function" ? handler : handler.listener;
+      if (eventHandlerInterceptor) {
+        listener = eventHandlerInterceptor(key, listener, domNode, properties);
+      }
+      if (listener) {
+        domNode.addEventListener(
+          key,
+          listener,
+          typeof handler === "function" ? undefined : handler.options
+        );
+      }
+    }
+  }
 };
 
 let addChildren = (