Skip to content

Commit 2e70f05

Browse files
committed
Merge commit '15e2eff' into Develop
2 parents 0e14a02 + 15e2eff commit 2e70f05

File tree

4 files changed

+20
-27
lines changed

4 files changed

+20
-27
lines changed

Ares.Device.Serial.Tests/SerialPortTests.cs

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public async Task AresSerialPort_TestingCorruptionProneDevices(CancellationToken
238238
var response1 = await port.Send(new SomeCommandWithResponse(stringToTest1), TimeSpan.FromMilliseconds(100), token);
239239
}
240240
catch(TimeoutException)
241-
{}
241+
{ }
242242
var response2 = await port.Send(new SomeCommandWithResponse(stringToTest2), TimeSpan.FromSeconds(10), token);
243243
Assert.That(response2.Response, Is.EqualTo(stringToTest2));
244244
}
@@ -250,31 +250,24 @@ public async Task AresSerialPort_Subscription_To_Response_Stream_Works_Without_S
250250
const string stringToTest = "<-Oh Hello->";
251251
const string stringToTest2 = "<-This Is A Test->";
252252
var port = new TestConnectionWithDelay(new SerialPortConnectionInfo(0, Parity.Even, 0, StopBits.None));
253-
var test1Observable = port.GetTransactionStream<SomeResponse>();
254-
var test2Observable = port.GetTransactionStream<SomeResponse>();
255-
var test1ObservableResponseWaiter = Task.Run(async () =>
256-
{
257-
var test1ObservableSecondResponse = await test1Observable.Take(1).ToTask(token);
258-
return test1ObservableSecondResponse;
259-
}, token);
253+
var firstObservable = port.GetTransactionStream<SomeResponse>();
254+
var secondObservable = port.GetTransactionStream<SomeResponse>();
260255

261-
_ = port.SendAndStream(new SomeCommandWithStreamedResponse(stringToTest2), token);
256+
var firstWaiter = firstObservable.Take(1).ToTask(token);
257+
var secondWaiter = secondObservable.Take(1).ToTask(token);
262258

263-
var test2ObservableFirstResponse = await test2Observable.Take(1).ToTask(token);
264-
var test1ObservableSecondResponse = await test1ObservableResponseWaiter;
265-
var test1ObservableResponseWaiter2 = Task.Run(async () =>
266-
{
267-
var test1ObservableSecondResponse2 = await test1Observable.Take(1).ToTask(token);
268-
return test1ObservableSecondResponse2;
269-
}, token);
259+
_ = port.SendAndStream(new SomeCommandWithStreamedResponse(stringToTest2), token);
270260

271-
var test3Task = await port.Send(new SomeCommandWithResponse(stringToTest), token);
272-
var test1ObservableSecondResponse2 = await test1ObservableResponseWaiter2;
261+
var secondObservableFirstResponse = await secondWaiter;
262+
var firstObservableSecondResponse = await firstWaiter;
263+
var firstObservableResponseWaiter2 = firstObservable.Take(1).ToTask(token);
264+
_ = await port.Send(new SomeCommandWithResponse(stringToTest), token);
265+
var firstObservableSecondResponse2 = await firstObservableResponseWaiter2;
273266
using(Assert.EnterMultipleScope())
274267
{
275-
Assert.That(test1ObservableSecondResponse2.Response.Response, Is.EqualTo(stringToTest));
276-
Assert.That(test2ObservableFirstResponse.Response.Response, Is.EqualTo(stringToTest2));
277-
Assert.That(test1ObservableSecondResponse.Response.Response, Is.EqualTo(stringToTest2));
268+
Assert.That(firstObservableSecondResponse2.Response.Response, Is.EqualTo(stringToTest));
269+
Assert.That(secondObservableFirstResponse.Response.Response, Is.EqualTo(stringToTest2));
270+
Assert.That(firstObservableSecondResponse.Response.Response, Is.EqualTo(stringToTest2));
278271
}
279272

280273
Assert.That(port.BufferEmpty, Is.True);
@@ -431,7 +424,7 @@ public override void SendInternally(byte[] bytes)
431424

432425
public class TestCorruptableConnection : AresSerialSimConnection
433426
{
434-
public TestCorruptableConnection(SerialPortConnectionInfo connectionInfo) : base(connectionInfo, "SIM1", new SerialConnectionOptions() { DataReceiveInterval = TimeSpan.FromMilliseconds(150)})
427+
public TestCorruptableConnection(SerialPortConnectionInfo connectionInfo) : base(connectionInfo, "SIM1", new SerialConnectionOptions() { DataReceiveInterval = TimeSpan.FromMilliseconds(150) })
435428
{
436429
}
437430

@@ -445,7 +438,8 @@ public override void SendInternally(byte[] bytes)
445438
// return;
446439
// }
447440
Console.WriteLine($"Got something: {Encoding.ASCII.GetString(bytes)}");
448-
Task.Run(async () => {
441+
Task.Run(async () =>
442+
{
449443
foreach(var b in bytes)
450444
{
451445
AddDataReceived([b]);

AresScript.Tests/AresScript.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
<TargetFramework>net10.0</TargetFramework>
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
7-
<RootNamespace>ARESScript.Tests</RootNamespace>
7+
<RootNamespace>AresScript.Tests</RootNamespace>
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<ProjectReference Include="..\ARESScript\ARESScript.csproj" />
11+
<ProjectReference Include="..\AresScript\AresScript.csproj" />
1212
</ItemGroup>
1313

1414
<ItemGroup>

AresScript.Tests/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System.Diagnostics;
22
using Antlr4.Runtime;
3-
using Ares.Datamodel.Extensions;
43
using AresScript.Generated;
54
using NUnit.Framework;
65

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ARES OS 2.0: Autonomous Research Software
2-
The next generation of autonomous research software, serving as the central hub for integrating devices, planners, and analyzers for self-directed scientific campaigns.
2+
The next generation of autonomous research software, serving as the central hub for integrating devices, planners, and analyzers for self-directed scientific campaigns. This is our general research software, if you're interested in specifically our 3-D printer software, please visit the [Educational ARES Repo](https://github.com/AFRL-ARES/Educational-ARES).
33

44
## 🎛️ Overview
55
**ARES OS 2.0** acts as the core central hub that connects and coordinates components such as devices, planners, and analyzers into cohesive research campaigns. Built on a modular, distributed architecture, ARES provides the framework for defining complex, multi-step experiments and managing all connected systems from a unified dashboard.

0 commit comments

Comments
 (0)