Skip to content

Commit a3121a6

Browse files
committed
Merge branch 'Develop' of https://github.com/AFRL-ARES/ARES into Develop
# Conflicts: # AlicatMFC/AlicatMFC.csproj # FlirCM3/FlirCM3.csproj # HerkulexDRS/HerkulexDRS.csproj # LaserChiller/LaserChiller.csproj # LindbergFurnace/LindbergFurnace.csproj # PrusaMK4S/PrusaMK4S.csproj # RestSerialDevice/RestSerialDevice.csproj # SyringePumpNE1000/SyringePumpNE1000.csproj # TC0304/TC0304.csproj # TicStepperController/TicStepperController.csproj # ValveController/ValveController.csproj
2 parents 2da9f06 + 303928d commit a3121a6

File tree

27 files changed

+62
-52
lines changed

27 files changed

+62
-52
lines changed

Ares.Core.Tests/AnalyzerManagerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ public TempAnalyzer(string name, string version) : base(name, "TempAnalyzer", ve
2424
{
2525
}
2626

27-
public override Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken)
27+
public override Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken)
2828
{
2929
throw new NotImplementedException();
3030
}
3131

32-
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, CancellationToken cancellationToken)
32+
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, RequestMetadata metadata, CancellationToken cancellationToken)
3333
{
3434
throw new NotImplementedException();
3535
}

Ares.Core.Tests/Ares.Core.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</PropertyGroup>
1010

1111
<ItemGroup>
12-
<PackageReference Include="Grpc.Tools" Version="2.72.0">
12+
<PackageReference Include="Grpc.Tools" Version="2.76.0">
1313
<PrivateAssets>all</PrivateAssets>
1414
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1515
</PackageReference>
@@ -18,7 +18,7 @@
1818
<PackageReference Include="Moq" Version="4.20.72" />
1919
<PackageReference Include="NUnit" Version="4.4.0" />
2020
<PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
21-
<PackageReference Include="NUnit.Analyzers" Version="4.10.0">
21+
<PackageReference Include="NUnit.Analyzers" Version="4.11.2">
2222
<PrivateAssets>all</PrivateAssets>
2323
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2424
</PackageReference>

Ares.Core.Tests/Data/Analyzer/TestReplyAnalyzer.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ public TestReplyAnalyzer() : base("Test Analyzer", "TestAnalyzer", "1.0")
1010
{
1111
}
1212

13-
public override Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken)
13+
public override Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken)
1414
{
1515
var firstData = inputs.Fields["TestAnalyzerInput"];
1616
var analysis = new Analysis() { Result = (float)firstData.NumberValue, AnalysisOutcome = Outcome.Success };
1717

1818
return Task.FromResult(analysis);
1919
}
2020

21-
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, CancellationToken cancellationToken)
21+
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, RequestMetadata metadata, CancellationToken cancellationToken)
2222
{
23-
return Analyze(inputs, cancellationToken);
23+
return Analyze(inputs, metadata, cancellationToken);
2424
}
2525

2626
public override Task<AnalyzerCapabilities> GetCapabilities(CancellationToken cancellationToken)

Ares.Core.Tests/ManualPlannerTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public async Task CorrectNumberOfResults_FileLines()
5555
plannerSeed.FileLines = new ManualPlannerFileLines();
5656
plannerSeed.FileLines.PlannerValues.AddRange(_fileLines);
5757
await _manualPlanner.Seed(plannerSeed);
58-
var planResponse = await _manualPlanner.Plan(_parameterMetadatas, string.Empty, Array.Empty<ExperimentOverview>(), Array.Empty<Analysis>(), CancellationToken.None);
58+
var planResponse = await _manualPlanner.Plan(_parameterMetadatas, new RequestMetadata(), Array.Empty<ExperimentOverview>(), Array.Empty<Analysis>(), CancellationToken.None);
5959
Assert.That(planResponse.Results, Has.Exactly(3).Items);
6060
}
6161
}

Ares.Core/Analyzing/AnalysisHelper.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public AnalysisHelper(IAnalyzerRepo analyzerRepo)
1616
_analyzerRepo = analyzerRepo;
1717
}
1818

19-
public async Task<Analysis> Analyze(ExperimentTemplate template, ExperimentExecutionSummary experimentSummary, CancellationToken cancellationToken)
19+
public async Task<Analysis> Analyze(ExperimentTemplate template, ExperimentExecutionSummary experimentSummary, RequestMetadata metadata, CancellationToken cancellationToken)
2020
{
2121
var analyzer = GetAnalyzer(template.AnalyzerId);
2222
var analyzerInputs = ExperimentOutputToAnalyzerInputs(
@@ -25,7 +25,7 @@ public async Task<Analysis> Analyze(ExperimentTemplate template, ExperimentExecu
2525
try
2626
{
2727
// TODO: Maybe add support for settings overrides if needed
28-
var analysis = await analyzer.Analyze(analyzerInputs, cancellationToken);
28+
var analysis = await analyzer.Analyze(analyzerInputs, metadata, cancellationToken);
2929
experimentSummary.ExperimentOverview.AnalysisOverview = new AnalysisOverview
3030
{
3131
UniqueId = Guid.NewGuid().ToString(),

Ares.Core/Analyzing/AnalyzerBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ public void UpdateSettings(AresStruct settings)
6969
}
7070
}
7171

72-
public abstract Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken);
72+
public abstract Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken);
7373

74-
public abstract Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, CancellationToken cancellationToken);
74+
public abstract Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, RequestMetadata metadata, CancellationToken cancellationToken);
7575

7676
public abstract Task<AresDataSchema> GetParameters(CancellationToken cancellationToken);
7777

Ares.Core/Analyzing/IAnalyzer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,15 @@ public interface IAnalyzer
100100
/// <param name="cancellationToken"></param>
101101
/// <param name="settings">Optional list of settings to influence the analysis</param>
102102
/// <returns><see cref="Analysis" /> which is the outcome of the analysis performed.</returns>
103-
Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, CancellationToken cancellationToken = default);
103+
Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, RequestMetadata metadata, CancellationToken cancellationToken = default);
104104

105105
/// <summary>
106106
/// Does the actual analysis work.
107107
/// </summary>
108108
/// <param name="inputs">The experiment outputs to analyze in the form of the <see cref="AnalysisInput" /> proto message</param>
109109
/// <param name="cancellationToken"></param>
110110
/// <returns><see cref="Analysis" /> which is the outcome of the analysis performed.</returns>
111-
Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken);
111+
Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken);
112112

113113
/// <summary>
114114
/// How long do we expect the analyzer to do its analysis before ARES decides that analyzing has failed.

Ares.Core/Analyzing/NoneAnalyzer.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public NoneAnalyzer() : base("NONE", "NONE :)", "1.0.0")
1818
AnalyzerState = State.Active;
1919
}
2020

21-
public override Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken)
21+
public override Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken)
2222
{
2323
var analysis = new Analysis
2424
{
@@ -29,9 +29,9 @@ public override Task<Analysis> Analyze(AresStruct inputs, CancellationToken canc
2929
return Task.FromResult(analysis);
3030
}
3131

32-
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct _settings, CancellationToken cancellationToken)
32+
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct _settings, RequestMetadata metadata, CancellationToken cancellationToken)
3333
{
34-
return Analyze(inputs, cancellationToken);
34+
return Analyze(inputs, metadata, cancellationToken);
3535
}
3636

3737
public override Task<AnalyzerCapabilities> GetCapabilities(CancellationToken cancellationToken)

Ares.Core/Analyzing/RemoteAnalyzer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public RemoteAnalyzer(string name, Uri address) : base(name, "", "_._._")
2929

3030
public Uri Address { get; }
3131

32-
public override async Task<Analysis> Analyze(AresStruct inputs, CancellationToken cancellationToken = default)
32+
public override async Task<Analysis> Analyze(AresStruct inputs, RequestMetadata metadata, CancellationToken cancellationToken = default)
3333
{
3434
var client = GetClient();
3535
var analysisRequest = new AnalysisRequest
@@ -50,7 +50,7 @@ public override async Task<Analysis> Analyze(AresStruct inputs, CancellationToke
5050
/// <param name="settings">These will add-to/override existing settings values if provided. </param>
5151
/// <param name="cancellationToken"></param>
5252
/// <returns></returns>
53-
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, CancellationToken cancellationToken = default)
53+
public override Task<Analysis> Analyze(AresStruct inputs, AresStruct settings, RequestMetadata metadata, CancellationToken cancellationToken = default)
5454
{
5555
var client = GetClient();
5656
var mergedSettings = Settings.AppendStruct(settings);

Ares.Core/Ares.Core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020
<ItemGroup>
21-
<PackageReference Include="ARES.Datamodel" Version="0.14.1-beta.1" />
21+
<PackageReference Include="ARES.Datamodel" Version="0.15.1-beta.1" />
2222
<PackageReference Include="CsvHelper" Version="33.1.0" />
2323
<PackageReference Include="DynamicData" Version="9.4.1" />
2424
<PackageReference Include="Grpc.Net.Client" Version="2.71.0" />

0 commit comments

Comments
 (0)