clean syntax backslashes completely from dict queries

Author: simrankaurb

Ironwood/src/benchmark_hbm.py

@@ -89,52 +89,24 @@ def single_device_hbm_copy_calculate_metrics(
     )
     print(
         f"Tensor size: {tensor_size_bytes / 1024**2} MB, "
-        f'time taken (min): {time_statistics.statistics["min"]:.4f} ms, '
-        f'time taken (p05): {time_statistics.statistics["p05"]:.4f} ms, '
-        f'time taken (p10): {time_statistics.statistics["p10"]:.4f} ms, '
-        f'time taken (p15): {time_statistics.statistics["p15"]:.4f} ms, '
-        f'time taken (median): {time_statistics.statistics["p50"]:.4f} ms, '
-        f'time taken (avg): {time_statistics.statistics["avg"]:.4f} ms, '
-        f'time taken (p90): {time_statistics.statistics["p90"]:.4f} ms, '
-        f'time taken (p95): {time_statistics.statistics["p95"]:.4f} ms, '
-        f'time taken (p99): {time_statistics.statistics["p99"]:.4f} ms, '
-        f'time taken (max): {time_statistics.statistics["max"]:.4f} ms, '
-        f'bandwidth (min): {statistics.statistics["min"]:.3f} GB/s, '
-        f'bandwidth (p05): {statistics.statistics["p05"]:.3f} GB/s, '
-        f'bandwidth (p10): {statistics.statistics["p10"]:.3f} GB/s, '
-        f'bandwidth (p15): {statistics.statistics["p15"]:.3f} GB/s, '
-        f'bandwidth (median): {statistics.statistics["p50"]:.3f} GB/s, '
-        f'bandwidth (avg): {statistics.statistics["avg"]:.3f} GB/s, '
-        f'bandwidth (p90): {statistics.statistics["p90"]:.3f} GB/s, '
-        f'bandwidth (p95): {statistics.statistics["p95"]:.3f} GB/s, '
-        f'bandwidth (p99): {statistics.statistics["p99"]:.3f} GB/s, '
-        f'bandwidth (max): {statistics.statistics["max"]:.3f} GB/s'
+        f"time taken (p10): {time_statistics.statistics['p10']:.4f} ms, "
+        f"time taken (median): {time_statistics.statistics['p50']:.4f} ms, "
+        f"time taken (p90): {time_statistics.statistics['p90']:.4f} ms, "
+        f"bandwidth (p10): {statistics.statistics['p10']:.3f} GB/s, "
+        f"bandwidth (median): {statistics.statistics['p50']:.3f} GB/s, "
+        f"bandwidth (p90): {statistics.statistics['p90']:.3f} GB/s, "
     )
     print()
     # Gather the metrics to report.
     metadata.update(
         {
             "tensor_size_gbytes": tensor_size_gbytes,
-            "time_taken(min,ms)": time_statistics.statistics["min"],
-            "time_taken(p05,ms)": time_statistics.statistics["p05"],
             "time_taken(p10,ms)": time_statistics.statistics["p10"],
-            "time_taken(p15,ms)": time_statistics.statistics["p15"],
             "time_taken(median,ms)": time_statistics.statistics["p50"],
-            "time_taken(avg,ms)": time_statistics.statistics["avg"],
             "time_taken(p90,ms)": time_statistics.statistics["p90"],
-            "time_taken(p95,ms)": time_statistics.statistics["p95"],
-            "time_taken(p99,ms)": time_statistics.statistics["p99"],
-            "time_taken(max,ms)": time_statistics.statistics["max"],
-            "bandwidth(min,GB/s)": statistics.statistics["min"],
-            "bandwidth(p05,GB/s)": statistics.statistics["p05"],
             "bandwidth(p10,GB/s)": statistics.statistics["p10"],
-            "bandwidth(p15,GB/s)": statistics.statistics["p15"],
             "bandwidth(median,GB/s)": statistics.statistics["p50"],
-            "bandwidth(avg,GB/s)": statistics.statistics["avg"],
             "bandwidth(p90,GB/s)": statistics.statistics["p90"],
-            "bandwidth(p95,GB/s)": statistics.statistics["p95"],
-            "bandwidth(p99,GB/s)": statistics.statistics["p99"],
-            "bandwidth(max,GB/s)": statistics.statistics["max"],
         }
     )
     metrics.update(time_statistics.serialize_statistics())

Ironwood/src/benchmark_utils.py

@@ -858,13 +858,9 @@ def _calculate_statistics(self) -> Dict[str, float]:
         if not self.metrics_list:
             return {}  # Return an empty dict if metrics_list is empty
         return {
-            "p05": np.percentile(self.metrics_list, 5),
             "p10": np.percentile(self.metrics_list, 10),
-            "p15": np.percentile(self.metrics_list, 15),
             "p50": np.percentile(self.metrics_list, 50),
             "p90": np.percentile(self.metrics_list, 90),
-            "p95": np.percentile(self.metrics_list, 95),
-            "p99": np.percentile(self.metrics_list, 99),
             "avg": np.mean(self.metrics_list),
             "max": np.max(self.metrics_list),
             "num_runs": len(self.metrics_list),
@@ -1292,184 +1288,79 @@ def unified_flops_metrics(
     print(
         f"{dtype_prefix}"
         f"Total floating-point ops: {total_flops}, "
-        f"Step Time (min): "
-        f'{average_time_ms_statistics.statistics["min"]:.2f}, '
-        f"Step Time (p05): "
-        f'{average_time_ms_statistics.statistics["p05"]:.2f}, '
         f"Step Time (p10): "
-        f'{average_time_ms_statistics.statistics["p10"]:.2f}, '
-        f"Step Time (p15): "
-        f'{average_time_ms_statistics.statistics["p15"]:.2f}, '
+        f"{average_time_ms_statistics.statistics['p10']:.2f}, "
         f"Step Time (median): "
-        f'{average_time_ms_statistics.statistics["p50"]:.2f}, '
-        f"Step Time (avg): "
-        f'{average_time_ms_statistics.statistics["avg"]:.2f}, '
+        f"{average_time_ms_statistics.statistics['p50']:.2f}, "
         f"Step Time (p90): "
-        f'{average_time_ms_statistics.statistics["p90"]:.2f}, '
-        f"Step Time (p95): "
-        f'{average_time_ms_statistics.statistics["p95"]:.2f}, '
-        f"Step Time (p99): "
-        f'{average_time_ms_statistics.statistics["p99"]:.2f}, '
-        f"Step Time (max): "
-        f'{average_time_ms_statistics.statistics["max"]:.2f}, '
-        f"Throughput (min): "
-        f'{tflops_per_sec_statistics.statistics["min"]:.2f} '
+        f"{average_time_ms_statistics.statistics['p90']:.2f}, "
         f"TFLOP / second / device, "
-        f"Throughput (p05): "
-        f'{tflops_per_sec_statistics.statistics["p05"]:.2f} '
         f"TFLOP / second / device, "
         f"Throughput (p10): "
-        f'{tflops_per_sec_statistics.statistics["p10"]:.2f} '
+        f"{tflops_per_sec_statistics.statistics['p10']:.2f} "
         f"TFLOP / second / device, "
-        f"Throughput (p15): "
-        f'{tflops_per_sec_statistics.statistics["p15"]:.2f} '
         f"TFLOP / second / device, "
         f"Throughput (median): "
-        f'{tflops_per_sec_statistics.statistics["p50"]:.2f} '
+        f"{tflops_per_sec_statistics.statistics['p50']:.2f} "
         f"TFLOP / second / device, "
-        f"Throughput (avg): "
-        f'{tflops_per_sec_statistics.statistics["avg"]:.2f} '
         f"TFLOP / second / device, "
         f"Throughput (p90): "
-        f'{tflops_per_sec_statistics.statistics["p90"]:.2f} '
+        f"{tflops_per_sec_statistics.statistics['p90']:.2f} "
         f"TFLOP / second / device, "
-        f"Throughput (p95): "
-        f'{tflops_per_sec_statistics.statistics["p95"]:.2f} '
         f"TFLOP / second / device, "
-        f"Throughput (p99): "
-        f'{tflops_per_sec_statistics.statistics["p99"]:.2f} '
         f"TFLOP / second / device, "
-        f"Throughput (max): "
-        f'{tflops_per_sec_statistics.statistics["max"]:.2f} '
         f"TFLOP / second / device, "
-        f"TotalThroughput (min): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["min"]:.2f} '
         f"TFLOP / second, "
-        f"TotalThroughput (p05): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p05"]:.2f} '
         f"TFLOP / second, "
         f"TotalThroughput (p10): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p10"]:.2f} '
+        f"{tflops_per_sec_all_devices_statistics.statistics['p10']:.2f} "
         f"TFLOP / second, "
-        f"TotalThroughput (p15): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p15"]:.2f} '
         f"TFLOP / second, "
         f"TotalThroughput (median): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p50"]:.2f} '
+        f"{tflops_per_sec_all_devices_statistics.statistics['p50']:.2f} "
         f"TFLOP / second, "
-        f"TotalThroughput (avg): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["avg"]:.2f} '
         f"TFLOP / second, "
         f"TotalThroughput (p90): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p90"]:.2f} '
+        f"{tflops_per_sec_all_devices_statistics.statistics['p90']:.2f} "
         f"TFLOP / second, "
-        f"TotalThroughput (p95): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p95"]:.2f} '
         f"TFLOP / second, "
-        f"TotalThroughput (p99): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["p99"]:.2f} '
         f"TFLOP / second, "
-        f"TotalThroughput (max): "
-        f'{tflops_per_sec_all_devices_statistics.statistics["max"]:.2f} '
         f"TFLOP / second, "
-        f'MFU (min): {mfu_statistics.statistics["min"]:.2%}', 
-        f'MFU (p05): {mfu_statistics.statistics["p05"]:.2%}', 
-        f'MFU (p10): {mfu_statistics.statistics["p10"]:.2%}', 
-        f'MFU (p15): {mfu_statistics.statistics["p15"]:.2%}', 
-        f'MFU (median): {mfu_statistics.statistics["p50"]:.2%}', 
-        f'MFU (avg): {mfu_statistics.statistics["avg"]:.2%}', 
-        f'MFU (p90): {mfu_statistics.statistics["p90"]:.2%}', 
-        f'MFU (p95): {mfu_statistics.statistics["p95"]:.2%}', 
-        f'MFU (p99): {mfu_statistics.statistics["p99"]:.2%}', 
-        f'MFU (max): {mfu_statistics.statistics["max"]:.2%}'
+        f"MFU (p10): {mfu_statistics.statistics['p10']:.2%}", 
+        f"MFU (median): {mfu_statistics.statistics['p50']:.2%}", 
+        f"MFU (p90): {mfu_statistics.statistics['p90']:.2%}", 
     )
 
     # Gather the metrics to report.
     metadata.update(
         {
-            "StepTime(min,ms)": average_time_ms_statistics.statistics["min"],
-            "StepTime(p05,ms)": average_time_ms_statistics.statistics["p05"],
             "StepTime(p10,ms)": average_time_ms_statistics.statistics["p10"],
-            "StepTime(p15,ms)": average_time_ms_statistics.statistics["p15"],
             "StepTime(median,ms)": average_time_ms_statistics.statistics["p50"],
-            "StepTime(avg,ms)": average_time_ms_statistics.statistics["avg"],
             "StepTime(p90,ms)": average_time_ms_statistics.statistics["p90"],
-            "StepTime(p95,ms)": average_time_ms_statistics.statistics["p95"],
-            "StepTime(p99,ms)": average_time_ms_statistics.statistics["p99"],
-            "StepTime(max,ms)": average_time_ms_statistics.statistics["max"],
-            "Throughput(min,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["min"]
-            ),
-            "Throughput(p05,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["p05"]
-            ),
             "Throughput(p10,TFLOP/s/device)": (
                 tflops_per_sec_statistics.statistics["p10"]
             ),
-            "Throughput(p15,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["p15"]
-            ),
             "Throughput(median,TFLOP/s/device)": (
                 tflops_per_sec_statistics.statistics["p50"]
             ),
-            "Throughput(avg,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["avg"]
-            ),
             "Throughput(p90,TFLOP/s/device)": (
                 tflops_per_sec_statistics.statistics["p90"]
             ),
-            "Throughput(p95,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["p95"]
-            ),
-            "Throughput(p99,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["p99"]
-            ),
-            "Throughput(max,TFLOP/s/device)": (
-                tflops_per_sec_statistics.statistics["max"]
-            ),
             "TotalThroughput(median,TFLOP/s)": (
                 tflops_per_sec_all_devices_statistics.statistics["p50"]
             ),
-            "TotalThroughput(avg,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["avg"]
-            ),
             "TotalThroughput(p90,TFLOP/s)": (
                 tflops_per_sec_all_devices_statistics.statistics["p90"]
             ),
-            "TotalThroughput(p95,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["p95"]
-            ),
-            "TotalThroughput(p99,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["p99"]
-            ),
-            "TotalThroughput(min,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["min"]
-            ),
-            "TotalThroughput(max,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["max"]
-            ),
-            "TotalThroughput(p05,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["p05"]
-            ),
             "TotalThroughput(p10,TFLOP/s)": (
                 tflops_per_sec_all_devices_statistics.statistics["p10"]
             ),
-            "TotalThroughput(p15,TFLOP/s)": (
-                tflops_per_sec_all_devices_statistics.statistics["p15"]
-            ),
             "TotalThroughput(median,TFLOP/s)": (
                 tflops_per_sec_all_devices_statistics.statistics["p50"]
             ),
-            "MFU(min)": mfu_statistics.statistics["min"],
-            "MFU(p05)": mfu_statistics.statistics["p05"],
             "MFU(p10)": mfu_statistics.statistics["p10"],
-            "MFU(p15)": mfu_statistics.statistics["p15"],
             "MFU(median)": mfu_statistics.statistics["p50"],
-            "MFU(avg)": mfu_statistics.statistics["avg"],
             "MFU(p90)": mfu_statistics.statistics["p90"],
-            "MFU(p95)": mfu_statistics.statistics["p95"],
-            "MFU(p99)": mfu_statistics.statistics["p99"],
-            "MFU(max)": mfu_statistics.statistics["max"],
             "total_flops": total_flops,
         }
     )
@@ -1534,44 +1425,23 @@ def unified_bytes_metrics(
     print(
         f"{type_prefix}"
         f"Total bytes: {total_bytes}, "
-        f"Step Time (min): {average_time_ms_statistics.statistics["min"]:.2f}, "
-        f"Step Time (p05): {average_time_ms_statistics.statistics["p05"]:.2f}, "
         f"Step Time (p10): {average_time_ms_statistics.statistics["p10"]:.2f}, "
-        f"Step Time (p15): {average_time_ms_statistics.statistics["p15"]:.2f}, "
         f"Step Time (median): {average_time_ms_statistics.statistics["p50"]:.2f}, "
-        f"Step Time (avg): {average_time_ms_statistics.statistics["avg"]:.2f}, "
         f"Step Time (p90): {average_time_ms_statistics.statistics["p90"]:.2f}, "
-        f"Step Time (p95): {average_time_ms_statistics.statistics["p95"]:.2f}, "
-        f"Step Time (p99): {average_time_ms_statistics.statistics["p99"]:.2f}, "
-        f"Step Time (max): {average_time_ms_statistics.statistics["max"]:.2f}, "
-        f"Throughput (min): {gigabytes_per_sec_statistics.statistics["min"]:.2f} GBytes / second / device, "
-        f"Throughput (p05): {gigabytes_per_sec_statistics.statistics["p05"]:.2f} GBytes / second / device, "
         f"Throughput (p10): {gigabytes_per_sec_statistics.statistics["p10"]:.2f} GBytes / second / device, "
-        f"Throughput (p15): {gigabytes_per_sec_statistics.statistics["p15"]:.2f} GBytes / second / device, "
         f"Throughput (median): {gigabytes_per_sec_statistics.statistics["p50"]:.2f} GBytes / second / device, "
-        f"Throughput (avg): {gigabytes_per_sec_statistics.statistics["avg"]:.2f} GBytes / second / device, "
         f"Throughput (p90): {gigabytes_per_sec_statistics.statistics["p90"]:.2f} GBytes / second / device, "
-        f"Throughput (p95): {gigabytes_per_sec_statistics.statistics["p95"]:.2f} GBytes / second / device, "
-        f"Throughput (p99): {gigabytes_per_sec_statistics.statistics["p99"]:.2f} GBytes / second / device, "
-        f"Throughput (max): {gigabytes_per_sec_statistics.statistics["max"]:.2f} GBytes / second / device, "
-        f"TotalThroughput (min): {gigabytes_per_sec_all_devices_statistics.statistics["min"]:.2f} GBytes / second, "
-        f"TotalThroughput (p05): {gigabytes_per_sec_all_devices_statistics.statistics["p05"]:.2f} GBytes / second, "
         f"TotalThroughput (p10): {gigabytes_per_sec_all_devices_statistics.statistics["p10"]:.2f} GBytes / second, "
-        f"TotalThroughput (p15): {gigabytes_per_sec_all_devices_statistics.statistics["p15"]:.2f} GBytes / second, "
         f"TotalThroughput (median): {gigabytes_per_sec_all_devices_statistics.statistics["p50"]:.2f} GBytes / second, "
-        f"TotalThroughput (avg): {gigabytes_per_sec_all_devices_statistics.statistics["avg"]:.2f} GBytes / second, "
         f"TotalThroughput (p90): {gigabytes_per_sec_all_devices_statistics.statistics["p90"]:.2f} GBytes / second, "
-        f"TotalThroughput (p95): {gigabytes_per_sec_all_devices_statistics.statistics["p95"]:.2f} GBytes / second, "
-        f"TotalThroughput (p99): {gigabytes_per_sec_all_devices_statistics.statistics["p99"]:.2f} GBytes / second, "
-        f"TotalThroughput (max): {gigabytes_per_sec_all_devices_statistics.statistics["max"]:.2f} GBytes / second"
     )
     print()
     metadata.update(
         {
             "total_bytes": total_bytes,
         }
     )
-    for p_name in ["min", "p05", "p10", "p15", "p50", "avg", "p90", "p95", "p99", "max"]:
+    for p_name in ["p10", "p50", "p90"]:
         metadata[f"StepTime({p_name},ms)"] = average_time_ms_statistics.statistics[p_name]
         metadata[f"Throughput({p_name},GBytes/s/device)"] = gigabytes_per_sec_statistics.statistics[p_name]
         metadata[f"TotalThroughput({p_name},GBytes/s)"] = gigabytes_per_sec_all_devices_statistics.statistics[p_name]