Skip to content

Commit 8c57202

Browse files
Merge pull request #2514 from SamuelMarks:fix-py-version-check-in-setup-sh
PiperOrigin-RevId: 820446632
2 parents b959943 + 7887afe commit 8c57202

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ fi
4949
PY_VERSION=${PY_VERSION##* }
5050
PY_VERSION=${PY_VERSION%.*}
5151
# shellcheck disable=SC2072
52-
if [ "$PYTHON_VERSION" \< '3.12' ]; then
52+
if [[ '3.12' > "$PY_VERSION" ]]; then
5353
echo -e "\n\e[31mERROR: Outdated Python Version! You are currently using ${PY_VERSION}.*, but MaxText requires Python version 3.12 or higher.\e[0m"
5454
# Ask the user if they want to create a virtual environment with uv
5555
read -p "Would you like to create a Python 3.12 virtual environment using uv? (y/n) " -n 1 -r

0 commit comments

Comments
 (0)