Use constant for the order_by field in list_entries().

Googler · copybara-github · commit 34a33c8cc818 · 2024-02-27T11:25:14.000-08:00
PiperOrigin-RevId: 610817660
diff --git a/ml_goodput_measurement/src/goodput.py b/ml_goodput_measurement/src/goodput.py
@@ -72,7 +72,7 @@ def write_cloud_logging_entry(self, entry) -> None:
 
   def read_cloud_logging_entries(self):
     return self._filter_entries_for_job(
-        self.logger.list_entries(order_by='timestamp asc')
+        self.logger.list_entries(order_by=google.cloud.logging.ASCENDING)
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ def write_cloud_logging_entry(self, entry) -> None:`
`72`	`72`
`73`	`73`	`def read_cloud_logging_entries(self):`
`74`	`74`	`return self._filter_entries_for_job(`
`75`		`- self.logger.list_entries(order_by='timestamp asc')`
	`75`	`+ self.logger.list_entries(order_by=google.cloud.logging.ASCENDING)`
`76`	`76`	`)`
`77`	`77`
`78`	`78`