Downscroll Fix

Author: AlejoGDOfficial

source/funkin/visuals/game/Note.hx

@@ -110,11 +110,9 @@ class Note extends FlxSprite
 		flipY = noteType == SUSTAIN_END && ClientPrefs.data.downScroll;
 
 		antialiasing = ClientPrefs.data.antialiasing;
-
-		animation.play('idle', true);
     }
 
-	public static function setNotePosition(note:FlxSprite, target:FlxSprite, angle:Float, offsetX:Float, offsetY:Float)
+	public static inline function setNotePosition(note:FlxSprite, target:FlxSprite, angle:Float, offsetX:Float, offsetY:Float)
 	{
 		offsetX += target.width / 2 - note.width / 2;
 
@@ -189,5 +187,7 @@ class Note extends FlxSprite
 		setMeta(data, noteType);
 
 		active = true;
+		
+		flipY = noteType == SUSTAIN_END && ClientPrefs.data.downScroll;
 	}
 }

source/funkin/visuals/game/StrumLine.hx

@@ -20,7 +20,7 @@ class StrumLine extends FlxGroup
 
     public var splashes:FlxTypedGroup<Splash>;
 
-    public var downScroll:Bool = false;
+    private var downScroll:Bool = ClientPrefs.data.downScroll;
 
     public var scrollSpeed:Float = 1;
 
@@ -51,8 +51,6 @@ class StrumLine extends FlxGroup
 
         this.character = character;
 
-        this.downScroll = ClientPrefs.data.downScroll;
-
         botplay = this.character.type != PLAYER;
 
         add(strums = new FlxTypedGroup<Strum>());
@@ -144,7 +142,7 @@ class StrumLine extends FlxGroup
         {
             var strum:Strum = strums.members[note.data];
 
-            Note.setNotePosition(note, strum, strum.direction, 0, (note.strumTime - Conductor.songPosition) * scrollSpeed * 0.45 * (ClientPrefs.data.downScroll ? -1 : 1));
+            Note.setNotePosition(note, strum, strum.direction, 0, (note.strumTime - Conductor.songPosition) * scrollSpeed * 0.45 * (downScroll ? -1 : 1));
 
             if (botplay)
             {
@@ -161,7 +159,7 @@ class StrumLine extends FlxGroup
 
             var strum:Strum = strums.members[sustain.data];
 
-            Note.setNotePosition(sustain, strum, strum.direction, 0, strum.height / 2 + (sustain.strumTime - Conductor.songPosition) * scrollSpeed * 0.45 * (ClientPrefs.data.downScroll ? -1 : 1));
+            Note.setNotePosition(sustain, strum, strum.direction, 0, (downScroll ? -1 : 1) * strum.height / 2 + (sustain.strumTime - Conductor.songPosition) * scrollSpeed * 0.45 * (downScroll ? -1 : 1));
 
             /*
             var parent = sustain.parentNote;
@@ -357,11 +355,12 @@ class StrumLine extends FlxGroup
 		{
 			result = notePool.pop();
 			result.resetNote(time, data, length, variant, type);
-			result.active = true;
 		} else {
 			result = new Note(time, data, length, variant, character.type, type);
 		}
 
+        result.updateHitbox();
+
         result.character = this.character;
 
 		return result;