Skip to content

Commit 4ad3bd0

Browse files
committed
feat(cli+titan): support split known/unknown overrides and dynamic model patch
1 parent 1295b78 commit 4ad3bd0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

examples/megatron/prepare.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def main():
191191

192192
log_info(f"BACKEND_PATH {args.backend_path}")
193193
# primus_config = PrimusParser().parse(args)
194-
primus_config = load_primus_config(args, unknown)
194+
primus_config, _ = load_primus_config(args, unknown)
195195

196196
primus_path = Path(args.primus_path).resolve()
197197
log_info(f"PRIMUS_PATH is set to: {primus_path}")

primus/modules/trainer/megatron/pre_trainer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,10 @@ def __init__(self, *args, **kwargs):
120120
kwargs["module_name"] = "pre_trainer"
121121

122122
# Explicitly reject unknown extra_args
123-
extra_args = kwargs.pop("extra_overrides", None)
123+
extra_args = kwargs.pop("extra_args", None)
124124
if extra_args:
125125
raise ValueError(
126-
f"[MegatronPretrainTrainer] Unexpected extra_overrides detected: {extra_args}. "
126+
f"[MegatronPretrainTrainer] Unexpected extra_args detected: {extra_args}. "
127127
f"Megatron backend does not support unregistered config keys."
128128
)
129129

0 commit comments

Comments
 (0)