dmaengine: sdxi: descriptor: sdxi_desc_vl_expect() tweaks

nathanlynch · nathanlynch · commit 3194067aca52 · 2026-03-13T21:53:38.000-05:00
Should be static inline...

Make the second parameter bool; it's nonsensical and a potential
source of bugs to allow callers to pass anything other than 0 or 1.

Signed-off-by: Nathan Lynch &lt;nathan.lynch@amd.com&gt;
diff --git a/drivers/dma/sdxi/descriptor.h b/drivers/dma/sdxi/descriptor.h
@@ -25,7 +25,7 @@
 int __must_check sdxi_encode_size32(u64 size, __le32 *dest);
 #endif
 
-static void sdxi_desc_vl_expect(const struct sdxi_desc *desc, u8 expected)
+static inline void sdxi_desc_vl_expect(const struct sdxi_desc *desc, bool expected)
 {
 	u8 vl = FIELD_GET(SDXI_DSC_VL, le32_to_cpu(desc->opcode));
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`int __must_check sdxi_encode_size32(u64 size, __le32 *dest);`
`26`	`26`	`#endif`
`27`	`27`
`28`		`-static void sdxi_desc_vl_expect(const struct sdxi_desc *desc, u8 expected)`
	`28`	`+static inline void sdxi_desc_vl_expect(const struct sdxi_desc *desc, bool expected)`
`29`	`29`	`{`
`30`	`30`	`u8 vl = FIELD_GET(SDXI_DSC_VL, le32_to_cpu(desc->opcode));`
`31`	`31`