@@ -108,15 +108,13 @@ prep_memcpy_intr(struct dma_chan *dma_chan, const struct sdxi_copy *params)
108108{
109109 struct sdxi_cxt * cxt = to_sdxi_dma_chan (dma_chan )-> cxt ;
110110 struct sdxi_akey_ent * akey = to_sdxi_dma_chan (dma_chan )-> akey ;
111- struct sdxi_completion * completion __free (sdxi_completion ) = NULL ;
112- struct sdxi_dma_desc * sddesc __free (kfree ) = NULL ;
113111 struct sdxi_desc * copy , * intr ;
114112
115- completion = sdxi_completion_alloc (cxt -> sdxi );
116- if (!completion )
113+ struct sdxi_completion * comp __free ( sdxi_completion ) = sdxi_completion_alloc (cxt -> sdxi );
114+ if (!comp )
117115 return NULL ;
118116
119- sddesc = kzalloc (sizeof (* sddesc ), GFP_NOWAIT );
117+ struct sdxi_dma_desc * sddesc __free ( kfree ) = kzalloc (sizeof (* sddesc ), GFP_NOWAIT );
120118 if (!sddesc )
121119 return NULL ;
122120
@@ -126,9 +124,9 @@ prep_memcpy_intr(struct dma_chan *dma_chan, const struct sdxi_copy *params)
126124 copy = sdxi_ring_resv_next (& sddesc -> resv );
127125 (void )sdxi_encode_copy (copy , params ); /* Caller checked validity. */
128126 sdxi_desc_set_fence (copy ); /* Conservatively fence every descriptor. */
129- sdxi_completion_attach (copy , completion );
127+ sdxi_completion_attach (copy , comp );
130128
131- sddesc -> completion = no_free_ptr (completion );
129+ sddesc -> completion = no_free_ptr (comp );
132130
133131 intr = sdxi_ring_resv_next (& sddesc -> resv );
134132 sdxi_encode_intr (intr , & (const struct sdxi_intr ) {
@@ -143,15 +141,13 @@ static struct sdxi_dma_desc *
143141prep_memcpy_polled (struct dma_chan * dma_chan , const struct sdxi_copy * params )
144142{
145143 struct sdxi_cxt * cxt = to_sdxi_dma_chan (dma_chan )-> cxt ;
146- struct sdxi_completion * completion __free (sdxi_completion ) = NULL ;
147- struct sdxi_dma_desc * sddesc __free (kfree ) = NULL ;
148144 struct sdxi_desc * copy ;
149145
150- completion = sdxi_completion_alloc (cxt -> sdxi );
151- if (!completion )
146+ struct sdxi_completion * comp __free ( sdxi_completion ) = sdxi_completion_alloc (cxt -> sdxi );
147+ if (!comp )
152148 return NULL ;
153149
154- sddesc = kzalloc (sizeof (* sddesc ), GFP_NOWAIT );
150+ struct sdxi_dma_desc * sddesc __free ( kfree ) = kzalloc (sizeof (* sddesc ), GFP_NOWAIT );
155151 if (!sddesc )
156152 return NULL ;
157153
@@ -160,9 +156,9 @@ prep_memcpy_polled(struct dma_chan *dma_chan, const struct sdxi_copy *params)
160156
161157 copy = sdxi_ring_resv_next (& sddesc -> resv );
162158 (void )sdxi_encode_copy (copy , params ); /* Caller checked validity. */
163- sdxi_completion_attach (copy , completion );
159+ sdxi_completion_attach (copy , comp );
164160
165- sddesc -> completion = no_free_ptr (completion );
161+ sddesc -> completion = no_free_ptr (comp );
166162 return_ptr (sddesc );
167163}
168164
0 commit comments