Skip to content

Commit 8560bf6

Browse files
committed
dmaengine: sdxi: hw: Improve spec references pt 2
Update the references for descriptor layouts. Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent 6f3efad commit 8560bf6

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

  • drivers/dma/sdxi

drivers/dma/sdxi/hw.h

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,10 @@ static_assert(sizeof(struct sdxi_cst_blk) == 32);
153153

154154
struct sdxi_desc {
155155
union {
156-
/* DSC_GENERIC - common header and footer */
156+
/*
157+
* SDXI 1.0 Table 6-3: DSC_GENERIC SDXI Descriptor
158+
* Common Header and Footer Format
159+
*/
157160
struct_group_tagged(sdxi_dsc_generic, generic,
158161
__le32 opcode;
159162
__u8 operation[52];
@@ -177,13 +180,13 @@ struct sdxi_desc {
177180

178181
#define SDXI_DSC_OP_TYPE_DMAB 0x001
179182
#define SDXI_DSC_OP_SUBTYPE_NOP 0x01
180-
/* DmaBaseGrp: DSC_DMAB_NOP */
183+
/* SDXI 1.0 Table 6-6: DSC_DMAB_NOP Descriptor Format */
181184
define_sdxi_dsc(sdxi_dsc_dmab_nop, nop,
182185
__u8 rsvd_0[52];
183186
);
184187

185188
#define SDXI_DSC_OP_SUBTYPE_COPY 0x03
186-
/* DmaBaseGrp: DSC_DMAB_COPY */
189+
/* SDXI 1.0 Table 6-8: DSC_DMAB_COPY Descriptor Format */
187190
define_sdxi_dsc(sdxi_dsc_dmab_copy, copy,
188191
__le32 size;
189192
__u8 attr;
@@ -197,7 +200,7 @@ struct sdxi_desc {
197200

198201
#define SDXI_DSC_OP_TYPE_INTR 0x004
199202
#define SDXI_DSC_OP_SUBTYPE_INTR 0x00
200-
/* IntrGrp: DSC_INTR */
203+
/* SDXI 1.0 Table 6-12: DSC_INTR Descriptor Format */
201204
define_sdxi_dsc(sdxi_dsc_intr, intr,
202205
__u8 rsvd_0[8];
203206
__le16 akey;
@@ -207,7 +210,7 @@ struct sdxi_desc {
207210
#define SDXI_DSC_OP_TYPE_ADMIN 0x002
208211
#define SDXI_DSC_OP_SUBTYPE_CXT_START_NM 0x03
209212
#define SDXI_DSC_OP_SUBTYPE_CXT_START_RS 0x08
210-
/* AdminGrp: DSC_CXT_START */
213+
/* SDXI 1.0 Table 6-14: DSC_CXT_START Descriptor Format */
211214
define_sdxi_dsc(sdxi_dsc_cxt_start, cxt_start,
212215
__u8 rsvd_0;
213216
__u8 vflags;
@@ -220,7 +223,7 @@ struct sdxi_desc {
220223
);
221224

222225
#define SDXI_DSC_OP_SUBTYPE_CXT_STOP 0x04
223-
/* AdminGrp: DSC_CXT_STOP */
226+
/* SDXI 1.0 Table 6-15: DSC_CXT_STOP Descriptor Format */
224227
define_sdxi_dsc(sdxi_dsc_cxt_stop, cxt_stop,
225228
__u8 rsvd_0;
226229
__u8 vflags;
@@ -234,7 +237,7 @@ struct sdxi_desc {
234237
#define SDXI_DSC_CXT_STOP_VF BIT(8)
235238

236239
#define SDXI_DSC_OP_SUBTYPE_SYNC 0x06
237-
/* AdminGrp: DSC_SYNC */
240+
/* SDXI 1.0 Table 6-22: DSC_SYNC Descriptor Format */
238241
define_sdxi_dsc(sdxi_dsc_sync, sync,
239242
__u8 cflags;
240243
__u8 vflags;

0 commit comments

Comments
 (0)