Merge pull request #136 from mariodruiz/github-app-updates

GitHub app updates

Author: KerwinTsaiii

README.md

@@ -158,7 +158,7 @@ Kubernetes provides a robust infrastructure for deploying and managing JupyterHu
 
 Seamless integration with GitHub Single Sign-On (SSO) and Native Authenticator for secure and efficient user authentication.
 - **Auto-admin on install**: Initial admin created automatically with random password
-- **Dual login**: GitHub OAuth + Native accounts on single login page
+- **Dual login**: GitHub App + Native accounts on single login page
 - **Batch user management**: CSV/Excel-based bulk operations via scripts
 
 ### Storage Management and Security
@@ -198,7 +198,7 @@ Full documentation is available at: **https://amdresearch.github.io/aup-learning
 
 - [Deployment Guide](deploy/README.md) - Single-node and multi-node deployment
 - [Configuration Reference](https://amdresearch.github.io/aup-learning-cloud/jupyterhub/configuration-reference.html) - `runtime/values.yaml` field reference
-- [Authentication Guide](https://amdresearch.github.io/aup-learning-cloud/jupyterhub/authentication-guide.html) - GitHub OAuth and native authentication
+- [Authentication Guide](https://amdresearch.github.io/aup-learning-cloud/jupyterhub/authentication-guide.html) - GitHub App and native authentication
 - [User Management Guide](https://amdresearch.github.io/aup-learning-cloud/jupyterhub/user-management.html) - Batch user operations with scripts
 - [User Quota System](https://amdresearch.github.io/aup-learning-cloud/jupyterhub/quota-system.html) - Resource usage tracking and quota management
 

runtime/chart/values.schema.yaml

@@ -3179,8 +3179,8 @@ properties:
 
           - `auto-login`: No credentials required, auto-login as 'student' (for demos/single-node)
           - `dummy`: Accept any username/password (for testing)
-          - `github`: GitHub OAuth authentication only
-          - `multi`: GitHub OAuth + Local native accounts (recommended for production)
+          - `github`: GitHub App authentication only
+          - `multi`: GitHub App + Local native accounts (recommended for production)
 
       adminUser:
         type: object

runtime/chart/values.yaml

@@ -18,7 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-
 # fullnameOverride and nameOverride distinguishes blank strings, null values,
 # and non-blank strings. For more details, see the configuration reference.
 fullnameOverride: ""
@@ -35,8 +34,8 @@ custom:
   # Authentication mode: "auto-login" | "dummy" | "github" | "multi"
   #   - auto-login: No credentials required, auto-login as 'student' (default, for single-node)
   #   - dummy: Accept any username/password (for testing)
-  #   - github: GitHub OAuth authentication
-  #   - multi: GitHub OAuth + Local accounts
+  #   - github: GitHub App authentication
+  #   - multi: GitHub App + Local accounts
   authMode: "auto-login"
 
   # Auto-create admin user on first install (optional)

runtime/hub/core/authenticators/__init__.py

@@ -25,7 +25,7 @@
 
 from core.authenticators.auto_login import AutoLoginAuthenticator
 from core.authenticators.firstuse import CustomFirstUseAuthenticator
-from core.authenticators.github_oauth import CustomGitHubOAuthenticator
+from core.authenticators.github_app import CustomGitHubOAuthenticator
 from core.authenticators.jwt import RemoteLabAuthenticator
 from core.authenticators.multi import CustomMultiAuthenticator
 

…/hub/core/authenticators/github_oauth.py …me/hub/core/authenticators/github_app.pyruntime/hub/core/authenticators/github_oauth.py renamed to runtime/hub/core/authenticators/github_app.py runtime/hub/core/authenticators/github_oauth.py renamed to runtime/hub/core/authenticators/github_app.py

@@ -18,9 +18,9 @@
 # SOFTWARE.
 
 """
-GitHub OAuth Authenticator
+GitHub App Authenticator
 
-Custom GitHub OAuth authenticator with team integration support.
+Custom GitHub App authenticator with team integration support.
 Supports automatic token refresh for GitHub App user-to-server tokens.
 """
 
@@ -54,7 +54,7 @@ async def get(self):
 
 
 class CustomGitHubOAuthenticator(GitHubOAuthenticator):
-    """GitHub OAuth authenticator with access token preservation and refresh."""
+    """GitHub App authenticator with access token preservation and refresh."""
 
     name = "github"
     callback_handler = _GitHubAppInstallCallbackHandler

runtime/hub/frontend/apps/admin/src/components/EditUserModal.tsx

@@ -139,7 +139,7 @@ export function EditUserModal({ show, user, onHide, onUpdate }: Props) {
               </InputGroup>
               <Form.Text className="text-muted">
                 {isGitHubUser
-                  ? 'GitHub OAuth usernames cannot be renamed'
+                  ? 'GitHub App usernames cannot be renamed'
                   : 'Only letters, numbers, hyphens, and underscores allowed'}
               </Form.Text>
             </Form.Group>

runtime/hub/frontend/apps/spawn/src/components/CourseCard.tsx

@@ -205,7 +205,7 @@ export const CourseCard = memo(function CourseCard({
             <small className="repo-url-error">{repoUrlError}</small>
           )}
 
-          {/* GitHub App Install/Manage Prompt (only for GitHub OAuth users) */}
+          {/* GitHub App Install/Manage Prompt (only for GitHub App users) */}
           {githubAppName && isCurrentUserGitHub() && (
             <a
               className="github-app-prompt"

runtime/hub/frontend/templates/login.html

@@ -160,9 +160,9 @@ <h1 class="text-2xl font-bold text-gray-800">Login to AUP Learning Cloud</h1>
                 </form>
 
                 {% elif authenticator_mode == 'github' %}
-                <!-- GitHub OAuth Only -->
-                <!-- NOTE: Do NOT add "| urlencode" to OAuth links! JupyterHub already URL-escapes
-                     the "next" variable. OAuth stores next in a cookie as-is, so double-encoding
+                <!-- GitHub App Only -->
+                <!-- NOTE: Do NOT add "| urlencode" to App links! JupyterHub already URL-escapes
+                     the "next" variable. App stores next in a cookie as-is, so double-encoding
                      causes redirects to fail (e.g., /hub/%2Fhub%2F instead of /hub/).
                      Form POST actions DO need urlencode due to different browser/server handling. -->
                 <div class="mb-6">
@@ -176,8 +176,8 @@ <h1 class="text-2xl font-bold text-gray-800">Login to AUP Learning Cloud</h1>
                 </div>
 
                 {% else %}
-                <!-- Multi Authenticator: GitHub OAuth + Native accounts -->
-                <!-- GitHub OAuth Button -->
+                <!-- Multi Authenticator: GitHub App + Native accounts -->
+                <!-- GitHub App Button -->
                 <!-- NOTE: Do NOT add "| urlencode" here - see comment above for explanation -->
                 <div class="mb-6">
                     <a href="{{ base_url }}github/oauth_login?next={{ next }}"

runtime/values-multi-nodes.yaml.example

@@ -53,8 +53,8 @@ custom:
   # Authentication mode
   # - auto-login: No credentials required, auto-login as 'student' (for single-node dev)
   # - dummy: Accept any username/password (for testing)
-  # - github: GitHub OAuth authentication
-  # - multi: GitHub OAuth + native first-use accounts
+  # - github: GitHub App authentication
+  # - multi: GitHub App + native first-use accounts
   authMode: "multi"
 
   # GitHub organization name for team-based resource access
@@ -94,7 +94,7 @@ custom:
   # Private repo access — two independent mechanisms (can be used together):
   #
   #   1. GitHub App (githubAppName)
-  #      For GitHub OAuth users. Users authorize per-repo read-only access via
+  #      For GitHub App users. Users authorize per-repo read-only access via
   #      the GitHub App UI. Token is obtained automatically from OAuth session.
   #      Requires migrating from OAuth App to GitHub App — see below.
   #

runtime/values.yaml

@@ -46,8 +46,8 @@ custom:
   # Authentication mode
   # - auto-login: No credentials required, auto-login as 'student' (for single-node dev)
   # - dummy: Accept any username/password (for testing)
-  # - github: GitHub OAuth authentication
-  # - multi: GitHub OAuth + Local accounts
+  # - github: GitHub App authentication
+  # - multi: GitHub App + Local accounts
   authMode: "auto-login"
 
   # Auto-create admin user on first install
@@ -136,7 +136,7 @@ custom:
   # Private repo access — two independent mechanisms (can be used together):
   #
   #   1. GitHub App (githubAppName)
-  #      For GitHub OAuth users. Users authorize per-repo read-only access via
+  #      For GitHub App users. Users authorize per-repo read-only access via
   #      the GitHub App UI. Token is obtained automatically from OAuth session.
   #      Requires migrating from OAuth App to GitHub App — see below.
   #
@@ -167,7 +167,7 @@ custom:
     # -- Private Repo Access --
     # GitHub App slug (e.g. "aup-learning-cloud")
     # Enables repo picker UI and automatic OAuth token usage for private repos.
-    # Only effective for GitHub OAuth users; auto-login/native users are unaffected.
+    # Only effective for GitHub App users; auto-login/native users are unaffected.
     githubAppName: ""
     # Default access token for private repos (e.g. a bot/service account PAT).
     # Works for ALL auth modes including auto-login — users don't need to know
@@ -463,7 +463,7 @@ hub:
     Authenticator:
       allow_all: true
 
-    # ---- GitHub OAuth ----
+    # ---- GitHub App ----
     GitHubOAuthenticator:
       oauth_callback_url: "https://<Your.domain>/hub/github/oauth_callback"
       app_id: ""