File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -122,16 +122,11 @@ def emit_overlay(
122122 buf .write (" acceleratorKeys:\n " )
123123 for sku in cfg .skus :
124124 buf .write (f" - { sku .accel_key } \n " )
125- if not homogeneous_target :
126- base_name = _RESOURCE_IMAGE_BASE [resource ]
127- wrote_overrides = False
128- for sku in cfg .skus :
129- if sku .gpu_target != cfg .gpu_target :
130- if not wrote_overrides :
131- buf .write (" acceleratorOverrides:\n " )
132- wrote_overrides = True
133- buf .write (f" { sku .accel_key } :\n " )
134- buf .write (f' image: "{ image_registry } /{ base_name } :{ image_tag } -{ sku .gpu_target } "\n ' )
125+ base_name = _RESOURCE_IMAGE_BASE [resource ]
126+ buf .write (" acceleratorOverrides:\n " )
127+ for sku in cfg .skus :
128+ buf .write (f" { sku .accel_key } :\n " )
129+ buf .write (f' image: "{ image_registry } /{ base_name } :{ image_tag } -{ sku .gpu_target } "\n ' )
135130
136131 # --- teams.mapping filter (only when course selection is in effect) ---
137132 if filter_courses :
Original file line number Diff line number Diff line change @@ -115,6 +115,17 @@ def test_resource_images_use_primary_tag() -> None:
115115 assert images ["Course-PhySim" ] == "ghcr.io/amdresearch/auplc-physim:v1.0-gfx1151"
116116
117117
118+ def test_homogeneous_target_emits_matching_accelerator_overrides () -> None :
119+ _ , parsed = _render (_strix_halo_cfg (), courses = CourseSelection .default ())
120+ gpu_metadata = parsed ["custom" ]["resources" ]["metadata" ]["gpu" ]
121+ overrides = gpu_metadata ["acceleratorOverrides" ]
122+ assert overrides == {
123+ "strix-halo" : {
124+ "image" : "ghcr.io/amdresearch/auplc-base:v1.0-gfx1151" ,
125+ },
126+ }
127+
128+
118129def test_curated_sku_with_product_name_emits_node_selector () -> None :
119130 _ , parsed = _render (_strix_halo_cfg (), courses = CourseSelection .default ())
120131 accelerators = parsed ["custom" ]["accelerators" ]
@@ -206,6 +217,7 @@ def test_mixed_targets_emit_accelerator_overrides() -> None:
206217 gpu_metadata = parsed ["custom" ]["resources" ]["metadata" ]["gpu" ]
207218 assert "acceleratorOverrides" in gpu_metadata
208219 overrides = gpu_metadata ["acceleratorOverrides" ]
220+ assert overrides ["strix-halo" ]["image" ] == "ghcr.io/amdresearch/auplc-base:v1.0-gfx1151"
209221 assert "r9700" in overrides
210222 assert overrides ["r9700" ]["image" ] == "ghcr.io/amdresearch/auplc-base:v1.0-gfx120x"
211223
You can’t perform that action at this time.
0 commit comments