Skip to content

Commit a27dc75

Browse files
committed
feat(installer): treat 9600 GRE as a curated SKU
1 parent f969345 commit a27dc75

3 files changed

Lines changed: 19 additions & 3 deletions

File tree

auplc_installer/gpu.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
# Accelerator keys defined in runtime/values.yaml custom.accelerators. When
4949
# the resolved accel_key is not in this list, ``overlay.py`` injects a full
5050
# minimal accelerator stanza so helm install succeeds without values.yaml
51-
# edits (useful for ad-hoc SKUs like 9600gre).
52-
GPU_CURATED_SKU_KEYS = ("phx", "strix", "strix-halo", "9070xt", "r9700")
51+
# edits (useful for ad-hoc SKUs not yet promoted to the default values).
52+
GPU_CURATED_SKU_KEYS = ("phx", "strix", "strix-halo", "9070xt", "r9700", "9600gre")
5353

5454

5555
def is_curated_sku(key: str) -> bool:

tests/installer/test_gpu.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,12 @@ def test_is_curated_sku(key: str) -> None:
136136
assert is_curated_sku(key)
137137

138138

139+
def test_is_curated_sku_true_for_9600gre() -> None:
140+
assert is_curated_sku("9600gre")
141+
142+
139143
def test_is_curated_sku_false_for_unknown() -> None:
140-
assert not is_curated_sku("9600gre")
144+
assert not is_curated_sku("totally-unknown")
141145

142146

143147
def test_resolve_gpu_config_known_short_name() -> None:

tests/installer/test_overlay.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,18 @@ def test_curated_sku_with_product_name_emits_node_selector() -> None:
122122
assert accelerators["strix-halo"]["nodeSelector"]["amd.com/gpu.product-name"] == "AMD_Radeon_8060S_Graphics"
123123

124124

125+
def test_9600gre_uses_curated_overlay_path() -> None:
126+
cfg = GpuConfig()
127+
append_product(cfg, "AMD_Radeon_RX_9600_GRE")
128+
text, parsed = _render(cfg, courses=CourseSelection.default())
129+
accel = parsed["custom"]["accelerators"]["9600gre"]
130+
assert accel["nodeSelector"]["amd.com/gpu.product-name"] == "AMD_Radeon_RX_9600_GRE"
131+
assert "displayName" not in accel
132+
assert "description" not in accel
133+
assert "quotaRate" not in accel
134+
assert "SKU '9600gre' is not curated in values.yaml" not in text
135+
136+
125137
def test_basic_emits_filtered_teams_mapping() -> None:
126138
_, parsed = _render(
127139
_strix_halo_cfg(),

0 commit comments

Comments
 (0)