Lochness update to accommodate the new Penn CNB REDCap structure #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashrifbillah
approved these changes
Aug 31, 2023
tashrifbillah
left a comment
tashrifbillah
left a comment
There was a problem hiding this comment.
This pull request was simple to review. This block will need update according to this PR:
Member
Author
|
Thanks. I'll merge this PR and deploy it on Pronet server, once DPACC team agrees to move to the new PennCNB format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in the new Penn CNB REDCap is the new field name that contains AMP-SCZ IDs. (
src_subject_id, which wassession_subidin the previous CNB REDCap) This PR updates the field name.Note that this PR will change the structure of UPENN JSON files, thus all downstream pipelines depending on the previous json structure need to be updated. An example of the new JSON file is located on ERIS:
(Deploying this PR will make the lochness instance to overwrite all existing UPENN JSON files.)