Skip to content

Merge construct_hydro_source for MOL and CTU #522

Open
@maximumcats

Description

@maximumcats

We should be able to merge the hydro source constructor for both MOL and CTU. If we pass dt = 0 to the CTU hydro source constructor, the code should already do the right thing for this case, which is how MOL calls it. (If it doesn't, we'll have to fix that.) Then the only thing to be concerned about is optimization -- the trans* calls are unnecessary if dt = 0. So there would be a switch that says if dt > 0, then take the normal CTU route, and if dt == 0, then pass qm and qp directly to cmpflx.

The reason to do this is that we don't have to maintain two sections of nearly redundant code. Aside from the calls to the Riemann solver (and the trans terms), the MOL hydro update is very similar.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions