Skip to content

Commit bace8d2

Browse files
committed
Merge branch 'clipping' into vode_robustify
2 parents 203c92c + a50eada commit bace8d2

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Docs/source/ode_integrators.rst

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,11 @@ constraint on the intermediate states during the integration.
275275
The default is ``1.e-30``.
276276

277277
* ``integrator.do_species_clip`` : this enforces that the mass fractions
278-
all in $[\mathtt{SMALL\_X\_SAFE}, 1.0]$.
278+
all in $[\mathtt{SMALL\_X\_SAFE}, 1.0]$ before calling the network righthand
279+
side function.
279280

280-
This is enabled by default.
281+
This is off by default. Turning this on can sometimes make the integrator
282+
work a lot harder.
281283

282284
* ``integrator.do_corrector_validation`` : in the nonlinear solve
283285
corrector loop, when we get a corrected integration state, do we

integration/_parameters

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ retry_atol_enuc real -1
9191

9292
# in the clean_state process, do we clip the species such that they
9393
# are in [0, 1]?
94-
do_species_clip bool 1
94+
do_species_clip bool 0
9595

9696
# in the corrector loop, do we check if the predicted state is
9797
# valid (X > 0) before calling the RHS?

0 commit comments

Comments
 (0)