a few fixes from cppcheck (#1915)

mostly scope reduction

Author: zingale

integration/VODE/vode_dvjac.H

@@ -35,9 +35,7 @@ void dvjac (int& IERPJ, BurnT& state, DvodeT& vstate)
 
     if (integrator_rp::use_jacobian_caching) {
         evaluate_jacobian = 0;
-    }
 
-    if (integrator_rp::use_jacobian_caching) {
         // Now evaluate the cases where we're caching the Jacobian but aren't
         // going to be using the cached Jacobian.
 

nse_solver/nse_check.H

@@ -100,11 +100,10 @@ int get_root_index(const int nuc_ind,
     // This function returns the root index of the nuclei
     // by providing the nuclei index [0, NumSpec-1], and group indices, group_ind
 
-    int root_index;
     int scratch_ind = nuc_ind;
 
     while(true) {
-        root_index = group_ind(scratch_ind + 1);
+        int root_index = group_ind(scratch_ind + 1);
 
         if (root_index != scratch_ind + 1) {
             scratch_ind = root_index - 1;
@@ -166,9 +165,6 @@ bool in_single_group(const amrex::Array1D<int, 1, NumSpec>& group_ind) {
 
     int nonLIG_index = -1;
 
-    int oddN_group = -1;
-    int evenN_group = -1;
-
     bool in_single_group = true;
 
     // Consider NSE when there is a single group with an optional LIG group
@@ -200,6 +196,9 @@ bool in_single_group(const amrex::Array1D<int, 1, NumSpec>& group_ind) {
 
         in_single_group = true;
 
+        int oddN_group = -1;
+        int evenN_group = -1;
+
         for (int n = 0; n < NumSpec; ++n) {
 
             if (zion[n] >= 14) {

unit_test/react_util.H

@@ -88,7 +88,7 @@ init_t setup_composition(const int nz) {
 
 
 AMREX_INLINE AMREX_GPU_HOST_DEVICE
-void get_xn(const int k, const init_t cd, amrex::Real *xn_zone, bool uniform_composition=false) {
+void get_xn(const int k, const init_t& cd, amrex::Real *xn_zone, bool uniform_composition=false) {
 
     for (int n = 0; n < NumSpec; n++) {
         xn_zone[n] = 0.0_rt;