Fix CodeQL warnings (#3318)

Author: WeiqunZhang

Docs/sphinx_documentation/source/conf.py

@@ -20,7 +20,6 @@
 # import sys
 # sys.path.insert(0, os.path.abspath('.'))
 
-import sphinx_rtd_theme
 from datetime import datetime
 
 def get_amrex_version():

Src/Base/AMReX_Box.H

@@ -911,10 +911,10 @@ Box::index (const IntVect& v) const noexcept
 {
     Long result = v[0]-smallend[0];
 #if   AMREX_SPACEDIM==2
-    result += length(0)*(v[1]-smallend[1]);
+    result += length(0)*Long(v[1]-smallend[1]);
 #elif AMREX_SPACEDIM==3
-    result += length(0)*(v[1]-smallend[1]
-                         +(v[2]-smallend[2])*length(1));
+    result += length(0)*((v[1]-smallend[1])
+                         +Long(v[2]-smallend[2])*length(1));
 #endif
     return result;
 }

Src/Base/AMReX_FArrayBox.H

@@ -70,7 +70,7 @@ public:
     */
     enum Format
     {
-        FAB_ASCII = 0,
+        FAB_ASCII,
         FAB_IEEE,
         FAB_NATIVE,
         //

Src/EB/AMReX_EB2_IF_Spline.H

@@ -33,7 +33,7 @@ class SplineIF {
 
   amrex::Real operator() (const amrex::RealArray& p) const {
     amrex::RealVect cp;
-    distFcnElement2d * closesetGeomElement;
+    distFcnElement2d * closesetGeomElement = nullptr;
     amrex::Real dist;
     dist = 1.0e29_rt;
     amrex::RealVect x(AMREX_D_DECL(p[0], p[1], p[2]));
@@ -44,7 +44,7 @@ class SplineIF {
         closesetGeomElement = geom;
       }
     }
-    amrex::Real side = closesetGeomElement->cpside(x,cp);
+    amrex::Real side = closesetGeomElement ? closesetGeomElement->cpside(x,cp) : Real(0.0);
     return dist*side;
   }
 

Src/Particle/AMReX_ParticleContainerI.H

@@ -652,7 +652,7 @@ struct FilterVirt
     GpuArray<Real, AMREX_SPACEDIM> m_plo, m_dxi;
     Box m_domain;
 
-    FilterVirt (const amrex::AssignGrid<amrex::DenseBinIteratorFactory<amrex::Box>> assign_buffer_grid, const GpuArray<Real, AMREX_SPACEDIM>& plo,
+    FilterVirt (const amrex::AssignGrid<amrex::DenseBinIteratorFactory<amrex::Box>>& assign_buffer_grid, const GpuArray<Real, AMREX_SPACEDIM>& plo,
                 const GpuArray<Real, AMREX_SPACEDIM> & dxi, const Box& domain)
       : m_assign_buffer_grid(assign_buffer_grid), m_plo(plo), m_dxi(dxi), m_domain(domain)
     {}

Tools/C_scripts/describe_sources.py

@@ -1,6 +1,5 @@
 #!/usr/bin/env python3
 
-import sys
 import argparse
 import os
 import subprocess

Tools/C_scripts/gatherbuildtime.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 
-import sys, os, glob, operator, time
+import sys, os, glob, operator
 
 if __name__ == "__main__":
     dt = float(sys.argv[3])-float(sys.argv[2])

Tools/C_scripts/makebuildinfo_C.py

@@ -281,7 +281,6 @@ def get_git_hash(d, git_style):
     else:
         GIT = args.GIT.split()
 
-    ngit = len(GIT)
     git_hashes = []
     for d in GIT:
         if d and os.path.isdir(d):

Tools/CompileTesting/compiletesting.py

@@ -2,7 +2,6 @@
 
 import sys
 import os
-import shlex
 import subprocess
 import calendar
 import time

Tools/EBSurfaceTools/isoToVTK.py

@@ -1,6 +1,5 @@
 import vtk
 from vtk import *
-import string
 import sys
 
 f = open(sys.argv[1],'r')