SYCL on Windows workaround (#4436)

Replace some std::min and max with amrex::min and max. The issue is the
initializer version of std::min and std::max on Windows does not work in
SYCL device code.

Author: WeiqunZhang

Src/Base/AMReX_GpuLaunchFunctsG.H

@@ -591,7 +591,7 @@ void ParallelFor (Gpu::KernelInfo const& /*info*/,
             [[sycl::reqd_work_group_size(MT)]]
             [[sycl::reqd_sub_group_size(Gpu::Device::warp_size)]]
             {
-                auto const ncells = std::max({indexer1.numPts(), indexer2.numPts(), indexer3.numPts()});
+                auto const ncells = amrex::max(indexer1.numPts(), indexer2.numPts(), indexer3.numPts());
                 for (std::uint64_t icell = item.get_global_id(0), stride = item.get_global_range(0);
                      icell < ncells; icell += stride) {
                     if (icell < indexer1.numPts()) {
@@ -680,7 +680,7 @@ void ParallelFor (Gpu::KernelInfo const& /*info*/,
             [[sycl::reqd_work_group_size(MT)]]
             [[sycl::reqd_sub_group_size(Gpu::Device::warp_size)]]
             {
-                auto const ncells = std::max({indexer1.numPts(), indexer2.numPts(), indexer3.numPts()});
+                auto const ncells = amrex::max(indexer1.numPts(), indexer2.numPts(), indexer3.numPts());
                 for (std::uint64_t icell = item.get_global_id(0), stride = item.get_global_range(0);
                      icell < ncells; icell += stride) {
                     if (icell < indexer1.numPts()) {

Src/EB/AMReX_EBData.H

@@ -114,16 +114,16 @@ struct EBData
                 Real y1 = bc1 - ((Real( 0.5)-bc0)*n0+(Real(-0.5)-bc2)*n2)/n1;
                 Real y2 = bc1 - ((Real(-0.5)-bc0)*n0+(Real( 0.5)-bc2)*n2)/n1;
                 Real y3 = bc1 - ((Real( 0.5)-bc0)*n0+(Real( 0.5)-bc2)*n2)/n1;
-                Real ymin = std::min({y0,y1,y2,y3});
-                Real ymax = std::max({y0,y1,y2,y3});
+                Real ymin = amrex::min(y0,y1,y2,y3);
+                Real ymax = amrex::max(y0,y1,y2,y3);
                 ymin = std::max(ymin, Real(-0.5));
                 ymax = std::min(ymax, Real( 0.5));
                 Real z0 = bc2 - ((Real(-0.5)-bc0)*n0+(Real(-0.5)-bc1)*n1)/n2;
                 Real z1 = bc2 - ((Real( 0.5)-bc0)*n0+(Real(-0.5)-bc1)*n1)/n2;
                 Real z2 = bc2 - ((Real(-0.5)-bc0)*n0+(Real( 0.5)-bc1)*n1)/n2;
                 Real z3 = bc2 - ((Real( 0.5)-bc0)*n0+(Real( 0.5)-bc1)*n1)/n2;
-                Real zmin = std::min({z0,z1,z2,z3});
-                Real zmax = std::max({z0,z1,z2,z3});
+                Real zmin = amrex::min(z0,z1,z2,z3);
+                Real zmax = amrex::max(z0,z1,z2,z3);
                 zmin = std::max(zmin, Real(-0.5));
                 zmax = std::min(zmax, Real( 0.5));
                 Real x, y, z;

Tests/LinearSolvers/Hypre/MyTest.cpp

@@ -152,7 +152,7 @@ MyTest::solve ()
 
             hp = (!ecx || ecx(i,j,k) == Real(1.0)) ? Real(1.0) : (Real(1.0)+Real(2.)*ecx(i,j,k));
             hm = (!ecx || ecx(i-1,j,k) == Real(1.0)) ? Real(1.0) : (Real(1.0)-Real(2.)*ecx(i-1,j,k));
-            scale = std::min({scale, hp, hm});
+            scale = amrex::min(scale, hp, hm);
             Real s = fac[0]*Real(2.0)/(hp+hm);
 
             if (levset(i+1,j,k) < Real(0.0)) {
@@ -185,7 +185,7 @@ MyTest::solve ()
 
             hp = (!ecy || ecy(i,j,k) == Real(1.0)) ? Real(1.0) : (Real(1.0)+Real(2.)*ecy(i,j,k));
             hm = (!ecy || ecy(i,j-1,k) == Real(1.0)) ? Real(1.0) : (Real(1.0)-Real(2.)*ecy(i,j-1,k));
-            scale = std::min({scale, hp, hm});
+            scale = amrex::min(scale, hp, hm);
             s = fac[1]*Real(2.0)/(hp+hm);
 
             if (levset(i,j+1,k) < Real(0.0)) {
@@ -219,7 +219,7 @@ MyTest::solve ()
 #if (AMREX_SPACEDIM > 2)
             hp = (!ecz || ecz(i,j,k) == Real(1.0)) ? Real(1.0) : (Real(1.0)+Real(2.)*ecz(i,j,k));
             hm = (!ecz || ecz(i,j,k-1) == Real(1.0)) ? Real(1.0) : (Real(1.0)-Real(2.)*ecz(i,j,k-1));
-            scale = std::min({scale, hp, hm});
+            scale = amrex::min(scale, hp, hm);
             s = fac[2]*Real(2.0)/(hp+hm);
 
             if (levset(i,j,k+1) < Real(0.0)) {