Skip to content

Time integrator for particle types #4656

@srichers

Description

@srichers

It seems that a change from 15 months ago (259db7c) introduced some logic into the initialize_stages function of the time integrators (e.g., https://github.com/AMReX-Codes/amrex/blob/development/Src/Base/AMReX_RKIntegrator.H#L169) that involves a function (CreateLike) that has a different signature for MultiFabs (https://github.com/AMReX-Codes/amrex/blob/development/Src/Base/AMReX_IntegratorBase.H#L137) and ParticleContainers (https://github.com/AMReX-Codes/amrex/blob/development/Src/Base/AMReX_IntegratorBase.H#L25). Because of this, the implementation of initialize_stages only works for multifabs.

To me it seems that either the initialize_stages functions can be specialized to different types or the CreateLike function for particle containers can be given an additional dummy argument to have the same signature as the equivalent functions for multifabs. The latter seems more suitable to me.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions