Skip to content

Commit 3a72a95

Browse files
authored
CI: Simplify Stubs (#248)
* CI: Simplify Stubs - always run - always test result - only push if in mainline `development` branch * Update: `actions/checkout@v4` Update leftover `actions/checkout@v3` usage.
1 parent 64e1c06 commit 3a72a95

File tree

10 files changed

+21
-18
lines changed

10 files changed

+21
-18
lines changed

.github/workflows/ci.yml

-3
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,12 @@ concurrency:
99
jobs:
1010
stubs:
1111
# Pushes should only run on mainline branch "development"
12-
# TODO: We can also skip this, if the latest commit's name is "Update Stub Files"
13-
if: github.event_name == 'push' && github.repository == 'AMReX-Codes/pyamrex' && github.ref == 'refs/heads/development'
1412
name: 🔄 Update Stub Files
1513
secrets:
1614
PYAMREX_PUSH_TOKEN: ${{ secrets.PYAMREX_PUSH_TOKEN }}
1715
uses: ./.github/workflows/stubs.yml
1816

1917
ubuntu:
20-
if: always() && !contains(needs.*.result, 'failure') && github.event.pull_request.draft == false
2118
name: 🐧 Ubuntu
2219
needs: [stubs]
2320
uses: ./.github/workflows/ubuntu.yml

.github/workflows/cleanup-cache-postpr.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
env:
1717
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
- name: Clean up ccahe
2121
run: |
2222
gh extension install actions/gh-actions-cache

.github/workflows/cleanup-cache.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
env:
1717
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
- name: Clean up ccahe
2121
run: |
2222
gh extension install actions/gh-actions-cache

.github/workflows/codeql.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
steps:
2727
- name: Checkout
28-
uses: actions/checkout@v3
28+
uses: actions/checkout@v4
2929

3030
- name: Clean Out
3131
run: |

.github/workflows/hip.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
CXXFLAGS: "-Werror -Wno-deprecated-declarations -Wno-error=pass-failed -fno-operator-names"
1515
CMAKE_GENERATOR: Ninja
1616
steps:
17-
- uses: actions/checkout@v3
17+
- uses: actions/checkout@v4
1818
- name: install dependencies
1919
shell: bash
2020
run: |

.github/workflows/intel.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: oneAPI SYCL 3D
1212
runs-on: ubuntu-20.04
1313
steps:
14-
- uses: actions/checkout@v3
14+
- uses: actions/checkout@v4
1515
- name: Dependencies
1616
run: |
1717
.github/workflows/dependencies/dpcpp.sh
@@ -60,7 +60,7 @@ jobs:
6060
name: ICPX
6161
runs-on: ubuntu-20.04
6262
steps:
63-
- uses: actions/checkout@v3
63+
- uses: actions/checkout@v4
6464
- name: Dependencies
6565
run: |
6666
.github/workflows/dependencies/dpcpp.sh
@@ -117,7 +117,7 @@ jobs:
117117
name: ICC
118118
runs-on: ubuntu-20.04
119119
steps:
120-
- uses: actions/checkout@v3
120+
- uses: actions/checkout@v4
121121
- name: install dependencies
122122
run: |
123123
export DEBIAN_FRONTEND=noninteractive

.github/workflows/macos.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
name: [email protected] w/o MPI
1515
runs-on: macos-latest
1616
steps:
17-
- uses: actions/checkout@v3
17+
- uses: actions/checkout@v4
1818
- name: Dependencies
1919
run: .github/workflows/dependencies/dependencies_mac.sh
2020
- name: Set Up Cache

.github/workflows/stubs.yml

+6
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,15 @@ jobs:
2525

2626
steps:
2727
- uses: actions/checkout@v4
28+
if: github.event_name != 'push' || github.repository != 'AMReX-Codes/pyamrex' || github.ref != 'refs/heads/development'
29+
30+
- uses: actions/checkout@v4
31+
if: github.event_name == 'push' && github.repository == 'AMReX-Codes/pyamrex' && github.ref == 'refs/heads/development'
2832
with:
2933
token: ${{ secrets.PYAMREX_PUSH_TOKEN }}
3034

3135
- name: Pull Remote Changes
36+
if: github.event_name == 'push' && github.repository == 'AMReX-Codes/pyamrex' && github.ref == 'refs/heads/development'
3237
run: git pull
3338

3439
- uses: actions/setup-python@v4
@@ -84,5 +89,6 @@ jobs:
8489
8590
- uses: stefanzweifel/git-auto-commit-action@v5
8691
name: Commit Updated Stub Files
92+
if: github.event_name == 'push' && github.repository == 'AMReX-Codes/pyamrex' && github.ref == 'refs/heads/development'
8793
with:
8894
commit_message: Update Stub Files

.github/workflows/ubuntu.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
CXX: g++-7
1717
CXXFLAGS: "-Werror -Wshadow -Woverloaded-virtual -Wunreachable-code -fno-operator-names -Wno-array-bounds"
1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
- uses: actions/setup-python@v4
2121
name: Install Python
2222
with:
@@ -57,7 +57,7 @@ jobs:
5757
runs-on: ubuntu-22.04
5858
env: {CXXFLAGS: "-Werror -Wno-error=deprecated-declarations -Wshadow -Woverloaded-virtual -Wunreachable-code -fno-operator-names"}
5959
steps:
60-
- uses: actions/checkout@v3
60+
- uses: actions/checkout@v4
6161
- name: Dependencies
6262
run: |
6363
.github/workflows/dependencies/dependencies_gcc10.sh
@@ -108,7 +108,7 @@ jobs:
108108
runs-on: ubuntu-20.04
109109
env: {CXXFLAGS: "-Werror -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -fno-operator-names -Wno-pass-failed"}
110110
steps:
111-
- uses: actions/checkout@v3
111+
- uses: actions/checkout@v4
112112
- name: Dependencies
113113
run: |
114114
.github/workflows/dependencies/dependencies_clang6.sh
@@ -151,7 +151,7 @@ jobs:
151151
CXX: "clang++"
152152
CC: "clang"
153153
steps:
154-
- uses: actions/checkout@v3
154+
- uses: actions/checkout@v4
155155
- name: Dependencies
156156
run: |
157157
.github/workflows/dependencies/dependencies_clang14_libcpp.sh
@@ -189,7 +189,7 @@ jobs:
189189
runs-on: ubuntu-20.04
190190
env: {CXXFLAGS: "-fno-operator-names"}
191191
steps:
192-
- uses: actions/checkout@v3
192+
- uses: actions/checkout@v4
193193
- name: Dependencies
194194
run: |
195195
.github/workflows/dependencies/dependencies_nvcc11.sh

.github/workflows/windows.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: MSVC w/o MPI static release
1212
runs-on: windows-latest
1313
steps:
14-
- uses: actions/checkout@v3
14+
- uses: actions/checkout@v4
1515
- uses: actions/setup-python@v4
1616
with:
1717
python-version: '3.x'
@@ -33,7 +33,7 @@ jobs:
3333
name: Clang w/o MPI shared debug
3434
runs-on: windows-latest
3535
steps:
36-
- uses: actions/checkout@v3
36+
- uses: actions/checkout@v4
3737
- uses: actions/setup-python@v4
3838
with:
3939
python-version: '3.x'

0 commit comments

Comments
 (0)