Use a better check if the domain is complete

Author: dpgrote

src/Base/BoxArray.cpp

@@ -129,13 +129,15 @@ void init_BoxArray(py::module &m) {
     //! \brief Apply surroundingNodes(Box,int) to each Box in
     //! BoxArray.  See the documentation of Box for details.
     BoxArray& surroundingNodes (int dir);
+*/
 
     //! Apply Box::enclosedCells() to each Box in the BoxArray.
-    BoxArray& enclosedCells ();
-
-    //! Apply Box::enclosedCells(int) to each Box in the BoxArray.
-    BoxArray& enclosedCells  (int dir);
+    .def("enclosed_cells",
+            py::overload_cast<>(&BoxArray::enclosedCells))
+    .def("enclosed_cells",
+            py::overload_cast<int>(&BoxArray::enclosedCells))
 
+/*
     //! Apply Box::convert(IndexType) to each Box in the BoxArray.
     BoxArray& convert (IndexType typ);
 

src/amrex/extensions/MultiFab.py

@@ -536,9 +536,10 @@ def __getitem__(self, index, with_internal_ghosts=False):
     # including internal ghost cells, and the second time without. The second time is needed
     # to ensure that in places where ghost cells overlap with valid cells, that the data
     # from the valid cells is used.
-    # This check is whether the domain is complete is approximate (since it doesn't
-    # account for cases where boxes overlap each other).
-    domain_complete = self.box_array().numPts >= self.box_array().minimal_box().numPts()
+    # The domain is complete if the number of cells in the box array is the same as
+    # the number of cells in the minimal box.
+    cell_centered_box_array = self.box_array().enclosed_cells()
+    domain_complete = cell_centered_box_array.numPts == cell_centered_box_array.minimal_box().numPts()
 
     if domain_complete or with_internal_ghosts:
         result_global = None