apply suggestions from code review

Author: atmyers

cmake/dependencies/AMReX.cmake

@@ -86,7 +86,7 @@ option(pyAMReX_amrex_internal "Download & build AMReX" ON)
 set(pyAMReX_amrex_repo "https://github.com/AMReX-Codes/amrex.git"
     CACHE STRING
     "Repository URI to pull and build AMReX from if(pyAMReX_amrex_internal)")
-set(pyAMReX_amrex_branch "development"
+set(pyAMReX_amrex_branch "793ea9f717590d66d178a86298b82aac244b77a7"
     CACHE STRING
     "Repository branch for pyAMReX_amrex_repo if(pyAMReX_amrex_internal)")
 

src/Particle/ParticleContainer.cpp

@@ -23,7 +23,9 @@ namespace
 
         auto buf = idcpus.request();
         auto buf2 = ids.request();
-        if (buf.size != buf2.size) throw std::runtime_error("sizes do not match!");
+        if (buf.size != buf2.size) {
+            throw std::runtime_error("sizes do not match!");
+        }
 
         int N = idcpus.shape()[0];
         for (int i = 0; i < N; i++) {
@@ -43,7 +45,9 @@ namespace
 
         auto buf = idcpus.request();
         auto buf2 = cpus.request();
-        if (buf.size != buf2.size) throw std::runtime_error("sizes do not match!");
+        if (buf.size != buf2.size) {
+            throw std::runtime_error("sizes do not match!");
+        }
 
         int N = idcpus.shape()[0];
         for (int i = 0; i < N; i++) {

tests/test_particleTile.py

@@ -176,6 +176,12 @@ def test_ptile_aos():
     assert not amr.is_valid(idcpu[0])
     idcpu[0] = amr.make_valid(idcpu[0])
     assert amr.is_valid(idcpu[0])
+
+    # the leftmost bit stores the sign of the id
+    # the next 39 store its absolute value
+    # the rightmost 24 then store the cpu number
+    # using this scheme, id = 1 cpu = 100
+    # corresponds to 9223372036871553124
     assert idcpu[0] == 9223372036871553124
 
     idcpu = np.array([0, 0, 0, 0, 0], dtype=np.uint64)