IS-04-01 test_23 not working with Node having both senders and receivers and sharing a group name

[alabou]

Senders and Receivers of a given Node may share the same group name as allowed by "Senders and Receivers may both contain matching values of the urn:x-nmos:tag:grouphint tag, indicating that the group has elements in both signal flow directions." from https://specs.amwa.tv/nmos-parameter-registers/branches/main/tags/grouphint.html#natural-groups

test_23 combines senders and receivers of a Node and will detect duplicates that are valid according to the above statement.

[garethsb]

Ha, wonderful how that contradicts "The role of the resource in the group, MUST be unique inside the same group."

I guess this code should take resource type into account...

nmos-testing/nmostesting/suites/IS0401Test.py

Lines 1567 to 1573 in 14c255e

	# Check for duplicate roles within groups
	if group_params[1] in group_ref:
	return test.FAIL("Duplicate role found in group {} for resources {} and {}"
	.format(group_params[0], resource["id"],
	group_ref[group_params[1]]))
	else:
	group_ref[group_params[1]] = resource["id"]