feat(#674): store original clip ID on-chain and expose get_clip_id() - #708
Merged
Eniola3321 merged 1 commit intoAug 1, 2026
Merged
Conversation
…ip_id() - Add get_clip_id(token_id) view function to Soroban contract that returns the clip_id stored in TokenData at mint time - Add getClipId() method to AdminContractService that queries the on-chain get_clip_id via Soroban simulation - Expose GET /nfts/tokens/:tokenId/clip-id endpoint with full Swagger documentation - Update NftPrepareMintResponseDto to document the clipId field as the on-chain ClipCash database link Every NFT already stores clip_id inside TokenData; this PR adds the query surface so callers can verify the NFT <-> database link on-chain. Closes ANYTECHS#674
|
@ellaevans2323-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #674
Every NFT minted by the ClipCash contract already stores the backend
clip_idinsideTokenDataat mint time. This PR adds the missing query surface so callers can verify the on-chain NFT ↔ database link without trusting off-chain metadata.Changes
Soroban contract (
contracts/nft-contract/src/lib.rs)get_clip_id(token_id: u64) -> Option<String>view function that readsTokenData.clip_idfor any tokenNestJS backend
AdminContractService.getClipId(tokenId)— queries the on-chainget_clip_idvia Soroban simulation (no signing required)GET /nfts/tokens/:tokenId/clip-id— new public endpoint with full Swagger/OpenAPI docsNftPrepareMintResponseDto.clipId— updated description to document that this value is stored on-chain and queryable viaget_clip_idAcceptance Criteria
TokenData.clip_idsince contract v1)get_clip_id(token_id)clipIdwith Swagger documentation