[Editorial] No need for clipping, this value is 95 #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found by Christopher "Monty" Montgomery that when a value between 96 and 224 is clipped between -32 and 95, the resulting value will always be 95.
Contributor
|
Looks good to me, I've emailed some others so they can check it doesn't signify a problem with the filtering when this clipping occurs. |
peterderivaz
changed the title
yaowuxu
approved these changes
Dec 26, 2019
|
I do not see anything broken. If my understanding is correct, it seems this is a low level change that is not needed. |
Collaborator
|
It is definitely not required to fix any problem. It simply acknowledges
the fact that clipping a value in the range {96, 224} to an upper bound of
95 will always produce the value 95. One natural response to seeing this in
the spec might be to second guess your own understanding of what's being
specified... "surely they wouldn't have expressed that concept in such
a convoluted way?!!".
One compromise might be to add a note and leave the text otherwise
unchanged?
Adrian
…On Fri, Feb 21, 2025 at 1:00 PM Iole Moccagatta ***@***.***> wrote:
I do not see anything broken. If my understanding is correct, it seems
this is a low level change that is not needed.
—
Reply to this email directly, view it on GitHub
<#275 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACCQPVVAUOUD4WRF6RA4MT2Q6HV3AVCNFSM6AAAAABXUCRKE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGUZTANZXGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: imoccaga]*imoccaga* left a comment (AOMediaCodec/av1-spec#275)
<#275 (comment)>
I do not see anything broken. If my understanding is correct, it seems
this is a low level change that is not needed.
—
Reply to this email directly, view it on GitHub
<#275 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACCQPVVAUOUD4WRF6RA4MT2Q6HV3AVCNFSM6AAAAABXUCRKE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGUZTANZXGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found by Christopher "Monty" Montgomery that when a value
between 96 and 224 is clipped between -32 and 95, the resulting
value will always be 95.