Reducing bug prone codes

Author: APGRoboCop

dlls/bot_commands.cpp

@@ -76,10 +76,10 @@ void player(entvars_t* pev)
 #else
 	extern void* h_Library;
 #endif
-	static LINK_ENTITY_FUNC otherClassName = NULL;
-	if (otherClassName == NULL)
+	static LINK_ENTITY_FUNC otherClassName = nullptr;
+	if (otherClassName == nullptr)
 		otherClassName = (LINK_ENTITY_FUNC)GetProcAddress(h_Library, "player");
-	if (otherClassName != NULL)
+	if (otherClassName != nullptr)
 	{
 		(*otherClassName)(pev);
 	}
@@ -235,7 +235,7 @@ eBotCvarState CUtilCommand::action(CClient* pClient, const char* arg1, const cha
 				if (arg3 && *arg3)
 					iWpt = std::atoi(arg3);
 				else
-					iWpt = WaypointLocations.NearestWaypoint(pClient->GetPlayer()->v.origin, 100, -1);
+					iWpt = WaypointLocations.NearestWaypoint(pClient->GetPlayer()->v.origin, 100.0f, -1);
 
 				pBot->ClearTasks();
 

dlls/bot_const.h

@@ -1236,17 +1236,17 @@ enum : std::uint8_t
 #ifdef RCBOT_META_BUILD
 
 #ifdef _DEBUG
-constexpr const char* BOT_VER = "1.51b13_mm_debug";
+constexpr const char* BOT_VER = "1.51b14_mm_debug";
 #else
-constexpr const char* BOT_VER = "1.51b13_mm";
+constexpr const char* BOT_VER = "1.51b14_mm";
 #endif
 
 #else
 
 #ifdef _DEBUG
-constexpr const char* BOT_VER = "1.51b13_debug";
+constexpr const char* BOT_VER = "1.51b14_debug";
 #else
-constexpr const char* BOT_VER = "1.51b13";
+constexpr const char* BOT_VER = "1.51b14";
 #endif
 
 #endif
@@ -1260,17 +1260,17 @@ constexpr const char* BOT_VER = "1.51b13";
 #ifdef RCBOT_META_BUILD
 
 #ifdef _DEBUG
-constexpr const char* BOT_VER = "1.51b13_mm_debug";
+constexpr const char* BOT_VER = "1.51b14_mm_debug";
 #else
-constexpr const char* BOT_VER = "1.51b13_mm";
+constexpr const char* BOT_VER = "1.51b14_mm";
 #endif
 
 #else
 
 #ifdef _DEBUG
-constexpr const char* BOT_VER = "1.51b13_debug";
+constexpr const char* BOT_VER = "1.51b14_debug";
 #else
-constexpr const char* BOT_VER = "1.51b13";
+constexpr const char* BOT_VER = "1.51b14";
 #endif
 
 #endif

dlls/dll.cpp

@@ -1511,7 +1511,7 @@ int EXPORT GetNewDLLFunctions(NEW_DLL_FUNCTIONS* pFunctionTable, int* interfaceV
 extern "C" EXPORT int GetNewDLLFunctions(NEW_DLL_FUNCTIONS* pFunctionTable, int* interfaceVersion)
 #endif
 {
-	if (other_GetNewDLLFunctions == NULL)
+	if (other_GetNewDLLFunctions == nullptr)
 		return false;
 
 	// pass other DLLs engine callbacks to function table...

dlls/globals.cpp

@@ -1379,7 +1379,7 @@ void CBotGlobals::LoadBotModels()
 	std::strcat(path, "\\models\\player");
 #endif
 
-	if (stat(path, &stat_str) != 0)
+	if (stat(path, &stat_str) != 0 /*|| !HasSubDirectories(path)*/) //HasSubDirectories(path) fails on dedi servers? [APG]RoboCop[CL]
 	{
 		// use the valve/models/player directory if no valid MOD models/player
 #ifdef __linux__

dlls/util.cpp

@@ -577,7 +577,7 @@ int GetMessageID(const char* szMsg)
 	int msg_id = -1;
 
 #ifndef RCBOT_META_BUILD
-	CBotNetMessage* msg = NULL;
+	CBotNetMessage* msg = nullptr;
 	msg = gBotGlobals.m_NetEntityMessages.GetMessage(0, szMsg);
 	if (msg)
 		msg_id = msg->MessageNum();
@@ -859,11 +859,11 @@ int UTIL_GetNumClients(const bool bReport)
 #ifdef   DEBUG
 edict_t* DBG_EntOfVars(const entvars_t* pev)
 {
-	if (pev->pContainingEntity != NULL)
+	if (pev->pContainingEntity != nullptr)
 		return pev->pContainingEntity;
 	ALERT(at_console, "entvars_t pContainingEntity is NULL, calling into engine");
 	edict_t* pent = (*g_engfuncs.pfnFindEntityByVars)((entvars_t*)pev);
-	if (pent == NULL)
+	if (pent == nullptr)
 		ALERT(at_console, "DAMN!  Even the engine couldn't FindEntityByVars!");
 	((entvars_t*)pev)->pContainingEntity = pent;
 	return pent;