Skip to content

Commit 3162d3d

Browse files
committed
Portfolio: Replace currencies info dialog with general InfoDialog
1 parent b86868a commit 3162d3d

File tree

4 files changed

+14
-146
lines changed

4 files changed

+14
-146
lines changed

core/presentation/src/main/java/dev/arkbuilders/rate/core/presentation/ui/InfoDialog.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private fun Content(
8585
Text(
8686
modifier = Modifier.padding(top = 4.dp, start = 16.dp, end = 16.dp, bottom = 36.dp),
8787
text = desc,
88-
fontSize = 18.sp,
88+
fontSize = 14.sp,
8989
color = ArkColor.TextTertiary,
9090
)
9191
}

core/presentation/src/main/java/dev/arkbuilders/rate/core/presentation/ui/InfoMarketCapitalizationDialog.kt

Lines changed: 0 additions & 141 deletions
This file was deleted.

core/presentation/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
<string name="app_name">ARK Rate</string>
33
<string name="app_name_debug">ARK Rate [Debug]</string>
44

5+
<string name="info_dialog_market_capitalization">Market Capitalization</string>
56
<string name="info_dialog_market_capitalization_description">The total market value of a cryptocurrency\'s circulating supply.\n\nIt is analogous to the free-float capitalization in the stock market.\n\nCap = Current Price x Circulating Supply.</string>
7+
<string name="info_dialog_value_of_circulating">Value of Circulating Currency</string>
68
<string name="info_dialog_value_of_circulating_description">Currency in circulation refers to the amount of cash–in the form of paper notes or coins–within a country that is physically used to conduct transactions between consumers and businesses.</string>
79

810
<string name="bottom_nav_portfolio">Portfolios</string>

feature/portfolio/src/main/java/dev/arkbuilders/rate/feature/portfolio/presentation/edit/EditAssetScreen.kt

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ import dev.arkbuilders.rate.core.presentation.theme.ArkColor
4848
import dev.arkbuilders.rate.core.presentation.ui.AppHorDiv
4949
import dev.arkbuilders.rate.core.presentation.ui.AppTopBarBack
5050
import dev.arkbuilders.rate.core.presentation.ui.ArkCursorLargeTextField
51-
import dev.arkbuilders.rate.core.presentation.ui.InfoMarketCapitalizationDialog
52-
import dev.arkbuilders.rate.core.presentation.ui.InfoValueOfCirculatingDialog
51+
import dev.arkbuilders.rate.core.presentation.ui.InfoDialog
5352
import dev.arkbuilders.rate.core.presentation.ui.LoadingScreen
5453
import dev.arkbuilders.rate.feature.portfolio.di.PortfolioComponentHolder
5554
import dev.arkbuilders.rate.feature.search.presentation.destinations.SearchCurrencyScreenDestination
@@ -114,11 +113,19 @@ private fun Content(
114113
}
115114

116115
if (showMarketCapitalizationDialog) {
117-
InfoMarketCapitalizationDialog { showMarketCapitalizationDialog = false }
116+
InfoDialog(
117+
title = stringResource(id = CoreRString.info_dialog_market_capitalization),
118+
desc = stringResource(id = CoreRString.info_dialog_market_capitalization_description),
119+
onDismiss = { showMarketCapitalizationDialog = false },
120+
)
118121
}
119122

120123
if (showValueOfCirculatingDialog) {
121-
InfoValueOfCirculatingDialog { showValueOfCirculatingDialog = false }
124+
InfoDialog(
125+
title = stringResource(id = CoreRString.info_dialog_value_of_circulating),
126+
desc = stringResource(id = CoreRString.info_dialog_value_of_circulating_description),
127+
onDismiss = { showValueOfCirculatingDialog = false },
128+
)
122129
}
123130

124131
Column(

0 commit comments

Comments
 (0)