Implement suggestions from cargo clippy (#100)

Author: MateoGiraz

ark-cli/src/models/storage.rs

@@ -376,10 +376,7 @@ impl Storage {
                                 false
                             }
                         })
-                        .filter_map(|e| match AtomicFile::new(e.path()) {
-                            Ok(file) => Some(file),
-                            Err(_) => None,
-                        });
+                        .filter_map(|e| AtomicFile::new(e.path()).ok());
 
                     writeln!(
                         output,

drop-core/src/lib.rs

@@ -386,8 +386,6 @@ mod test {
         sync::{mpsc::channel, Arc},
     };
 
-    use tokio;
-
     use crate::{FileTransfer, IrohInstance};
 
     #[tokio::test]
@@ -430,7 +428,7 @@ mod test {
         let ticket = send_instance.send_files(files).await.unwrap();
         let ticket_str = ticket.to_string();
 
-        let (tx, mut rx) = channel::<Vec<FileTransfer>>();
+        let (tx, _rx) = channel::<Vec<FileTransfer>>();
         let handle = Arc::new(crate::FileTransferHandle(tx)); // Assuming FileTransferHandle wraps the sender
 
         let collection = receive_instance

fs-index/src/tests.rs

@@ -923,7 +923,7 @@ fn test_track_modification_with_collision() {
 /// - Move the file to a subdirectory.
 /// - Call `update_one()` 2 times with the relative path of the moved file.
 /// - Assert that the index contains the expected number of entries with the
-///  correct IDs and paths after the move.
+/// - correct IDs and paths after the move.
 #[test]
 fn test_track_move_to_subdirectory() {
     for_each_type!(Crc32, Blake3 => {

fs-storage/src/folder_storage.rs

@@ -497,7 +497,7 @@ mod tests {
         storage.set("key1".to_string(), "value1".to_string());
         storage.set("key1".to_string(), "value2".to_string());
         assert!(storage.write_fs().is_ok());
-        assert_eq!(temp_dir.path().exists(), true);
+        assert!(temp_dir.path().exists());
 
         if let Err(err) = storage.erase() {
             panic!("Failed to delete folder: {:?}", err);
@@ -514,13 +514,13 @@ mod tests {
         storage.write_fs().unwrap();
 
         storage.set("key1".to_string(), "value1".to_string());
-        let before_write = fs::metadata(&temp_dir.path())
+        let before_write = fs::metadata(temp_dir.path())
             .unwrap()
             .modified()
             .unwrap();
         thread::sleep(Duration::from_millis(10));
         storage.write_fs().unwrap();
-        let after_write = fs::metadata(&temp_dir.path())
+        let after_write = fs::metadata(temp_dir.path())
             .unwrap()
             .modified()
             .unwrap();
@@ -616,7 +616,7 @@ mod tests {
 
             for _ in 0..size {
                 let op = match u8::arbitrary(g) % 9 {
-                    0 | 1 | 2 | 3 | 4 => {
+                    0..=4 => {
                         let key = u8::arbitrary(g).to_string();
                         existing_keys.insert(key.clone());
                         StorageOperation::Set(key)
@@ -682,7 +682,7 @@ mod tests {
         let path = temp_dir.path();
 
         let mut storage =
-            FolderStorage::<String, Dummy>::new("test".to_string(), &path)
+            FolderStorage::<String, Dummy>::new("test".to_string(), path)
                 .unwrap();
         let mut expected_data: BTreeMap<String, Dummy> = BTreeMap::new();
         let mut pending_deletes = BTreeSet::new();
@@ -797,11 +797,11 @@ mod tests {
         let ram_newer = ram_newer
             || pending_sets
                 .iter()
-                .any(|(k, v)| pending_external.get(k).map_or(true, |e| v > e));
+                .any(|(k, v)| pending_external.get(k).is_none_or(|e| v > e));
         let disk_newer = pending_external
             .iter()
             .filter(|(k, _)| !pending_deletes.contains(*k))
-            .any(|(k, v)| pending_sets.get(k).map_or(true, |s| v > s));
+            .any(|(k, v)| pending_sets.get(k).is_none_or(|s| v > s));
 
         match (ram_newer, disk_newer) {
             (false, false) => SyncStatus::InSync,