✨ Add support for specifying the directory in subprocess commands (#857)

<!--
Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors.
All rights reserved.
SPDX-License-Identifier: Apache-2.0
-->
### Description

<!--
Please add any detail or context that would be useful to a reviewer.
-->

Add support for specifying the directory in subprocess commands

### Test Coverage

<!--
Please put an `x` in the correct box e.g. `[x]` to indicate the testing
coverage of this change.
-->

- [x]  This change is covered by existing or additional automated tests.
- [ ] Manual testing has been performed (and evidence provided) as
automated testing was not feasible.
- [ ] Additional tests are not required for this change (e.g.
documentation update).

Author: joshjennings98

changes/20260422120133.feature

@@ -0,0 +1 @@
+:sparkles: Add support for specifying the directory in subprocess commands

utils/subprocess/command_wrapper.go

@@ -128,6 +128,7 @@ type command struct {
 	loggers    logs.Loggers
 	cmdWrapper cmdWrapper
 	io         ICommandIO
+	dir        string
 }
 
 func (c *command) createCommand(cmdCtx context.Context) *exec.Cmd {
@@ -140,6 +141,7 @@ func (c *command) createCommand(cmdCtx context.Context) *exec.Cmd {
 	cmd.Stdin, cmd.Stdout, cmd.Stderr = c.io.Register(cmdCtx)
 	cmd.Env = cmd.Environ()
 	cmd.Env = append(cmd.Env, c.env...)
+	cmd.Dir = c.dir
 
 	// for any of our wait checks to work we need to set the group ID to the pid, otherwise the
 	// group ID will be the code that launched it (i.e. the code that calls exec.Cmd.Start). This
@@ -178,7 +180,7 @@ func (c *command) Check() (err error) {
 	return
 }
 
-func newCommand(loggers logs.Loggers, as *commandUtils.CommandAsDifferentUser, env []string, cmd string, args ...string) (osCmd *command) {
+func newCommand(loggers logs.Loggers, as *commandUtils.CommandAsDifferentUser, env []string, dir string, cmd string, args ...string) (osCmd *command) {
 	osCmd = &command{
 		cmd:        cmd,
 		args:       args,
@@ -187,11 +189,12 @@ func newCommand(loggers logs.Loggers, as *commandUtils.CommandAsDifferentUser, e
 		loggers:    loggers,
 		cmdWrapper: cmdWrapper{},
 		io:         NewIOFromLoggers(loggers),
+		dir:        dir,
 	}
 	return
 }
 
-func newCommandWithCustomIO(loggers logs.Loggers, io ICommandIO, as *commandUtils.CommandAsDifferentUser, env []string, cmd string, args ...string) (osCmd *command) {
+func newCommandWithCustomIO(loggers logs.Loggers, io ICommandIO, as *commandUtils.CommandAsDifferentUser, env []string, dir string, cmd string, args ...string) (osCmd *command) {
 	osCmd = &command{
 		cmd:        cmd,
 		args:       args,
@@ -200,6 +203,7 @@ func newCommandWithCustomIO(loggers logs.Loggers, io ICommandIO, as *commandUtil
 		loggers:    loggers,
 		cmdWrapper: cmdWrapper{},
 		io:         io,
+		dir:        dir,
 	}
 	return
 }

utils/subprocess/command_wrapper_test.go

@@ -56,9 +56,9 @@ func TestCmdRun(t *testing.T) {
 			loggers, err := logs.NewLogrLogger(logstest.NewTestLogger(t), "test")
 			require.NoError(t, err)
 			if platform.IsWindows() {
-				cmd = newCommand(loggers, commandUtils.Me(), nil, test.cmdWindows, test.argWindows...)
+				cmd = newCommand(loggers, commandUtils.Me(), nil, "", test.cmdWindows, test.argWindows...)
 			} else {
-				cmd = newCommand(loggers, commandUtils.Me(), nil, test.cmdOther, test.argOther...)
+				cmd = newCommand(loggers, commandUtils.Me(), nil, "", test.cmdOther, test.argOther...)
 			}
 			ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 			defer cancel()
@@ -94,7 +94,7 @@ func TestCmdRunWithEnv(t *testing.T) {
 		if platform.IsWindows() {
 			cmd = newCommand(loggers, commandUtils.Me(), envTest.envVars, "powershell", "-Command", envTest.cmdWindows)
 		} else {
-			cmd = newCommand(loggers, commandUtils.Me(), envTest.envVars, envTest.cmdOther)
+			cmd = newCommand(loggers, commandUtils.Me(), envTest.envVars, "", envTest.cmdOther)
 		}
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
@@ -146,9 +146,9 @@ func TestCmdStartStop(t *testing.T) {
 			require.NoError(t, err)
 
 			if platform.IsWindows() {
-				cmd = newCommand(loggers, commandUtils.Me(), nil, test.cmdWindows, test.argWindows...)
+				cmd = newCommand(loggers, commandUtils.Me(), nil, "", test.cmdWindows, test.argWindows...)
 			} else {
-				cmd = newCommand(loggers, commandUtils.Me(), nil, test.cmdOther, test.argOther...)
+				cmd = newCommand(loggers, commandUtils.Me(), nil, "", test.cmdOther, test.argOther...)
 			}
 			ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 			defer cancel()