Integrate LR1110 and mbed-os

[kvkc97]

I want t use LR1110 as the LoRa driver for the lorawan example code. I have added the LR1110 driver in mbed-os\connectivity\drivers\lora folder. A pull request for the same was added to the mbed-os and link is given below.
ARMmbed/mbed-os#14560
I am using MBED CLI2 to compile and added STM32WB55RGV6 as a custom target (Custom target addition and compilation was successful). I modified the lora_radio_helper.h file to include the lr1110 driver. The file is attached.
lora_radio_helper.txt

I am getting compilation error as attached.

[0xc0170]

First, the config should be all uppercase (lr1110). Can you check if mbed_config.h contians the definitions that are missing?

[0xc0170]

If you look at drivers, for instance GEMALTO, you can find mbed_lib.json config where pins are defined

{
    "name": "GEMALTO_CINTERION",
    "config": {
        "tx": {
            "help": "TX pin for serial connection. D1 assumed if Arduino Form Factor, needs to be set/overwritten otherwise.",
            "value": null
        },
        "rx": {
            "help": "RX pin for serial connection. D0 assumed if Arduino Form Factor, needs to be set/overwritten otherwise.",
            "value": null
        },
        "rts": {
            "help": "RTS pin for serial connection",
            "value": null
        },
        "cts": {
            "help": "CTS pin for serial connection",
            "value": null
        },
        "baudrate" : {
            "help": "Serial connection baud rate",
            "value": 115200
        },
        "provide-default": {
            "help": "Provide as default CellularDevice [true/false]",
            "value": false
        }
    }
}

I assume you need something similar for your radio driver

[kvkc97]

I do not have mbed_config.h file in my application. Do I need to create one?
Also I can find a mbed_lib.json file in mbed-os\drivers folder but not in the connectivity folder. Is this file to be created?

[0xc0170]

If your app is using the config values, they need to come from somewhere. You should add mbed_lib.json to your driver you are adding. The default value I assume would be null. An application, would overwrite this to specific layout you got on your board.

This should fix the issue.

[ciarmcom]

@kvkc97 This issue has an incomplete or old issue template.For future reference please use an up to date clone of the repository before raising issues. Many thanks.

[ciarmcom]

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-3860

[kvkc97]

I have added the mbed_lib.json file but still could not understand how and where to define the MBED_CONF_LR1110 variables. I have attached the mbed_lib.json file.

[jeromecoutant]

Check cmake_build//develop/GCC_ARM/mbed-os/compile_time_defs.txt

[kvkc97]

I checked the above mentioned file and found the variables but could not understand how to move forward with it. Also in the mbed_lib.json file, I have added value NC for spi-mosi, spi-miso and spi-sclk and an error is generated in command prompt. I have attached the error and also the mbed-lib.json file and the compile_time_defs.txt file.
compile_time_defs.txt

mbed-lib.json file

Compiler error

[jeromecoutant]

Definition looks OK in mbed_lib.json.
Then you are supposed to define them in your local mbed_app.json
"lr1110-lora-driver.spi-mosi":"XXX"

[kvkc97]

I updated the mbed_app.json file with pin names as per the mentioned format and the following error is obtained.

Below is my mbed_app.json file where MYTARGET is custom target for STM32WB55RGV6. I tried to give pin names fr the macros corresponding to SX1272 and it worked properly. I have added all the required pin connections in the below image while checking whether that was the issue. But it was not the issue and error is still the same. I have attached the updated error image also.

[kvkc97]

Can I have an update regarding this issue.
@jeromecoutant @0xc0170 @matthieuantoine