fix #260 (don't pass a Spec where a version requirement string is expected; add a test for this)

Author: James Crosby

yotta/lib/access.py

@@ -239,11 +239,15 @@ def satisfyVersionFromSearchPaths(name, version_required, search_paths, update=F
         versions of the found component, and update it in-place (unless it was
         installed via a symlink).
     '''
-    spec = sourceparse.parseSourceURL(version_required).semanticSpec()
     v    = None
 
     try:
-        local_version = searchPathsFor(name, spec, search_paths, type)
+        local_version = searchPathsFor(
+            name,
+            sourceparse.parseSourceURL(version_required).semanticSpec(),
+            search_paths,
+            type
+        )
     except pack.InvalidDescription as e:
         logger.error(e)
         return None
@@ -252,7 +256,7 @@ def satisfyVersionFromSearchPaths(name, version_required, search_paths, update=F
     if local_version:
         if update and not local_version.installedLinked():
             #logger.debug('attempt to check latest version of %s @%s...' % (name, version_required))
-            v = latestSuitableVersion(name, spec, registry=_registryNamespaceForType(type))
+            v = latestSuitableVersion(name, version_required, registry=_registryNamespaceForType(type))
             if local_version:
                 local_version.setLatestAvailable(v)
 

yotta/test/cli/install.py

@@ -73,7 +73,7 @@
     }
   ],
   "dependencies": {
-    "test-testdep-b": "*",
+    "test-testdep-b": "0.0.8",
     "test-testdep-c": "*",
     "test-testdep-d": "*"
   },
@@ -202,6 +202,9 @@ def test_installComplexDeps(self):
         self.assertNotIn('test-testdep-j', stdout)
         self.assertNotIn('test-testdep-k', stdout)
 
+        # test update
+        stdout = self.runCheckCommand(['--target', Test_Target, 'up'], test_dir)
+
         rmRf(test_dir)
 
     @unittest.skipIf(not hasGithubConfig(), "a github authtoken must be specified for this test (run yotta login, or set YOTTA_GITHUB_AUTHTOKEN)")