Skip to content

Commit a20ede7

Browse files
committed
CI: matrix Django 4.2/5.2 and add OpenID tests
Mirror the new tox django{42,52} factors in .github/workflows/tests.yml so both LTS lines are exercised on every push. Also extend the test command to include askbot.deps.django_authopenid.tests, which previously were only reachable via tox.
1 parent 975a9a0 commit a20ede7

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/tests.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ jobs:
1212
max-parallel: 4
1313
matrix:
1414
python-version: [3.10.16, 3.11.7, 3.12.3]
15+
django-version: ['4.2', '5.2']
1516

1617
# services:
1718
# postgres:
@@ -45,13 +46,18 @@ jobs:
4546
pip install setuptools-rust
4647
# install from pyproject.toml
4748
python -m pip install .
49+
# pin Django to the matrix factor so both LTS lines get exercised
50+
case "${{ matrix.django-version }}" in
51+
4.2) pip install "django>=4.2,<5.0" ;;
52+
5.2) pip install "django>=5.2,<5.3" ;;
53+
esac
4854
pip install -r requirements-tests.txt
4955
cat askbot_setup_test_inputs.txt | askbot-setup
5056
- name: Run tests
5157
run: |
5258
cd askbot_site
5359
ln -s ../askbot/tests .
54-
python manage.py test --parallel auto tests
60+
python manage.py test --parallel auto tests askbot.deps.django_authopenid.tests
5561
# env:
5662
# # Variables for unit tests
5763
# DJANGO_SETTINGS_MODULE: settings

askbot/doc/source/changelog.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ Development (not yet released)
77
Django pin is now ``>=4.2,<5.3``. Replaced removed APIs
88
(``get_storage_class``, ``ping_google``), made ``_fixture_setup``
99
compatible with Django 5.x's classmethod signature, and adjusted
10-
timezone handling for ``USE_TZ=True`` defaults. ``tox.ini`` now
11-
exercises both ``django42`` and ``django52`` factors.
10+
timezone handling for ``USE_TZ=True`` defaults. ``tox.ini`` and the
11+
GitHub Actions workflow now exercise both ``django42`` and ``django52``
12+
factors, and the workflow also runs the django_authopenid tests.
1213

1314
* Django 5.2 LTS preparation (no Django bump yet): removed
1415
``default_app_config``, dropped legacy ``Signal(providing_args=...)``,

0 commit comments

Comments
 (0)