Mp4 support #75
Merged
Mp4 support #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asrono
commented
Aug 28, 2025
| @@ -1,8 +1,10 @@ | |||
| module PPTX | |||
|
|
|||
| using XMLDict | |||
There was a problem hiding this comment.
now in alphabetical order
asrono
commented
Aug 28, 2025
| function Picture(source::String, offset_x::Int, offset_y::Int, size_x::Int, size_y::Int, rid::Int) | ||
| new(source, offset_x, offset_y, size_x, size_y, rid, string(UUIDs.uuid4())) | ||
| end | ||
| function Picture(source::String, offset_x::Int, offset_y::Int, size_x::Int, size_y::Int, rid::Int, uuid::String) |
There was a problem hiding this comment.
I use a second constructor to make sure no uuid is generated for the thumbnail
|
Looks great! Thanks for this PR! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 87.94% 83.59% -4.35%
==========================================
Files 9 10 +1
Lines 821 951 +130
==========================================
+ Hits 722 795 +73
- Misses 99 156 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created some mp4 files with Julia and would like to be able to add them to a ppt.