From b6b304691f5f11fde1e4e14304e4909ffb0cae03 Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Mon, 21 Apr 2025 14:10:19 -0300 Subject: [PATCH 1/3] fix(components-core): added tabindex and focus css for accordion wrapper UDS-1992 --- .../components-core/src/components/Accordion/index.js | 2 +- .../unity-bootstrap-theme/src/scss/extends/_cards.scss | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/components-core/src/components/Accordion/index.js b/packages/components-core/src/components/Accordion/index.js index 3522c63759..2e6268eeed 100644 --- a/packages/components-core/src/components/Accordion/index.js +++ b/packages/components-core/src/components/Accordion/index.js @@ -58,7 +58,7 @@ const Accordion = ({ cards, openedCard }) => { }; return ( -
+
{cards?.map( (card, key) => card.content.body && diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss index d165381a1c..ee4839973b 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss @@ -691,6 +691,15 @@ Cards - Table of Contents 7. Accordion --------------------------------------------------------------------*/ .accordion { + + &:focus { + outline: none!important; + box-shadow: 0 0 0 1px $uds-color-base-gray-7 !important; + border: 1px solid $uds-color-base-gray-7 !important; + margin: 4px; + width: -webkit-fill-available; + } + .accordion-item { border-bottom: 1px solid $uds-color-base-gray-3; border-top: 1px solid $uds-color-base-gray-3; From 2dd45e2b919a8010bb4d1da56ec4c1749bbe240a Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Tue, 13 May 2025 08:46:57 -0300 Subject: [PATCH 2/3] fix(components-core): removed tabIndex 0 from Accordion UDS-1992 --- packages/components-core/src/components/Accordion/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components-core/src/components/Accordion/index.js b/packages/components-core/src/components/Accordion/index.js index 2e6268eeed..3522c63759 100644 --- a/packages/components-core/src/components/Accordion/index.js +++ b/packages/components-core/src/components/Accordion/index.js @@ -58,7 +58,7 @@ const Accordion = ({ cards, openedCard }) => { }; return ( -
+
{cards?.map( (card, key) => card.content.body && From a55da8a5157d3a6e6e4be1aeda89ed443c749270 Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Fri, 6 Jun 2025 14:53:10 -0300 Subject: [PATCH 3/3] fix(unity-bootstrap-theme): split padding value to margin and padding UDS-1992 --- .../src/scss/extends/_cards.scss | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss index ee4839973b..a4143354b0 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_cards.scss @@ -553,7 +553,8 @@ Cards - Table of Contents margin: 0; a, button { - padding: 1rem var(--card-child-padding); + margin: .4rem .3rem; + padding: .6rem .7rem; color: $uds-color-base-gray-7; text-decoration: none; display: flex; @@ -692,14 +693,6 @@ Cards - Table of Contents --------------------------------------------------------------------*/ .accordion { - &:focus { - outline: none!important; - box-shadow: 0 0 0 1px $uds-color-base-gray-7 !important; - border: 1px solid $uds-color-base-gray-7 !important; - margin: 4px; - width: -webkit-fill-available; - } - .accordion-item { border-bottom: 1px solid $uds-color-base-gray-3; border-top: 1px solid $uds-color-base-gray-3;