From ada0d677de7c9701e8225a6af6353f93e9d1be8b Mon Sep 17 00:00:00 2001 From: david ornelas Date: Wed, 23 Apr 2025 20:30:39 -0700 Subject: [PATCH 1/6] fix(unity-react-core): change class of header ranking card for styling --- .../src/components/RankingCard/RankingCard.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx b/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx index 8df2fcd34..e085dec43 100644 --- a/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx +++ b/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx @@ -82,7 +82,7 @@ const InfoLayerWrapper = ({ imageSize, body, heading, readMoreLink }) => { {isSmall ? ( {heading} ) : ( -

{heading}

+

{heading}

)} @@ -148,7 +148,7 @@ export const RankingCard = ({ {isSmall && (
-

{heading}

+

{heading}

— {citation}

)} From bbe32720cec059a2b8d8a52fd05413b942b592a2 Mon Sep 17 00:00:00 2001 From: david ornelas Date: Wed, 23 Apr 2025 20:32:00 -0700 Subject: [PATCH 2/6] fix(unity-bootstrap-theme): update ranking card styles --- .../src/scss/extends/_ranking-cards.scss | 50 +++++++++++-------- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss index a7b65143a..991f06927 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss @@ -4,13 +4,15 @@ border: 1px solid $uds-color-base-gray-3; overflow: hidden; + --ranking-card-text-padding: 1.25rem; + .info-layer { display: flex; flex-direction: column; position: absolute; bottom: 0; left: 0; - padding: $uds-size-spacing-1 $uds-size-spacing-3 0; + padding: $uds-size-spacing-2 var(--ranking-card-text-padding) 0; border-top: $uds-size-spacing-1 solid #ffc627; transition: all 0.3s ease-in-out; z-index: 10; @@ -19,6 +21,10 @@ cursor: pointer; .content { + display: flex; + flex-direction: column; + justify-content: space-between; + max-height: calc(100% - $uds-size-spacing-2); flex-grow: 1; .header { @@ -27,7 +33,6 @@ justify-content: space-between; .btn-expand { - margin: 0 0 0 $uds-size-spacing-1; padding: 0; background-color: unset; border: none; @@ -57,14 +62,15 @@ display: -webkit-box; -webkit-box-orient: vertical; overflow: hidden; - font-size: 0.875rem; - line-height: 1.25rem; + font-size: $uds-size-font-tiny; -webkit-line-clamp: 3; + line-clamp: 3; } - >a { + >a.read-more { font-size: $uds-size-font-small; font-weight: 600; + margin-top: auto; .icon-small { margin-left: 5px; @@ -91,7 +97,8 @@ >p, .header>p { - -webkit-line-clamp: 12; + line-clamp: 18; + -webkit-line-clamp: 18; } } } @@ -126,7 +133,7 @@ } .info-layer { - padding: 1.5rem .5rem 0 1.5rem; + padding: var(--ranking-card-text-padding) .5rem 0 var(--ranking-card-text-padding); cursor: unset; a.read-more { display: none; @@ -143,11 +150,8 @@ .content { .header { - >p { - width: 90%; - } .btn-expand { - padding: .6rem; + padding: .5rem; border-radius: 0; } } @@ -155,8 +159,12 @@ } .citation { - padding-left: $uds-size-spacing-3; - padding-right: $uds-size-spacing-3; + padding-left: var(--ranking-card-text-padding); + padding-right: var(--ranking-card-text-padding); + + p { + font-size: $uds-size-font-small; + } } } @@ -182,26 +190,28 @@ .info-layer { .content { + .header { + padding-bottom: var(--ranking-card-text-padding); .btn-expand { display: flex; justify-content: space-between; align-items: baseline; h4 { - min-height: 52px; // To avoid having only one line - max-width: 300px; // To avoid having only one line - margin: 0 0 $uds-size-spacing-3; + margin: 0; -webkit-line-clamp: 2; + line-clamp: 2; } } } > p { - line-clamp: 10; - -webkit-line-clamp: 10; + line-clamp: 13; + -webkit-line-clamp: 13; visibility: hidden; transition: visibility .3s ease-in; + margin: 0; } a.read-more { @@ -215,8 +225,8 @@ .content { .header { h4 { - min-height: unset; - max-height: unset; + display: block; + } } From 25506a2dde022c9f23e7c664c285487c05725c2f Mon Sep 17 00:00:00 2001 From: david ornelas Date: Wed, 23 Apr 2025 21:00:15 -0700 Subject: [PATCH 3/6] fix(unity-bootstrap-theme): update line clamp for ranking card --- .../src/scss/extends/_ranking-cards.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss index 991f06927..e7612c008 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss @@ -23,7 +23,6 @@ .content { display: flex; flex-direction: column; - justify-content: space-between; max-height: calc(100% - $uds-size-spacing-2); flex-grow: 1; @@ -54,6 +53,8 @@ i.fa-chevron-up { transition: all 0.3s ease-in-out; color: $uds-color-base-gray-7; + height: .875rem; + width: .875rem; } } @@ -195,7 +196,6 @@ padding-bottom: var(--ranking-card-text-padding); .btn-expand { display: flex; - justify-content: space-between; align-items: baseline; h4 { @@ -207,8 +207,8 @@ } > p { - line-clamp: 13; - -webkit-line-clamp: 13; + line-clamp: 15; + -webkit-line-clamp: 15; visibility: hidden; transition: visibility .3s ease-in; margin: 0; From 1492e295c87344b42482947d002fdb779a39e5c5 Mon Sep 17 00:00:00 2001 From: david ornelas Date: Wed, 30 Apr 2025 15:14:22 -0700 Subject: [PATCH 4/6] fix(unity-bootstrap-theme): update ranking card styles --- .../src/scss/extends/_ranking-cards.scss | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss index e7612c008..d2ff827c2 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss @@ -4,7 +4,7 @@ border: 1px solid $uds-color-base-gray-3; overflow: hidden; - --ranking-card-text-padding: 1.25rem; + --ranking-card-text-padding: 1.5rem; .info-layer { display: flex; @@ -50,11 +50,10 @@ } svg.fa-chevron-up, - i.fa-chevron-up { + i.fa-chevron-up, + .fa-chevron-up { transition: all 0.3s ease-in-out; color: $uds-color-base-gray-7; - height: .875rem; - width: .875rem; } } @@ -63,13 +62,13 @@ display: -webkit-box; -webkit-box-orient: vertical; overflow: hidden; - font-size: $uds-size-font-tiny; + font-size: $uds-size-font-small; + line-height: 1.2rem; -webkit-line-clamp: 3; line-clamp: 3; } >a.read-more { - font-size: $uds-size-font-small; font-weight: 600; margin-top: auto; @@ -98,8 +97,8 @@ >p, .header>p { - line-clamp: 18; - -webkit-line-clamp: 18; + line-clamp: 22; + -webkit-line-clamp: 22; } } } @@ -164,7 +163,7 @@ padding-right: var(--ranking-card-text-padding); p { - font-size: $uds-size-font-small; + font-size: $uds-size-font-medium; } } } @@ -207,8 +206,8 @@ } > p { - line-clamp: 15; - -webkit-line-clamp: 15; + line-clamp: 18; + -webkit-line-clamp: 18; visibility: hidden; transition: visibility .3s ease-in; margin: 0; From 40f371137789d9b71af8a85e03427dc6c7b8c017 Mon Sep 17 00:00:00 2001 From: david ornelas Date: Wed, 30 Apr 2025 15:14:56 -0700 Subject: [PATCH 5/6] fix(unity-react-core): update jsx for ranking card --- .../src/components/RankingCard/RankingCard.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx b/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx index e085dec43..c4ca99c2c 100644 --- a/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx +++ b/packages/unity-react-core/src/components/RankingCard/RankingCard.jsx @@ -82,7 +82,7 @@ const InfoLayerWrapper = ({ imageSize, body, heading, readMoreLink }) => { {isSmall ? ( {heading} ) : ( -

{heading}

+

{heading}

)} @@ -148,7 +148,7 @@ export const RankingCard = ({ {isSmall && (
-

{heading}

+

{heading}

— {citation}

)} From f6e6ea90160ed8b46fe8e2d4785092e8975e2998 Mon Sep 17 00:00:00 2001 From: david ornelas Date: Fri, 16 May 2025 16:49:32 -0700 Subject: [PATCH 6/6] fix(unity-bootstrap-theme): update ranking card styles --- .../src/scss/extends/_ranking-cards.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss index d2ff827c2..83270a37c 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_ranking-cards.scss @@ -196,6 +196,7 @@ .btn-expand { display: flex; align-items: baseline; + justify-content: space-between; h4 { margin: 0; @@ -206,8 +207,8 @@ } > p { - line-clamp: 18; - -webkit-line-clamp: 18; + line-clamp: 15; + -webkit-line-clamp: 15; visibility: hidden; transition: visibility .3s ease-in; margin: 0;