Skip to content

Commit e584b92

Browse files
gmrclaude
andcommitted
Wire IMBI_INTERNAL_API_URL for the new imbi-mcp split
The imbi-mcp submodule bump in this PR moves the in-cluster API URL from IMBI_API_URL to IMBI_INTERNAL_API_URL; imbi-assistant uses the same env var for the same role. The default of http://localhost:8000 is correct for the all-in-one image, but make the wiring explicit so helm split-service mode (mcp/assistant) can override it cleanly. - runtime/env-file: declare IMBI_INTERNAL_API_URL=http://localhost:8000 - helm: surface service.internalApiUrl and emit it into the configmap Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 851f15e commit e584b92

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

helm/imbi/templates/configmap.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ metadata:
66
{{- include "imbi.labels" . | nindent 4 }}
77
data:
88
IMBI_ASSISTANT_ENABLED: {{ .Values.assistant.enabled | quote }}
9+
# Internal upstream URL used by imbi-mcp and imbi-assistant for
10+
# service-to-service calls to imbi-api. Distinct from the API's
11+
# public URL. Defaults to the in-pod loopback for "all" mode; set
12+
# service.internalApiUrl when running imbi-mcp or imbi-assistant
13+
# as separate pods.
14+
IMBI_INTERNAL_API_URL: {{ .Values.service.internalApiUrl | quote }}
915
IMBI_EMAIL_ENABLED: {{ .Values.email.enabled | quote }}
1016
{{- if .Values.email.enabled }}
1117
IMBI_EMAIL_SMTP_HOST: {{ .Values.email.smtp.host | quote }}

helm/imbi/values.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ replicaCount: 1
1212
# Use the matching .service.<name>.replicas value to scale that service.
1313
service:
1414
mode: all
15+
# Internal upstream URL imbi-mcp and imbi-assistant use to reach
16+
# imbi-api. The default works for "all" and "api" modes; override
17+
# when running "mcp" or "assistant" as separate pods (e.g.
18+
# http://imbi-api.<namespace>.svc.cluster.local:8000).
19+
internalApiUrl: "http://localhost:8000"
1520
api:
1621
replicas: 1
1722
assistant:

runtime/env-file

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CLICKHOUSE_URL="clickhouse+http://default:password@clickhouse:8123/imbi"
22
IMBI_AUTH_ENCRYPTION_KEY="dev-encryption-key-change-in-prod"
33
IMBI_AUTH_JWT_SECRET="dev-jwt-secret-change-in-production"
4+
# Internal upstream URL used by imbi-mcp and imbi-assistant for
5+
# service-to-service calls to imbi-api. Distinct from IMBI_API_URL
6+
# (the API's public URL). Default targets the in-pod loopback used
7+
# by the all-in-one image.
8+
IMBI_INTERNAL_API_URL="http://localhost:8000"
49
IMBI_EMAIL_SMTP_HOST="mailpit"
510
IMBI_EMAIL_SMTP_PORT="1025"
611
IMBI_EMAIL_SMTP_USE_TLS="false"

0 commit comments

Comments
 (0)