Skip to content

DG review #128

@hckim0911

Description

@hckim0911
  • In the intro, I can't see any explanation for what this app aims and how it supports the aims.

  • I expected to see your architecture diagram to have a sense for your app but you haven't updated it yet.

  • UI component hasn't updated from address book 3.

  • It seems you have updated your logic component, however, I can't see it clearly because now all contents in your DG is mixed with pre-existing contents from AB3.

  • Figure 6 is quite nice.

  • Figure 7 is quite nice.

  • Model component is well described with nice diagrams.

  • I think the Storage component hasn't updated from address book 3.
    -> Did you update it? it seems a bit different from the AB3's one but I can't find what is exactly different.

Below this section, it seems many parts are still not updated.
I am a bit worried about your DG because many things haven't updated properly.
I encourage you to update it as soon as possible because its portion for grading is quite large.
If you have any questions, you can email me at any time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions