Skip to content

Commit 4f8ffc5

Browse files
authored
Merge pull request #156 from AY1920S2-CS2103T-F10-3/branch-merge
Merge branch-merge to master
2 parents 5ba0942 + 3c1d97a commit 4f8ffc5

File tree

214 files changed

+4062
-1819
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

214 files changed

+4062
-1819
lines changed

build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ plugins {
1515
}
1616

1717
// Specifies the entry point of the application
18-
mainClassName = 'seedu.address.Main'
18+
mainClassName = 'seedu.nova.Main'
1919

2020
sourceCompatibility = JavaVersion.VERSION_11
2121
targetCompatibility = JavaVersion.VERSION_11
@@ -67,7 +67,7 @@ dependencies {
6767
}
6868

6969
shadowJar {
70-
archiveName = 'addressbook.jar'
70+
archiveName = 'nova.jar'
7171

7272
destinationDir = file("${buildDir}/jar/")
7373
}
@@ -133,7 +133,7 @@ asciidoctor {
133133
idprefix: '', // for compatibility with GitHub preview
134134
idseparator: '-',
135135
'site-root': "${sourceDir}", // must be the same as sourceDir, do not modify
136-
'site-name': 'NOVA',
136+
'site-name': 'nova',
137137
'site-githuburl': 'https://github.com/AY1920S2-CS2103T-F10-3/main',
138138
'site-seedu': true, // delete this line if your project is not a fork (not a SE-EDU project)
139139
]

docs/DeveloperGuide.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ The `UI` component,
9898
image::LogicClassDiagram.png[]
9999

100100
*API* :
101-
link:{repoURL}/src/main/java/seedu/address/logic/Logic.java[`Logic.java`]
101+
link:{repoURL}/src/main/java/seedu/nova/logic/Logic.java[`Logic.java`]
102102

103103
. `Logic` uses the `AddressBookParser` class to parse the user command.
104104
. This results in a `Command` object which is executed by the `LogicManager`.
@@ -119,7 +119,7 @@ NOTE: The lifeline for `DeleteCommandParser` should end at the destroy marker (X
119119
.Structure of the Model Component
120120
image::ModelClassDiagram.png[]
121121

122-
*API* : link:{repoURL}/src/main/java/seedu/address/model/Model.java[`Model.java`]
122+
*API* : link:{repoURL}/src/main/java/seedu/nova/model/Model.java[`Model.java`]
123123

124124
The `Model`,
125125

@@ -139,7 +139,7 @@ image:BetterModelClassDiagram.png[]
139139
.Structure of the Storage Component
140140
image::StorageClassDiagram.png[]
141141

142-
*API* : link:{repoURL}/src/main/java/seedu/address/storage/Storage.java[`Storage.java`]
142+
*API* : link:{repoURL}/src/main/java/seedu/nova/storage/Storage.java[`Storage.java`]
143143

144144
The `Storage` component,
145145

@@ -149,7 +149,7 @@ The `Storage` component,
149149
[[Design-Commons]]
150150
=== Common classes
151151

152-
Classes used by multiple components are in the `seedu.addressbook.commons` package.
152+
Classes used by multiple components are in the `seedu.nova.commons` package.
153153

154154
== Implementation
155155

@@ -365,7 +365,7 @@ _{More to be added}_
365365
[appendix]
366366
== Use Cases
367367

368-
(For all use cases below, the *System* is the `NOVA` and the *Actor* is the `student`, unless specified otherwise)
368+
(For all use cases below, the *System* is the `nova` and the *Actor* is the `student`, unless specified otherwise)
369369

370370
[discrete]
371371
=== Use case 1: Delete a contact

docs/Testing.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ See <<UsingGradle#, UsingGradle.adoc>> for more info on how to run tests using G
3535
We have three types of tests:
3636

3737
. _Unit tests_ targeting the lowest level methods/classes. +
38-
e.g. `seedu.address.commons.StringUtilTest`
38+
e.g. `seedu.NOVA.commons.StringUtilTest`
3939
. _Integration tests_ that are checking the integration of multiple code units (those code units are assumed to be working). +
40-
e.g. `seedu.address.storage.StorageManagerTest`
40+
e.g. `seedu.NOVA.storage.StorageManagerTest`
4141
. Hybrids of unit and integration tests. These test are checking multiple code units as well as how the are connected together. +
42-
e.g. `seedu.address.logic.LogicManagerTest`
42+
e.g. `seedu.NOVA.logic.LogicManagerTest`
4343

4444

4545
== Troubleshooting Testing

docs/templates/helpers.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ module Slim::Helpers
4545

4646
##
4747
# Creates an HTML tag with the given name and optionally attributes. Can take
48-
# a block that will run between the opening and closing tags.
48+
# a block that will run between the opening and closing categories.
4949
#
5050
# @param name [#to_s] the name of the tag.
5151
# @param attributes [Hash]
@@ -207,11 +207,11 @@ def html_meta_if(name, content)
207207
%(<meta name="#{name}" content="#{content}">) if content
208208
end
209209

210-
# Returns formatted style/link and script tags for header.
210+
# Returns formatted style/link and script categories for header.
211211
def styles_and_scripts
212212
scripts = []
213213
styles = []
214-
tags = []
214+
categories = []
215215

216216
stylesheet = attr :stylesheet
217217
stylesdir = attr :stylesdir, ''
@@ -280,21 +280,21 @@ def styles_and_scripts
280280

281281
styles.each do |item|
282282
if item.key?(:text)
283-
tags << html_tag(:style, {}, item[:text])
283+
categories << html_tag(:style, {}, item[:text])
284284
else
285-
tags << html_tag(:link, rel: 'stylesheet', href: urlize(*item[:href]))
285+
categories << html_tag(:link, rel: 'stylesheet', href: urlize(*item[:href]))
286286
end
287287
end
288288

289289
scripts.each do |item|
290290
if item.key? :text
291-
tags << html_tag(:script, {type: item[:type]}, item[:text])
291+
categories << html_tag(:script, {type: item[:type]}, item[:text])
292292
else
293-
tags << html_tag(:script, type: item[:type], src: urlize(*item[:src]))
293+
categories << html_tag(:script, type: item[:type], src: urlize(*item[:src]))
294294
end
295295
end
296296

297-
tags.join "\n"
297+
categories.join "\n"
298298
end
299299

300300
end

docs/tutorials/AddRemark.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ For now, let's keep `RemarkCommand` as simple as possible and print some output.
3434
We accomplish that by returning a `CommandResult` with an accompanying message.
3535

3636
.RemarkCommand.java
37-
[source, java]
37+
[source,java]
3838
----
39-
package seedu.address.logic.commands;
39+
package seedu.nova.logic.commands;
4040
41-
import seedu.address.model.Model;
41+
import seedu.nova.model.Model;
4242
4343
/**
4444
* Changes the remark of an existing person in the address book.
@@ -108,9 +108,9 @@ We start by modifying the constructor of `RemarkCommand` to accept an `Index` an
108108
While we are at it, let's change the error message to echo the values.
109109
While this is not a replacement for tests, it is an obvious way to tell if our code is functioning as intended.
110110

111-
[source, java]
111+
[source,java]
112112
----
113-
import static seedu.address.commons.util.CollectionUtil.requireAllNonNull;
113+
import static seedu.nova.commons.util.CollectionUtil.requireAllNonNull;
114114
//...
115115
public class RemarkCommand extends Command {
116116
//...
@@ -273,7 +273,7 @@ Simply add
273273
private Label remark;
274274
```
275275

276-
to link:https://github.com/nus-cs2103-AY1920S1/addressbook-level3/commit/2758455583f0101ed918a318fc75679270843a0d#diff-0c6b6abcfac8c205e075294f25e851fe[`seedu.address.ui.PersonCard`].
276+
to link:https://github.com/nus-cs2103-AY1920S1/addressbook-level3/commit/2758455583f0101ed918a318fc75679270843a0d#diff-0c6b6abcfac8c205e075294f25e851fe[`seedu.nova.ui.PersonCard`].
277277
`@FXML` is an annotation that marks a private or protected field and makes it accessible to FXML.
278278
It might sound like Greek to you right now, don't worry -- we will get back to it later.
279279

docs/tutorials/RemovingFields.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@ Perfection is achieved, not when there is nothing more to add, but when there is
1616
When working on Address Book, you will most likely find that some features and fields that are no longer necessary.
1717
In scenarios like this, you can consider refactoring the existing `Person` model to suit your use case.
1818

19-
In this tutorial, we'll do exactly just that and remove the `address` field from `Person`.
19+
In this tutorial, we'll do exactly just that and remove the `nova` field from `Person`.
2020

2121
== Safely deleting `Address`
2222

2323
Fortunately, the IntelliJ IDEA provides a robust refactoring tool that can identify _most_ usages.
2424
Let's try to use it as much as we can.
2525

2626
=== Assisted refactoring
27-
The `address` field in `Person` is actually an instance of the `seedu.address.model.person.Address` class.
27+
The `nova` field in `Person` is actually an instance of the `seedu.address.model.person.Address` class.
2828
Since removing the `Address` class will break the application, we start by identifying ``Address``'s usages.
2929
This allows us to see code that depends on `Address` to function properly and edit them on a case-by-case basis.
3030
Right-click the `Address` class and select `Refactor` > `Safe Delete` through the menu.
@@ -45,14 +45,14 @@ Other usages like in `EditPersonDescriptor` may require more careful inspection.
4545

4646
Let's try removing references to `Address` in `EditPersonDescriptor`.
4747

48-
. Safe delete the field `address` in `EditPersonDescriptor`
48+
. Safe delete the field `nova` in `EditPersonDescriptor`
4949
. Select `Yes` when prompted to remove getters and setters
5050
. Select `View Usages` again image:UnsafeDeleteOnField.png[width=1145px, height=583px]
51-
. Remove the usages of `address` and select `Do refactor` when you are done.
51+
. Remove the usages of `nova` and select `Do refactor` when you are done.
5252
+
5353
TIP: Removing usages may result in errors.
5454
Exercise discretion and fix them.
55-
For example, removing the `address` field from the `Person` class will require you to modify its constructor.
55+
For example, removing the `nova` field from the `Person` class will require you to modify its constructor.
5656

5757
. Repeat the steps for the remaining usages of `Address`
5858

@@ -61,7 +61,7 @@ After you are done, verify that the application still works by compiling and run
6161
=== Manual refactoring
6262

6363
Unfortunately, there are usages of `Address` that IntelliJ IDEA cannot identify.
64-
You can find them by searching for instances of the word `address` in your code (`Edit` > `Find` > `Find in path`).
64+
You can find them by searching for instances of the word `nova` in your code (`Edit` > `Find` > `Find in path`).
6565

6666
Places of interest to look out for would be resources used by the application.
6767
`main/resources` contains images and `fxml` files used by the application and `test/resources` contains test data.

src/main/java/seedu/address/logic/commands/AbListCommand.java

Lines changed: 0 additions & 24 deletions
This file was deleted.

src/main/java/seedu/address/logic/parser/AbEditCommandParser.java

Lines changed: 0 additions & 82 deletions
This file was deleted.

src/main/java/seedu/address/logic/parser/AbFindCommandParser.java

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)