Skip to content

DG Review #277

@okkhoy

Description

@okkhoy

Here are some comments and questions that may help you improve your DG.

  1. Product scoping on the landing page needs to be better articulated. It doesn't really indicate the target user profile.
  2. Kevin, Mingsi, Zain, and Sharad: please update a reasonable image for your mugshot.
  3. Is your architecture the same as AddressBook? If not, please update the architecture diagram,
  4. This figure:
    image
    Please update the note to reflect the actual commands you have instead of NewCommand, ModifyCommand etc.,
  5. Recipe and ingredient are 2 different things. Can you think of "all ingredients" to make a better OOP solution?
    image
  6. Possibly remove the Undo/Redo for 2 reasons (?):
    1. It is exactly same as AddressBook
    2. It is not implemented.
      In its place, you can include anything else pertaining to CookBuddy that you plan to do in future (maybe something in the "nice to have" user stories)
  7. Since the diagram is not very complicated (meaning you can still add something and it doesn't look messy), you can probably add a self-call activation bar here explicitly:
    image
  8. Please update Appendix F with details like the explicit commands etc.,

BTW, it looks like your DG is not completely updated to reflect your product. Please update it soon.
So read 6 above as: include details of what each of you have implemented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions