Merge pull request #326 from nottiffchan/refactor-code

Update test cases for CommandResult

Author: UncleGrandpa925

src/main/java/trackitnus/logic/commands/CommandResult.java

@@ -3,6 +3,7 @@
 import static java.util.Objects.requireNonNull;
 
 import java.util.Objects;
+
 import trackitnus.model.module.Module;
 
 /**

src/test/java/trackitnus/logic/commands/CommandResultTest.java

@@ -7,14 +7,18 @@
 
 import org.junit.jupiter.api.Test;
 
+import trackitnus.model.commons.Code;
+import trackitnus.model.commons.Name;
+import trackitnus.model.module.Module;
+
 public class CommandResultTest {
     @Test
     public void equals() {
         CommandResult commandResult = new CommandResult("feedback");
 
         // same values -> returns true
         assertTrue(commandResult.equals(new CommandResult("feedback")));
-        assertTrue(commandResult.equals(new CommandResult("feedback", false, false, "")));
+        assertTrue(commandResult.equals(new CommandResult("feedback", false, false, null, null, "")));
 
         // same object -> returns true
         assertTrue(commandResult.equals(commandResult));
@@ -29,10 +33,18 @@ public void equals() {
         assertFalse(commandResult.equals(new CommandResult("different")));
 
         // different showHelp value -> returns false
-        assertFalse(commandResult.equals(new CommandResult("feedback", true, false, "")));
+        assertFalse(commandResult.equals(new CommandResult("feedback", true, false, null, null, "")));
 
         // different exit value -> returns false
-        assertFalse(commandResult.equals(new CommandResult("feedback", false, true, "")));
+        assertFalse(commandResult.equals(new CommandResult("feedback", false, true, null, null, "")));
+
+        // edited module -> returns true
+        assertTrue(commandResult.equals(new CommandResult("feedback", false, false,
+            new Module(new Code("AA0000"), new Name("not edited")), new Module(new Code("AA0000"), new Name("after " +
+            "edited")), "")));
+
+        // deleted module -> returns true
+        assertTrue(commandResult.equals(new CommandResult("feedback", false, false, null, null, "AA0000")));
     }
 
     @Test
@@ -46,9 +58,11 @@ public void hashcode() {
         assertNotEquals(commandResult.hashCode(), new CommandResult("different").hashCode());
 
         // different showHelp value -> returns different hashcode
-        assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", true, false, "").hashCode());
+        assertNotEquals(commandResult.hashCode(),
+            new CommandResult("feedback", true, false, null, null, "").hashCode());
 
         // different exit value -> returns different hashcode
-        assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", false, true, "").hashCode());
+        assertNotEquals(commandResult.hashCode(),
+            new CommandResult("feedback", false, true, null, null, "").hashCode());
     }
 }

src/test/java/trackitnus/logic/commands/ExitCommandTest.java

@@ -14,7 +14,8 @@ public class ExitCommandTest {
 
     @Test
     public void execute_exit_success() {
-        CommandResult expectedCommandResult = new CommandResult(MESSAGE_EXIT_ACKNOWLEDGEMENT, false, true, "");
+        CommandResult expectedCommandResult = new CommandResult(MESSAGE_EXIT_ACKNOWLEDGEMENT, false, true, null, null,
+            "");
         assertCommandSuccess(new ExitCommand(), model, expectedCommandResult, expectedModel);
     }
 }

src/test/java/trackitnus/logic/commands/HelpCommandTest.java

@@ -14,7 +14,7 @@ public class HelpCommandTest {
 
     @Test
     public void execute_help_success() {
-        CommandResult expectedCommandResult = new CommandResult(SHOWING_HELP_MESSAGE, true, false, "");
+        CommandResult expectedCommandResult = new CommandResult(SHOWING_HELP_MESSAGE, true, false, null, null, "");
         assertCommandSuccess(new HelpCommand(), model, expectedCommandResult, expectedModel);
     }
 }