Add Checkstyle fixes

To pass the CI

-NOTE
ModelManager still need to write integration tests for MeetingBookStorage

Author: Maurice2n97

src/main/java/seedu/address/MainApp.java

@@ -24,7 +24,14 @@
 import seedu.address.model.person.AddressBook;
 import seedu.address.model.person.ReadOnlyAddressBook;
 import seedu.address.model.util.SampleDataUtil;
-import seedu.address.storage.*;
+import seedu.address.storage.AddressBookStorage;
+import seedu.address.storage.JsonAddressBookStorage;
+import seedu.address.storage.JsonMeetingBookStorage;
+import seedu.address.storage.JsonUserPrefsStorage;
+import seedu.address.storage.MeetingBookStorage;
+import seedu.address.storage.Storage;
+import seedu.address.storage.StorageManager;
+import seedu.address.storage.UserPrefsStorage;
 import seedu.address.ui.Ui;
 import seedu.address.ui.UiManager;
 

src/main/java/seedu/address/model/ModelManager.java

@@ -174,6 +174,8 @@ public void setMeeting(Meeting target, Meeting editedMeeting) {
         requireAllNonNull(target, editedMeeting);
         meetingBook.setMeeting(target, editedMeeting);
     }
+    //TODO: Set MeetingBook file path in userPrefs? low priority feature(nice to have)
+
     //=========== Filtered Person List Accessors =============================================================
 
     /**

src/main/java/seedu/address/storage/JsonMeetingBookStorage.java

@@ -1,5 +1,7 @@
 package seedu.address.storage;
 
+import static java.util.Objects.requireNonNull;
+
 import java.io.IOException;
 import java.nio.file.Path;
 import java.util.Optional;
@@ -14,8 +16,6 @@
 import seedu.address.model.meeting.ReadOnlyMeetingBook;
 
 
-import static java.util.Objects.requireNonNull;
-
 /**
  * Represents a storage for {@link MeetingBook}.
  */

src/main/java/seedu/address/storage/JsonSerializableMeetingBook.java

@@ -11,7 +11,7 @@
 import seedu.address.commons.exceptions.IllegalValueException;
 import seedu.address.model.meeting.Meeting;
 import seedu.address.model.meeting.MeetingBook;
-import seedu.address.model.meeting.ReadOnlyMeetingBook;;
+import seedu.address.model.meeting.ReadOnlyMeetingBook;
 
 /**
  * An Immutable MeetingBook that is serializable to JSON format.

src/main/java/seedu/address/storage/MeetingBookStorage.java

@@ -8,8 +8,7 @@
 import seedu.address.commons.exceptions.DataConversionException;
 import seedu.address.model.meeting.MeetingBook;
 import seedu.address.model.meeting.ReadOnlyMeetingBook;
-import seedu.address.model.person.AddressBook;
-import seedu.address.model.person.ReadOnlyAddressBook;
+
 
 /**
  * Represents a storage for {@link MeetingBook}.

src/main/java/seedu/address/storage/Storage.java

@@ -37,7 +37,7 @@ public interface Storage extends AddressBookStorage, UserPrefsStorage, MeetingBo
     Optional<ReadOnlyMeetingBook> readMeetingBook() throws DataConversionException, IOException;
 
     @Override
-    void saveMeetingBook(ReadOnlyMeetingBook MeetingBook) throws IOException;
+    void saveMeetingBook(ReadOnlyMeetingBook meetingBook) throws IOException;
 
 
 

src/test/java/seedu/address/logic/LogicManagerTest.java

@@ -48,7 +48,7 @@ public void setUp() {
                 new JsonAddressBookStorage(temporaryFolder.resolve("addressBook.json"));
         JsonUserPrefsStorage userPrefsStorage = new JsonUserPrefsStorage(temporaryFolder.resolve("userPrefs.json"));
         JsonMeetingBookStorage meetingBookStorage = new JsonMeetingBookStorage(temporaryFolder.resolve(
-                "meetingbook.json"));
+                "meetingBook.json"));
         StorageManager storage = new StorageManager(addressBookStorage, meetingBookStorage, userPrefsStorage);
         logic = new LogicManager(model, storage);
     }
@@ -98,6 +98,11 @@ public void getFilteredPersonList_modifyList_throwsUnsupportedOperationException
         assertThrows(UnsupportedOperationException.class, () -> logic.getFilteredPersonList().remove(0));
     }
 
+    @Test
+    public void getFilteredMeetingList_modifyList_throwsUnsupportedOperationException() {
+        assertThrows(UnsupportedOperationException.class, () -> logic.getFilteredMeetingList().remove(0));
+    }
+
     /**
      * Executes the command and confirms that
      * - no exceptions are thrown <br>

src/test/java/seedu/address/model/ModelManagerTest.java

@@ -15,6 +15,7 @@
 import org.junit.jupiter.api.Test;
 
 import seedu.address.commons.core.GuiSettings;
+import seedu.address.model.meeting.MeetingBook;
 import seedu.address.model.person.AddressBook;
 import seedu.address.model.person.NameContainsKeywordsPredicate;
 import seedu.address.testutil.AddressBookBuilder;
@@ -28,6 +29,7 @@ public void constructor() {
         assertEquals(new UserPrefs(), modelManager.getUserPrefs());
         assertEquals(new GuiSettings(), modelManager.getGuiSettings());
         assertEquals(new AddressBook(), new AddressBook(modelManager.getAddressBook()));
+        assertEquals(new MeetingBook(), new MeetingBook(modelManager.getMeetingBook()));
     }
 
     @Test

src/test/java/seedu/address/storage/JsonMeetingBookStorageTest.java

@@ -1,23 +1,23 @@
 package seedu.address.storage;
 
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.io.TempDir;
-import seedu.address.commons.exceptions.DataConversionException;
-import seedu.address.model.meeting.MeetingBook;
-import seedu.address.model.meeting.ReadOnlyMeetingBook;
-import seedu.address.model.person.AddressBook;
-import seedu.address.model.person.ReadOnlyAddressBook;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static seedu.address.testutil.Assert.assertThrows;
+import static seedu.address.testutil.TypicalMeetings.MEETING1;
+import static seedu.address.testutil.TypicalMeetings.MEETING6;
+import static seedu.address.testutil.TypicalMeetings.getTypicalMeetingBook;
 
 import java.io.IOException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Optional;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static seedu.address.testutil.Assert.assertThrows;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+import seedu.address.commons.exceptions.DataConversionException;
+import seedu.address.model.meeting.MeetingBook;
+import seedu.address.model.meeting.ReadOnlyMeetingBook;
 
-import static seedu.address.testutil.TypicalMeetings.*;
-import static seedu.address.testutil.TypicalPersons.IDA;
 
 public class JsonMeetingBookStorageTest {
     private static final Path TEST_DATA_FOLDER = Paths.get("src", "test", "data", "JsonMeetingBookStorageTest");
@@ -47,7 +47,7 @@ public void readMeetingBook_missingFile_returnsEmptyOptional() throws Exception
 
     @Test
     public void readMeetingBook_invalidMeetingFile_throwsDataConversionException() throws Exception {
-        assertThrows(DataConversionException.class, () -> readMeetingBook("invalidMeetingMeetingBook.json") );
+        assertThrows(DataConversionException.class, () -> readMeetingBook("invalidMeetingMeetingBook.json"));
     }
 
     @Test

src/test/java/seedu/address/storage/JsonSerializableMeetingBookTest.java

@@ -1,18 +1,19 @@
 package seedu.address.storage;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static seedu.address.testutil.Assert.assertThrows;
+
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
 import org.junit.jupiter.api.Test;
+
 import seedu.address.commons.exceptions.IllegalValueException;
 import seedu.address.commons.util.JsonUtil;
 import seedu.address.model.meeting.MeetingBook;
 import seedu.address.testutil.TypicalMeetings;
 
 
-import java.nio.file.Path;
-import java.nio.file.Paths;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static seedu.address.testutil.Assert.assertThrows;
-
 public class JsonSerializableMeetingBookTest {
     private static final Path TEST_DATA_FOLDER = Paths.get("src", "test", "data", "JsonSerializableMeetingBookTest");
     private static final Path TYPICAL_MEETINGS_FILE = TEST_DATA_FOLDER.resolve("sampleMeetingBook.json");