Skip to content

Commit a061ad9

Browse files
committed
Revert the addition of Matrix44.setEulerAngles/setAxisAngle from #305
This alters the ABI in what should be a patch release. Signed-off-by: Cary Phillips <[email protected]>
1 parent 3ec6904 commit a061ad9

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

src/python/PyImath/PyImathMatrix44.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -648,22 +648,6 @@ setValue44(Matrix44<T> &mat, const Matrix44<T> &value)
648648
mat.setValue(value);
649649
}
650650

651-
template <class T>
652-
static void
653-
setEulerAngles44(Matrix44<T> &mat, const Vec3<T> &value)
654-
{
655-
MATH_EXC_ON;
656-
mat.setEulerAngles(value);
657-
}
658-
659-
template <class T>
660-
static void
661-
setAxisAngle44(Matrix44<T> &mat, const Vec3<T> &axis, T angle)
662-
{
663-
MATH_EXC_ON;
664-
mat.setAxisAngle(axis, angle);
665-
}
666-
667651
template <class T>
668652
static const Matrix44<T> &
669653
shearV44(Matrix44<T> &mat, const Vec3<T> &s)
@@ -1125,8 +1109,6 @@ register_Matrix44()
11251109
.def("setTranslation", &setTranslation44Tuple<T>, return_internal_reference<>(),"setTranslation()")
11261110
.def("setTranslation", &setTranslation44Obj<T>, return_internal_reference<>(),"setTranslation()")
11271111
.def("setValue", &setValue44<T>, "setValue()")
1128-
.def("setEulerAngles", &setEulerAngles44<T>, "setEulerAngles()")
1129-
.def("setAxisAngle", &setAxisAngle44<T>, "setAxisAngle()")
11301112
.def("shear", &shearV44<T>, return_internal_reference<>(),"shear()")
11311113
.def("shear", &shearS44<T>, return_internal_reference<>(),"shear()")
11321114
.def("shear", &shear44Tuple<T>, return_internal_reference<>(),"shear()")

src/python/PyImathTest/pyImathTest.in

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6107,19 +6107,6 @@ def testM44x (Mat, Vec):
61076107
m.extractEulerXYZ(v)
61086108
assert v.equalWithAbsError((0, 0, -a), v.baseTypeEpsilon())
61096109

6110-
e = Vec(0,0,-a)
6111-
m.setEulerAngles(e)
6112-
assert (equal(m[0][0], cos(a), 0.0001))
6113-
assert (equal(m[0][1], -sin(a), 0.0001))
6114-
assert (equal(m[1][0], sin(a), 0.0001))
6115-
assert (equal(m[1][1], cos(a), 0.0001))
6116-
6117-
axis = Vec(0,0,1)
6118-
m.setAxisAngle(axis,-a)
6119-
assert (equal(m[0][0], cos(a), 0.0001))
6120-
assert (equal(m[0][1], -sin(a), 0.0001))
6121-
assert (equal(m[1][0], sin(a), 0.0001))
6122-
assert (equal(m[1][1], cos(a), 0.0001))
61236110

61246111
# Extract scale, shear, rotation, translation.
61256112

0 commit comments

Comments
 (0)