[rust/rqd] Add clippy check to rust project (#1767)

Clippy provides additional safety checks to rust projects and having it
as part of the CICD is a good practice.

All suggestions have been applied

Author: DiegoTavares

.github/workflows/rust.yml

@@ -28,3 +28,18 @@ jobs:
         run: |
           cd rust
           cargo test --verbose
+
+  clippy:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install X11 dev libs
+        run: |
+          sudo apt-get update && sudo apt-get install -y libx11-dev
+      - name: Install Protoc
+        uses: arduino/setup-protoc@v3
+      - name: Run Clippy
+        run: |
+          cd rust
+          cargo clippy --verbose

.gitignore

@@ -26,3 +26,4 @@ cuebot/.project
 /proto/opencue_proto/
 /pycue/opencue/compiled_proto/
 /rqd/rqd/compiled_proto/
+docker-compose-local.yml

rust/crates/dummy-cuebot/src/main.rs

@@ -100,13 +100,13 @@ impl DummyCuebotCli {
     pub async fn run(&self) -> Result<()> {
         match &self.subcommands {
             SubCommands::ReportServer(report_server_cmd) => {
-                DummyCuebotServer::start_server(report_server_cmd.port.clone()).await
+                DummyCuebotServer::start_server(report_server_cmd.port).await
             }
             SubCommands::RqdClient(cmd) => {
                 let client = DummyRqdClient::build(cmd.hostname.clone(), cmd.port).await?;
                 match &cmd.api_method {
                     ApiMethod::LaunchFrame(cmd) => {
-                        let uid = cmd.run_as_user.then(|| users::get_current_uid());
+                        let uid = cmd.run_as_user.then(users::get_current_uid);
                         client
                             .launch_frame(
                                 cmd.cmd.clone(),

rust/crates/dummy-cuebot/src/rqd_client.rs

@@ -52,10 +52,7 @@ impl DummyRqdClient {
             attributes: HashMap::new(),
             num_gpus: 0,
             children: None,
-            uid_optional: match uid {
-                Some(uid) => Some(UidOptional::Uid(uid as i32)),
-                None => None,
-            },
+            uid_optional: uid.map(|uid| UidOptional::Uid(uid as i32)),
             os: "macos".to_string(),
             soft_memory_limit: 0,
             hard_memory_limit: 0,
@@ -76,8 +73,9 @@ impl DummyRqdClient {
         };
 
         let mut client = self.client.lock().await;
-        let mut request = pb::RqdStaticLaunchFrameRequest::default();
-        request.run_frame = Some(run_frame);
+        let request = pb::RqdStaticLaunchFrameRequest {
+            run_frame: Some(run_frame),
+        };
         client
             .launch_frame(request)
             .await
@@ -87,8 +85,10 @@ impl DummyRqdClient {
 
     pub async fn kill_frame(&self, frame_id: String, reason: Option<String>) -> Result<()> {
         let mut client = self.client.lock().await;
-        let mut request = pb::RqdStaticKillRunningFrameRequest::default();
-        request.frame_id = frame_id;
+        let mut request = pb::RqdStaticKillRunningFrameRequest {
+            frame_id,
+            ..Default::default()
+        };
         request.message = reason.unwrap_or("No reason".to_string());
         client
             .kill_running_frame(request)

rust/crates/opencue-proto/build.rs

@@ -11,7 +11,7 @@ fn build_protobuf() -> Result<(), Box<dyn std::error::Error>> {
 
     let subdir_proto_files: Vec<String> = std::fs::read_dir(&protos_dir)?
         .map(|dir| protos_dir.join(dir.unwrap().file_name()))
-        .filter(|entry| entry.is_file() && entry.extension().map_or(false, |ext| ext == "proto"))
+        .filter(|entry| entry.is_file() && entry.extension().is_some_and(|ext| ext == "proto"))
         .map(|path| path.to_string_lossy().to_string())
         .collect();
     proto_files.extend(subdir_proto_files);

rust/crates/opencue-proto/src/lib.rs

@@ -12,10 +12,13 @@ mod cue;
 mod department;
 mod depend;
 pub mod facility;
+#[allow(clippy::all, clippy::pedantic, clippy::nursery)]
 mod filter;
 pub mod host;
+#[allow(clippy::all, clippy::pedantic, clippy::nursery)]
 pub mod job;
 mod limit;
+#[allow(clippy::all, clippy::pedantic, clippy::nursery)]
 mod render_partition;
 pub mod report;
 pub mod rqd;
@@ -74,21 +77,17 @@ impl WithUuid for rqd::RunningFrameKillRequest {
     fn uuid(&self) -> Uuid {
         self.run_frame
             .as_ref()
-            .map(|run_frame| to_uuid(&run_frame.frame_id))
-            .flatten()
+            .and_then(|run_frame| to_uuid(&run_frame.frame_id))
             .unwrap_or(Uuid::nil())
-            .clone()
     }
 }
 
 impl WithUuid for rqd::RunningFrameStatusRequest {
     fn uuid(&self) -> Uuid {
         self.run_frame
             .as_ref()
-            .map(|run_frame| to_uuid(&run_frame.frame_id))
-            .flatten()
+            .and_then(|run_frame| to_uuid(&run_frame.frame_id))
             .unwrap_or(Uuid::nil())
-            .clone()
     }
 }
 

rust/crates/rqd/src/config/config.rs

@@ -184,6 +184,7 @@ impl RunnerConfig {
 
 #[derive(Debug, Deserialize, Clone)]
 #[serde(default)]
+#[derive(Default)]
 pub struct OverrideConfig {
     pub cores: Option<u64>,
     pub procs: Option<u64>,
@@ -193,18 +194,6 @@ pub struct OverrideConfig {
     pub os: Option<String>,
 }
 
-impl Default for OverrideConfig {
-    fn default() -> OverrideConfig {
-        OverrideConfig {
-            cores: None,
-            procs: None,
-            memory_size: None,
-            workstation_mode: None,
-            hostname: None,
-            os: None,
-        }
-    }
-}
 
 //===Config Loader===
 
@@ -232,7 +221,7 @@ impl Config {
         println!(" INFO Config::load: using config file: {:?}", config_file);
 
         let config = ConfigBase::builder()
-            .add_source(File::with_name(&*config_file).required(required))
+            .add_source(File::with_name(&config_file).required(required))
             .add_source(Environment::with_prefix("OPENRQD").separator("_"))
             .build()
             .map_err(|err| {